[PATCH 2/7] block: Fix double put in blk_integrity_unregister

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Martin K. Petersen
Date: Wednesday, October 1, 2008 - 12:38 am

- kobject_del already puts the parent.

 - Set integrity profile to NULL to prevent stale data.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/blk-integrity.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block/blk-integrity.c b/block/blk-integrity.c
index 69023da..e3817a0 100644
--- a/block/blk-integrity.c
+++ b/block/blk-integrity.c
@@ -376,7 +376,7 @@ void blk_integrity_unregister(struct gendisk *disk)
 
 	kobject_uevent(&bi->kobj, KOBJ_REMOVE);
 	kobject_del(&bi->kobj);
-	kobject_put(&disk_to_dev(disk)->kobj);
 	kmem_cache_free(integrity_cachep, bi);
+	disk->integrity = NULL;
 }
 EXPORT_SYMBOL(blk_integrity_unregister);
-- 
1.6.0.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Block integrity patches for 2.6.28, Martin K. Petersen, (Wed Oct 1, 12:38 am)
[PATCH 1/7] block: Introduce integrity data ownership flag, Martin K. Petersen, (Wed Oct 1, 12:38 am)
[PATCH 2/7] block: Fix double put in blk_integrity_unregister, Martin K. Petersen, (Wed Oct 1, 12:38 am)
[PATCH 3/7] block: Switch blk_integrity_compare from bdev ..., Martin K. Petersen, (Wed Oct 1, 12:38 am)
[PATCH 4/7] block: gendisk integrity wrapper, Martin K. Petersen, (Wed Oct 1, 12:38 am)
[PATCH 5/7] block: Find bio sector offset given idx and offset, Martin K. Petersen, (Wed Oct 1, 12:38 am)
[PATCH 6/7] dm: Add support for data integrity to DM, Martin K. Petersen, (Wed Oct 1, 12:38 am)
[PATCH 7/7] md: Add support for data integrity to MD, Martin K. Petersen, (Wed Oct 1, 12:38 am)
Re: [PATCH 5/7] block: Find bio sector offset given idx an ..., Martin K. Petersen, (Wed Oct 1, 7:42 pm)
Re: Block integrity patches for 2.6.28, Jens Axboe, (Thu Oct 2, 3:56 am)
Re: Block integrity patches for 2.6.28, Martin K. Petersen, (Thu Oct 2, 6:54 am)
Re: Block integrity patches for 2.6.28, Jens Axboe, (Thu Oct 2, 9:29 am)