Home » Mailing list archives » linux-kernel » 2008 » October » 1

Re: [PATCH 9/12] memcg allocate all page_cgroup at boot

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Balbir Singh
Subject: Re: [PATCH 9/12] memcg allocate all page_cgroup at boot
Date: Tuesday, September 30, 2008 - 10:59 pm

KAMEZAWA Hiroyuki wrote:

In the past patches, I've used lock_page_cgroup(). In some cases like
initialization at boot time, I've ignored taking the lock, since I know no-one
is accessing them yet.


__mem_cgroup_move_lists() is called from mem_cgroup_isolate_pages() and
mem_cgroup_move_lists(). In mem_cgroup_move_lists(), we have the page_cgroup
lock. I think the current code works on the assumption (although not documented
anywhere I've seen), that PAGE_CGROUP_FLAG_INACTIVE/ACTIVE/UNEVICTABLE bits are
protected by lru_lock. Please look at

__mem_cgroup_remove_list
__mem_cgroup_add_list
__mem_cgroup_move_lists
__mem_cgroup_charge_common (sets this flag, before the pc is associated with the
page).

Am I missing something (today is holiday here, so I am in a bit of a lazy/sleepy
mood :) )

-- 
	Balbir
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:11 pm)
[PATCH 1/12] memcg avoid accounting special mappings not o ..., KAMEZAWA Hiroyuki, (Wed Sep 24, 11:13 pm)
[PATCH 2/12] memcg move charege() call to swapped-in page ..., KAMEZAWA Hiroyuki, (Wed Sep 24, 11:14 pm)
[PATCH 3/12] memcg make root cgroup unlimited., KAMEZAWA Hiroyuki, (Wed Sep 24, 11:15 pm)
[PATCH 4/12] memcg make page->mapping NULL before calling ..., KAMEZAWA Hiroyuki, (Wed Sep 24, 11:16 pm)
[PATCH 5/12] memcg make page_cgroup->flags atomic, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:17 pm)
[PATCH 6/12] memcg optimize percpu stat, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:18 pm)
[PATCH 7/12] memcg add function to move account, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:27 pm)
[PATCH 8/12] memcg rewrite force empty to move account to root, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:29 pm)
[PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:32 pm)
[PATCH 10/12] memcg free page_cgroup from LRU in lazy, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:33 pm)
[PATCH 11/12] memcg add to LRU in lazy, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:35 pm)
[PATCH 12/12] memcg: fix race at charging swap-in, KAMEZAWA Hiroyuki, (Wed Sep 24, 11:36 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Dave Hansen, (Thu Sep 25, 11:40 am)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Daisuke Nishimura, (Thu Sep 25, 6:00 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 6:17 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 6:22 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 6:43 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:05 pm)
[PATCH(fixed) 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:21 pm)
[PATCH(fixed) 10/12] free page cgroup from LRU in lazy, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:25 pm)
[PATCH(fixed) 11/12] free page cgroup from LRU in add, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:28 pm)
Re: [PATCH 0/12] memcg updates v5, Daisuke Nishimura, (Thu Sep 25, 7:32 pm)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Thu Sep 25, 7:58 pm)
Re: [PATCH 0/12] memcg updates v5, Daisuke Nishimura, (Thu Sep 25, 8:00 pm)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Thu Sep 25, 8:04 pm)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Thu Sep 25, 9:05 pm)
Re: [PATCH 0/12] memcg updates v5, Daisuke Nishimura, (Thu Sep 25, 10:24 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Daisuke Nishimura, (Thu Sep 25, 10:54 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Thu Sep 25, 11:54 pm)
Re: [PATCH 7/12] memcg add function to move account, Daisuke Nishimura, (Fri Sep 26, 12:30 am)
Re: [PATCH 0/12] memcg updates v5, Balbir Singh, (Fri Sep 26, 1:18 am)
Re: [PATCH 1/12] memcg avoid accounting special mappings n ..., Balbir Singh, (Fri Sep 26, 1:25 am)
Re: [PATCH 2/12] memcg move charege() call to swapped-in p ..., Balbir Singh, (Fri Sep 26, 1:36 am)
Re: [PATCH 3/12] memcg make root cgroup unlimited., Balbir Singh, (Fri Sep 26, 1:41 am)
Re: [PATCH 1/12] memcg avoid accounting special mappings n ..., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:17 am)
Re: [PATCH 2/12] memcg move charege() call to swapped-in p ..., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:18 am)
Re: [PATCH 3/12] memcg make root cgroup unlimited., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:21 am)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 2:22 am)
Re: [PATCH 7/12] memcg add function to move account, KAMEZAWA Hiroyuki, (Fri Sep 26, 2:24 am)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 2:28 am)
Re: [PATCH 3/12] memcg make root cgroup unlimited., Balbir Singh, (Fri Sep 26, 2:29 am)
Re: [PATCH 0/12] memcg updates v5, Balbir Singh, (Fri Sep 26, 2:31 am)
Re: [PATCH 1/12] memcg avoid accounting special mappings n ..., Balbir Singh, (Fri Sep 26, 2:32 am)
Re: [PATCH 4/12] memcg make page->mapping NULL before call ..., Balbir Singh, (Fri Sep 26, 2:47 am)
Re: [PATCH 6/12] memcg optimize percpu stat, Balbir Singh, (Fri Sep 26, 2:53 am)
Re: [PATCH 1/12] memcg avoid accounting special mappings n ..., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:55 am)
Re: [PATCH 3/12] memcg make root cgroup unlimited., KAMEZAWA Hiroyuki, (Fri Sep 26, 2:59 am)
Re: [PATCH 4/12] memcg make page->mapping NULL before call ..., KAMEZAWA Hiroyuki, (Fri Sep 26, 3:07 am)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 3:36 am)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 3:43 am)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 7:53 pm)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Fri Sep 26, 8:19 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Fri Sep 26, 8:25 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Fri Sep 26, 8:47 pm)
Re: [PATCH 5/12] memcg make page_cgroup->flags atomic, Balbir Singh, (Fri Sep 26, 11:58 pm)
Re: [PATCH 7/12] memcg add function to move account, Balbir Singh, (Sat Sep 27, 12:56 am)
Re: Re: [PATCH 7/12] memcg add function to move account, kamezawa.hiroyu, (Sat Sep 27, 1:35 am)
Re: [PATCH 0/12] memcg updates v5, Balbir Singh, (Sun Sep 28, 8:02 pm)
Re: [PATCH 0/12] memcg updates v5, KAMEZAWA Hiroyuki, (Sun Sep 28, 8:27 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Balbir Singh, (Tue Sep 30, 9:03 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 10:07 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Balbir Singh, (Tue Sep 30, 10:30 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 10:32 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 10:41 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Balbir Singh, (Tue Sep 30, 10:59 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 11:12 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, KAMEZAWA Hiroyuki, (Tue Sep 30, 11:17 pm)
Re: [PATCH 9/12] memcg allocate all page_cgroup at boot, Balbir Singh, (Tue Sep 30, 11:26 pm)