Home » Mailing list archives » linux-kernel » 2008 » January » 9

[PATCH] libata and starting/stopping ATAPI floppy devices

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Tejun Heo <htejun@...>
To: Ondrej Zary <linux@...>
Cc: <jgarzik@...>, <linux-ide@...>, Linux Kernel <linux-kernel@...>
Subject: [PATCH] libata and starting/stopping ATAPI floppy devices
Date: Wednesday, January 9, 2008 - 7:41 pm

From: Ondrej Zary <linux@rainbow-software.org>

Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy 
drives) as they don't seem to like it:

sd 1:0:1:0: [sdb] Starting disk
ata2.01: configured for PIO2
sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08
sd 1:0:1:0: [sdb] Sense Key : 0x2 [current]
sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
Trimmed message body and reformatted such that it's script friendly.

 drivers/ata/libata-scsi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.23-orig/drivers/ata/libata-scsi.c	2007-10-09 22:31:38.000000000 +0200
+++ linux-2.6.23-pentium/drivers/ata/libata-scsi.c	2008-01-05 15:50:16.000000000 +0100
@@ -802,7 +802,8 @@
 
 	blk_queue_max_phys_segments(sdev->request_queue, LIBATA_MAX_PRD);
 
-	sdev->manage_start_stop = 1;
+	if (dev->class == ATA_DEV_ATA)
+		sdev->manage_start_stop = 1;
 
 	if (dev)
 		ata_scsi_dev_config(sdev, dev);

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] libata and starting/stopping ATAPI floppy devices, Ondrej Zary, (Sat Jan 5, 11:47 am)
Re: [PATCH] libata and starting/stopping ATAPI floppy devices, Tejun Heo, (Tue Jan 8, 10:41 pm)
Re: [PATCH] libata and starting/stopping ATAPI floppy devices, Ondrej Zary, (Wed Jan 9, 1:53 pm)
[PATCH] libata and starting/stopping ATAPI floppy devices, Tejun Heo, (Wed Jan 9, 7:41 pm)
Re: [PATCH] libata and starting/stopping ATAPI floppy devices, Jeff Garzik, (Thu Jan 10, 6:21 pm)