Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Anton Salikhmetov <salikhmetov@...>
Cc: <linux-mm@...>, <linux-kernel@...>
Date: Wednesday, January 9, 2008 - 4:50 pm

On Mon, 07 Jan 2008 20:54:19 +0300
Anton Salikhmetov <salikhmetov@gmail.com> wrote:


As long as the ctime and mtime stamps change when the memory is
written to, what exactly is the problem?

Is it that the ctime and mtime does not change again when the memory
is written to again?

Is there a way for backup programs to miss file modification times?

Could you explain (using short words and simple sentences) what the
exact problem is?

Eg.

1) program mmaps file
2) program writes to mmaped area
3) ???                   <=== this part, in equally simple words :)
4) data loss

An explanation like that will help people understand exactly what the
bug is, and why the patch should be applied ASAP.


Due to the various cleanups all being in one file, it took me a while
to understand the patch.  In an area of code this subtle, it may be
better to submit the cleanups in (a) separate patch(es) from the patch
that adds the call to file_update_time().


I wonder if calling file_update_time() from inside the loop is the
best idea.  Why not call that function just once, after msync breaks
from the loop?

thanks,

Rik
-- 
All Rights Reversed
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH][RFC][BUG] updating the ctime and mtime time stam..., Rik van Riel, (Wed Jan 9, 4:50 pm)
Re: [PATCH][RFC][BUG] updating the ctime and mtime time stam..., Jakob Oestergaard, (Thu Jan 10, 4:51 am)
Re: [PATCH][RFC][BUG] updating the ctime and mtime time stam..., Anton Salikhmetov, (Thu Jan 10, 6:53 am)
Re: [PATCH][RFC][BUG] updating the ctime and mtime time stam..., Anton Salikhmetov, (Thu Jan 10, 11:56 am)
Re: [PATCH][RFC][BUG] updating the ctime and mtime time stam..., Anton Salikhmetov, (Thu Jan 10, 12:40 pm)
Re: [PATCH][RFC][BUG] updating the ctime and mtime time stam..., Anton Salikhmetov, (Wed Jan 9, 11:31 am)