Simple coding style fixes. File is now "error" free according to checkpatch.pl Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> --- arch/x86/pci/direct.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/pci/direct.c b/arch/x86/pci/direct.c index 431c9a5..4eefa5c 100644 --- a/arch/x86/pci/direct.c +++ b/arch/x86/pci/direct.c @@ -50,7 +50,7 @@ int pci_conf1_write(unsigned int seg, unsigned int bus, { unsigned long flags; - if...

Fix some coding style issues. Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> --- arch/x86/pci/common.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 52deabc..7388b1a 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c @@ -67,7 +67,7 @@ static void __devinit pcibios_fixup_ghosts(struct pci_bus *b) { struct list_head *ln, *mn; struct pci_dev *d, *e; - int mirror = PC...

Hi, Running a 2.6.22 kernel and using the forcedeth driver with my ethernet card, I noticed this one is not available from the gigabit section but from the 10-100Mbit section as __nForce Ethernet Support__. [quote forcedeth.c] 0.27: 19 Jun 2004: Gigabit support, new descriptor rings, added CK804/MCP04 device IDs, code fixes for registers, link status and other minor fixes. [/quote] Shouldn't it be in the gigabit section ? Did I miss anything, or maybe this is fixed...

Potential bugs notwithstanding, given that this is a STREAM socket, and as such shouldn't (I hope, or I'm eating toes for dinner again) have side effects like tossing the rest of a datagram, why are you using MSG_PEEK? Why not simply read the N bytes of the message that will have the message length with a normal read/recv, and then read that many bytes in the next call? rick jones --

Hi, Where in the code is the message length being sent across the socket? -- Regards, Tom Spink University of Edinburgh --

Hi, But you're not consuming the size_t on the other end. You're only peeking it, i.e. you're doing the recv to peek at the message, but never calling recv to remove that data from the queue... or am I missing something? -- Regards, Tom Spink University of Edinburgh --

Edit the start script, append your commands to create the links. If you wire your devices to a named/numbered port, you can use one device node for each port. Therefore it's sane to create hda to hdd, fd0 to fd3, etc. But if you don't have a fixed mapping (USB), or if you'd have too many possible (and mostly unused) ports for the available amount of devices (SCSI), you can not create fixed numbers. Even for hde ..., you have no native ordering, you can only tell the first controller from the rest....

Hi Ingo, Here's a series which goes some way to tidying up pgtable.h. It is not complete yet, but this lot compiles and works for me. In many cases I've moved code around with no attempt at adjusting the formatting to acceptible style. That can be done in a later patch, but it means that checkpatch is noisy with this lot. Thanks, J --

threw this into the random test setup: it found the attached config after a few iterations, which needed the fix below. (config builds and boots fine with this fix) the problem was that set_pud() is used by include/asm-generic/pgtable-nopud.h, to build set_pgd(): #define set_pgd(pgdptr, pgdval) set_pud((pud_t *)(pgdptr), (pud_t) { pgdval }) it's truly a maze ... took me 10 straight minutes of staring at the code to figure out where the set_pud() came from :-/ anyway, ...

right now i'm trying to bisect this crash on 64-bit: Calling initcall 0xffffffff80395877: pci_init+0x0/0x2b() ------------[ cut here ]------------ kernel BUG at arch/x86/mm/pageattr_64.c:176! [...] Call Trace: [<ffffffff8021db68>] change_page_attr_addr+0x9e/0x119 [<ffffffff8021d44f>] ioremap_change_attr+0x49/0x58 [<ffffffff8021d626>] iounmap+0xbe/0xe0 [<ffffffff804dfc95>] quirk_usb_early_handoff+0x396/0x3a5 [<ffffffff80396ea0>] pci_fixup_device+0x90...

hm, doesnt fix it. Weird. Ingo --

Avoid a conflict between Voyager's leave_mm and asm-x86/mmu.h's leave_mm. Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> --- arch/x86/mach-voyager/voyager_smp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/mach-voyager/voyager_smp.c b/arch/x86/mach-voyager/voyager_smp.c --- a/arch/x86/mach-voyager/voyager_smp.c +++ b/arch/x86/mach-voyager/voyager_smp.c @@ -808,7 +808,7 @@ static DEFINE_SPINLOCK(tlbstate_lock); * We need to reload...

The hypervisor doesn't allow PCD or PWT to be set on guest ptes, so make sure they're masked out. Also, fix up some previous mispatching. Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> --- arch/x86/xen/mmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c @@ -244,7 +244,7 @@ pte_t xen_make_pte(unsigned long long pt if (pte & 1) pte = phys_to_machi...

Fix various compilation problems as a result of changing pte_t. Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> Cc: Zachary Amsden <zach@vmware.com> --- arch/x86/kernel/vmi_32.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/vmi_32.c b/arch/x86/kernel/vmi_32.c --- a/arch/x86/kernel/vmi_32.c +++ b/arch/x86/kernel/vmi_32.c @@ -475,7 +475,7 @@ static void vmi_set_pmd(pmd_t *pmdp, pmd static void vmi_set_pmd(pmd_t *pmdp, pmd_t ...

Make various pte accessors common. Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> --- include/asm-x86/pgtable-2level.h | 1 include/asm-x86/pgtable-3level.h | 1 include/asm-x86/pgtable.h | 110 +++++++++++++++++++++++++++++++++++++- include/asm-x86/pgtable_32.h | 101 ---------------------------------- include/asm-x86/pgtable_64.h | 43 +------------- 5 files changed, 113 insertions(+), 143 deletions(-) diff --git a/include/asm-x86/pgtable-2level.h ...

Unify functions to test and set bits in pagetable entries. Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> --- include/asm-x86/pgtable.h | 28 ++++++++++++++++++++++++++++ include/asm-x86/pgtable_32.h | 25 ------------------------- include/asm-x86/pgtable_64.h | 26 -------------------------- 3 files changed, 28 insertions(+), 51 deletions(-) diff --git a/include/asm-x86/pgtable.h b/include/asm-x86/pgtable.h --- a/include/asm-x86/pgtable.h +++ b/include/asm-x86/pgta...

Is that anything like a cluster fsck? ]:> --

V2 -> V3: + rebase to 23-mm1 atop RvR's split lru series + fix definitions of NR_MLOCK to fix build errors when not configured. V1 -> V2: + new in V2 -- pulled in & reworked from Nick's previous series From: Nick Piggin <npiggin@suse.de> To: Linux Memory Management <linux-mm@kvack.org> Cc: Nick Piggin <npiggin@suse.de>, Andrew Morton <akpm@osdl.org> Subject: [patch 4/4] mm: account mlocked pages Date: Mon, 12 Mar 2007 07:39:14 +0100 (CET) Add NR_M...

Swapin_readahead can read in a lot of data that the processes in memory never need. Adding swap cache pages to the inactive list prevents them from putting too much pressure on the working set. This has the potential to help the programs that are already in memory, but it could also be a disadvantage to processes that are trying to get swapped in. In short, this patch needs testing. Signed-off-by: Rik van Riel <riel@redhat.com> Index: linux-2.6.24-rc6-mm1/mm/swap_state.c ============...

On large memory systems, the VM can spend way too much time scanning through pages that it cannot (or should not) evict from memory. Not only does it use up CPU time, but it also provokes lock contention and can leave large systems under memory presure in a catatonic state. Against 2.6.24-rc6-mm1 This patch series improves VM scalability by: 1) making the locking a little more scalable 2) putting filesystem backed, swap backed and non-reclaimable pages onto their own LRUs, so the system o...

V2 -> V3: + rebase to 23-mm1 atop RvR's split LRU series New in V2 This patch adds a function to scan individual or all zones' noreclaim lists and move any pages that have become reclaimable onto the respective zone's inactive list, where shrink_inactive_list() will deal with them. This replaces the function to splice the entire noreclaim list onto the active list for rescan by shrink_active_list(). That method had problems with vmstat accounting and complicated '[__]isolate_lru_pages()'. ...

V1 -> V2 [lts]: + fix botched merge -- add back "get_page_unless_zero()" From: Nick Piggin <npiggin@suse.de> To: Linux Memory Management <linux-mm@kvack.org> Subject: [patch 1/4] mm: move and rework isolate_lru_page Date: Mon, 12 Mar 2007 07:38:44 +0100 (CET) isolate_lru_page logically belongs to be in vmscan.c than migrate.c. It is tough, because we don't need that function without memory migration so there is a valid argument to have it in migrate.c. However a subsequ...

Split the LRU lists in two, one set for pages that are backed by real file systems ("file") and one for pages that are backed by memory and swap ("anon"). The latter includes tmpfs. Eventually mlocked pages will be taken off the LRUs alltogether. A patch for that already exists and just needs to be integrated into this series. This patch mostly has the infrastructure and a basic policy to balance how much we scan the anon lists and how much we scan the file lists. The big policy changes are in ...

On Tue, 8 Jan 2008 14:22:38 -0800 (PST) Probably. With the split LRU lists (and the noreclaim LRUs), we can simplify the OOM test a lot: If free + file_active + file_inactive <= zone->pages_high and swap What would you use those functions for? Or am I simply misunderstanding your idea? -- All rights reversed. --

V2 -> V3: + rebase to 23-mm1 atop RvR's split lru series [no changes] V1 -> V2: + modified mmap.c:mmap_region() to return error if mlock_vma_pages_range() does. This can only occur if the vma gets removed/changed while we're switching mmap_sem lock modes. Most callers don't care, but sys_remap_file_pages() appears to. Rework of Nick Piggins's "mm: move mlocked pages off the LRU" patch -- part 2 0f 2. Remove mlocked pages from the LRU using "NoReclaim infrastructure" during...