Home » Mailing list archives » linux-kernel » 2008 » January » 8

Re: [PATCH 00 of 10] x86: unify asm/pgtable.h

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Molnar <mingo@...>
To: Jeremy Fitzhardinge <jeremy@...>
Cc: LKML <linux-kernel@...>, Andi Kleen <ak@...>, Glauber de Oliveira Costa <glommer@...>, Jan Beulich <jbeulich@...>
Subject: Re: [PATCH 00 of 10] x86: unify asm/pgtable.h
Date: Tuesday, January 8, 2008 - 7:44 pm

* Ingo Molnar <mingo@elte.hu> wrote:


it's the first one that causes the crash.

reviewed it carefully and found the bug below. Checking now whether it 
fixes the crash.

	Ingo

---
 include/asm-x86/pgtable.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-x86.q/include/asm-x86/pgtable.h
===================================================================
--- linux-x86.q.orig/include/asm-x86/pgtable.h
+++ linux-x86.q/include/asm-x86/pgtable.h
@@ -68,7 +68,7 @@ extern unsigned long long __PAGE_KERNEL,
 #endif	/* __ASSEMBLER__ */
 #else
 #define __PAGE_KERNEL_EXEC						\
-	(_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED | _PAGE_GLOBAL)
+	(_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED)
 #define __PAGE_KERNEL		(__PAGE_KERNEL_EXEC | _PAGE_NX)
 #endif
 

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 6:42 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 7:12 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 7:23 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 7:28 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 8:07 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 7:44 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 8:01 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 8:13 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 8:20 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 8:28 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 8:30 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 8:53 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Andi Kleen, (Tue Jan 8, 9:11 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 8:59 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 9:07 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Andi Kleen, (Tue Jan 8, 9:12 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 9:35 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jan Beulich, (Wed Jan 9, 5:37 am)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Andi Kleen, (Tue Jan 8, 9:42 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 9:56 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Andi Kleen, (Tue Jan 8, 10:11 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Wed Jan 9, 6:47 am)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Andi Kleen, (Wed Jan 9, 10:26 am)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 11:22 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Wed Jan 9, 6:48 am)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 9:20 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 8:43 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 9:09 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 9:16 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 9:21 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 9:37 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Andi Kleen, (Tue Jan 8, 9:18 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 9:22 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Andi Kleen, (Tue Jan 8, 9:37 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Jeremy Fitzhardinge, (Tue Jan 8, 8:55 pm)
Re: [PATCH 00 of 10] x86: unify asm/pgtable.h, Ingo Molnar, (Tue Jan 8, 7:51 pm)
[PATCH 05 of 10] x86: page.h: make pte_t a union to always i..., Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
[PATCH 02 of 10] x86: avoid name conflict for Voyager leave_mm, Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
[PATCH 09 of 10] x86: unify paravirt pagetable accessors, Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
[PATCH 10 of 10] xen: mask out PWT too, Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
Re: [PATCH 10 of 10] xen: mask out PWT too, Jan Beulich, (Wed Jan 9, 5:17 am)
Re: [PATCH 10 of 10] xen: mask out PWT too, Jeremy Fitzhardinge, (Wed Jan 9, 3:04 pm)
[PATCH 08 of 10] x86: unify zero_page definition, Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
[PATCH 06 of 10] x86/vmi: fix compilation as a result of pte..., Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
[PATCH 04 of 10] x86: unify pgtable accessors which use supp..., Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
[PATCH 07 of 10] x86: pgtable: unify pte accessors, Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
[PATCH 01 of 10] x86: move all asm/pgtable constants into on..., Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)
[PATCH 03 of 10] x86/pgtable: unify pagetable accessors, Jeremy Fitzhardinge, (Tue Jan 8, 6:00 pm)