Home » Mailing list archives » linux-kernel » 2008 » January » 8

Re: [PATCHv2] kprobes: Introduce is_kprobe_fault()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Paul Mackerras <paulus@...>
To: Harvey Harrison <harvey.harrison@...>
Cc: Andrew Morton <akpm@...>, LKML <linux-kernel@...>, Masami Hiramatsu <mhiramat@...>, Ananth N Mavinakayanahalli <ananth@...>, David Miller <davem@...>, <hskinnemoen@...>, <schwidefsky@...>, <heiko.carstens@...>, <tony.luck@...>, Ingo Molnar <mingo@...>
Subject: Re: [PATCHv2] kprobes: Introduce is_kprobe_fault()
Date: Tuesday, January 8, 2008 - 6:45 pm

Harvey Harrison writes:


I don't like the name "is_kprobe_fault" since the function actually
handles the fault - i.e. it does more than just tell the caller
whether this is a kprobes fault.  Something like
"handle_kprobes_fault" or "maybe_handle_kprobes_fault" would be
better IMO.

Paul.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCHv2] kprobes: Introduce is_kprobe_fault(), Harvey Harrison, (Mon Jan 7, 4:24 pm)
Re: [PATCHv2] kprobes: Introduce is_kprobe_fault(), Paul Mackerras, (Tue Jan 8, 6:45 pm)
Re: [PATCHv2] kprobes: Introduce is_kprobe_fault(), Harvey Harrison, (Tue Jan 8, 7:02 pm)
[PATCHv3] kprobes: Introduce kprobe_handle_fault(), Harvey Harrison, (Wed Jan 9, 12:19 am)
Re: [PATCHv3] kprobes: Introduce kprobe_handle_fault(), Christoph Hellwig, (Wed Jan 9, 3:57 am)
Re: [PATCHv3] kprobes: Introduce kprobe_handle_fault(), Heiko Carstens, (Wed Jan 9, 2:14 am)
Re: [PATCHv3] kprobes: Introduce kprobe_handle_fault(), Christoph Hellwig, (Wed Jan 9, 3:58 am)
Re: [PATCHv3] kprobes: Introduce kprobe_handle_fault(), Harvey Harrison, (Wed Jan 9, 2:22 am)
[PATCHv4] kprobes: Introduce kprobe_handle_fault(), Harvey Harrison, (Wed Jan 9, 6:01 pm)
Re: [PATCHv4] kprobes: Introduce kprobe_handle_fault(), Masami Hiramatsu, (Wed Jan 9, 7:31 pm)
Re: [PATCHv4] kprobes: Introduce kprobe_handle_fault(), Heiko Carstens, (Wed Jan 9, 7:16 pm)
[PATCH 2/2] kprobe: remove preempt_enable/disable from kprob..., Harvey Harrison, (Wed Jan 9, 8:45 pm)
Re: [PATCH 2/2] kprobe: remove preempt_enable/disable from k..., Masami Hiramatsu, (Wed Jan 9, 11:15 pm)
[PATCH 1/2] kprobes: Introduce kprobe_handle_fault(), Harvey Harrison, (Wed Jan 9, 8:44 pm)
Re: [PATCH 1/2] kprobes: Introduce kprobe_handle_fault(), Ingo Molnar, (Thu Jan 10, 8:50 am)
Re: [PATCH 1/2] kprobes: Introduce kprobe_handle_fault(), Masami Hiramatsu, (Wed Jan 9, 11:15 pm)
Re: [PATCHv4] kprobes: Introduce kprobe_handle_fault(), Harvey Harrison, (Wed Jan 9, 8:25 pm)
Re: [PATCHv2] kprobes: Introduce is_kprobe_fault(), Masami Hiramatsu, (Tue Jan 8, 1:03 pm)
Re: [PATCHv2] kprobes: Introduce is_kprobe_fault(), Ananth N Mavinakayanahalli..., (Tue Jan 8, 1:37 am)