Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alexey Dobriyan <adobriyan@...>
Cc: <linux-kernel@...>, <apw@...>
Date: Tuesday, January 8, 2008 - 3:18 pm

> Thanks, Andi! I think it'd very useful change.

Reminds me this is something that should be actually flagged
in checkpatch.pl too

Andy, it would be good if checkpatch.pl complained about .ioctl = 
as opposed to .unlocked_ioctl = ...

Also perhaps if a whole new file_operations with a ioctl is added
complain about missing compat_ioctl as a low prioritity warning?
(might be ok if it's architecture specific on architectures without
compat layer) 

-Andi
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [JANITOR PROPOSAL] Switch ioctl functions to -&gt;unlock..., Alasdair G Kergon, (Thu Jan 10, 7:39 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to -&gt;unlock..., Christoph Hellwig, (Thu Jan 10, 4:34 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlock..., Andi Kleen, (Tue Jan 8, 3:18 pm)