Andi Kleen wrote:
quoted text > THREAD_ORDER should be used on 32bit too.
>
> 32bit also has the equivalent of irq stacks (quite similar)
> and exception stacks (somewhat different). Currently they use
> other defines, but they could use the same. Also i386 has varying
> irqstack orders disabling them with 8k stacks, but that is something
> that would be best dropped and irqstacks always used imho.
> [...]
> It might be, but it's not a 64bit specific concept.
>
OK. That's out of the scope of these particular patches, since they're
restricting themselves to just unifying what's there. Another pass
could definitely tidy a lot more up.
quoted text > Yes they do, but hardcoding that doesn't make sense because it varies.
> We already got CPUs with 36, 38, 40 and 48 bits phys size.
>
> The only size that could be hard coded would be 52 bit (theoretical max), but
> that also doesn't make sense if all we want to do is to mask off NX.
>
OK. I'll see how much removing it gains us.
J
--
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH 1 of 8] x86: page.h: unify constants , Jeremy Fitzhardinge , (Mon Jan 7, 9:11 pm)