Re: [patch 3/5] Add the end-of-trace marker and the module list to WARN_ON()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: David Woodhouse <dwmw2@...>

Cc: Arjan van de Ven <arjan@...>, <linux-kernel@...>, <akpm@...>, <heiko.carstens@...>, <olof@...>, <mingo@...>, <mpm@...>

Subject: Re: [patch 3/5] Add the end-of-trace marker and the module list to WARN_ON()

Date: Monday, January 7, 2008 - 1:31 pm

On Sun, 06 Jan 2008 10:04:06 GMT, David Woodhouse said:
quoted text> 
> On Sat, 2008-01-05 at 19:10 -0800, Arjan van de Ven wrote:
> > Another issue is that, unlike oopses, WARN_ON() doesn't currently
> > printk the helpful "cut here" line, 
> 
> I'd rather see the 'cut here' line disappear altogether. Often, the
> line(s) which come immediately before it are extremely relevant to the
> problem. Cutting them is bad.

How about "--- cut 10 lines above this line ---"?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 0/5] enhance WARN_ON series, Arjan van de Ven, (Sat Jan 5, 11:07 pm)

[PATCH] Add bug/warn marker to generic report_bug(), Olof Johansson, (Sun Jan 6, 4:22 pm)

Re: [PATCH] Add bug/warn marker to generic report_bug(), Arjan van de Ven, (Sun Jan 6, 5:38 pm)

Re: [PATCH] Add bug/warn marker to generic report_bug(), Olof Johansson, (Sun Jan 6, 9:22 pm)

Re: [PATCH] Add bug/warn marker to generic report_bug(), Arjan van de Ven, (Mon Jan 7, 12:55 am)

Re: [patch 0/5] enhance WARN_ON series, Ingo Molnar, (Sun Jan 6, 5:26 am)

[patch 4/5] bugh-remove-have_arch_bug--have_arch_warn, Arjan van de Ven, (Sat Jan 5, 11:11 pm)

[patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON, Arjan van de Ven, (Sat Jan 5, 11:12 pm)

Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON, Benjamin Herrenschmidt, (Sun Jan 6, 7:16 am)

Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON, Olof Johansson, (Sun Jan 6, 10:46 am)

[patch 3/5] Add the end-of-trace marker and the module list ..., Arjan van de Ven, (Sat Jan 5, 11:10 pm)

Re: [patch 3/5] Add the end-of-trace marker and the module l..., David Woodhouse, (Sun Jan 6, 6:04 am)

Re: [patch 3/5] Add the end-of-trace marker and the module l..., , (Mon Jan 7, 1:31 pm)

[patch 2/5] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 11:09 pm)

Re: [patch 2/5] move WARN_ON() out of line, Olof Johansson, (Sun Jan 6, 3:40 pm)

[patch 1/5] Introduce __WARN(), Arjan van de Ven, (Sat Jan 5, 11:08 pm)

Re: [patch 1/5] Introduce __WARN(), Richard Knutsson, (Sun Jan 6, 7:44 am)

Re: [patch 1/5] Introduce __WARN(), Arjan van de Ven, (Sun Jan 6, 11:42 am)

Re: [patch 1/5] Introduce __WARN(), Richard Knutsson, (Sun Jan 6, 12:09 pm)

Re: [patch 1/5] Introduce __WARN(), Arjan van de Ven, (Sun Jan 6, 1:10 pm)

Re: [patch 1/5] Introduce __WARN(), Richard Knutsson, (Sun Jan 6, 1:42 pm)


linux-kernel:
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Willy Tarreau	Re: Linux 2.6.21
Jan Kundrát	kswapd high CPU usage with no swap
git:

linux-netdev:
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
David Miller	Re: [PATCH] tcp: splice as many packets as possible at once
openbsd-misc: