Home » Mailing list archives » linux-kernel » 2008 » January » 6

Re: [PATCH 1/3] power_supply: add few more values and props

Previous thread: Linux and iptables by willem on Sunday, January 6, 2008 - 6:02 am. (2 messages)

Next thread: [PATCH 2/3] pda_power: add suspend/resume support by Dmitry Baryshkov on Sunday, January 6, 2008 - 8:28 am. (1 message)
[view original message]
From: Dmitry Baryshkov <dbaryshkov@...>
To: <cbouatmailru@...>, <linux-kernel@...>, <cbou@...>, <dwmw2@...>
Subject: [PATCH 1/3] power_supply: add few more values and props
Date: Sunday, January 6, 2008 - 8:27 am

Add LiMn (one of the most common for small non-rechargable batteries)i

battery technology and voltage_min/_max properties support.


Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>


diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c

index 249f61b..45d2f95 100644

--- a/drivers/power/power_supply_sysfs.c

+++ b/drivers/power/power_supply_sysfs.c

@@ -46,7 +46,8 @@ static ssize_t power_supply_show_property(struct device *dev,

 		"Unspecified failure"

 	};

 	static char *technology_text[] = {

-		"Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", "NiCd"

+		"Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", "NiCd",

+		"LiMn"

 	};

 	static char *capacity_level_text[] = {

 		"Unknown", "Critical", "Low", "Normal", "High", "Full"

@@ -88,6 +89,8 @@ static struct device_attribute power_supply_attrs[] = {

 	POWER_SUPPLY_ATTR(present),

 	POWER_SUPPLY_ATTR(online),

 	POWER_SUPPLY_ATTR(technology),

+	POWER_SUPPLY_ATTR(voltage_max),

+	POWER_SUPPLY_ATTR(voltage_min),

 	POWER_SUPPLY_ATTR(voltage_max_design),

 	POWER_SUPPLY_ATTR(voltage_min_design),

 	POWER_SUPPLY_ATTR(voltage_now),

diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h

index 606c095..cdbc5b8 100644

--- a/include/linux/power_supply.h

+++ b/include/linux/power_supply.h

@@ -54,6 +54,7 @@ enum {

 	POWER_SUPPLY_TECHNOLOGY_LIPO,

 	POWER_SUPPLY_TECHNOLOGY_LiFe,

 	POWER_SUPPLY_TECHNOLOGY_NiCd,

+	POWER_SUPPLY_TECHNOLOGY_LiMn,

 };


 enum {

@@ -72,6 +73,8 @@ enum power_supply_property {

 	POWER_SUPPLY_PROP_PRESENT,

 	POWER_SUPPLY_PROP_ONLINE,

 	POWER_SUPPLY_PROP_TECHNOLOGY,

+	POWER_SUPPLY_PROP_VOLTAGE_MAX,

+	POWER_SUPPLY_PROP_VOLTAGE_MIN,

 	POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN,

 	POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,

 	POWER_SUPPLY_PROP_VOLTAGE_NOW,

--

With best wishes

Dmitry


--
[view original message]
From: Anton Vorontsov <cbouatmailru@...>
To: Dmitry Baryshkov <dbaryshkov@...>
Cc: <linux-kernel@...>, <cbou@...>, <dwmw2@...>
Subject: Re: [PATCH 1/3] power_supply: add few more values and props
Date: Sunday, January 6, 2008 - 10:09 am

Much thanks, all patches look good to me. Few questions about


I'd suggest keep Documentation/power_supply_class.txt in sync

wrt new properties, to distinct their meanings and usage.


I assume you're using these new properties for non-rechargeable

LiMn batteries. So, why new properties, aren't voltage_*_design

ones suits that purpose? If battery is non-rechargeable it is


Thanks,


--

Anton Vorontsov

email: cbou@mail.ru

backup email: ya-cbou@yandex.ru

irc://irc.freenode.net/bd2

--
[view original message]
From: Dmitry <dbaryshkov@...>
To: <cbouatmailru@...>
Cc: <linux-kernel@...>, <cbou@...>, <dwmw2@...>
Subject: Re: [PATCH 1/3] power_supply: add few more values and props
Date: Sunday, January 6, 2008 - 6:15 pm

Hi,


No, I used it for the battery driver for Sharp Zaurus SL-6000 (tosa).

It's connected via simple ADC so I can get only voltages. I don't know

max_design value for the battery, but I have 'FULL' signal which I use


--

With best wishes

Dmitry

--
[view original message]
From: Anton Vorontsov <cbouatmailru@...>
To: Dmitry <dbaryshkov@...>
Cc: <linux-kernel@...>, <cbou@...>, <dwmw2@...>
Subject: Re: [PATCH 1/3] power_supply: add few more values and props
Date: Sunday, January 6, 2008 - 6:30 pm

On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote:


Ah, I see. In that case the value is empiric and voltage_max is

appropriate name indeed.


Thanks,


--

Anton Vorontsov

email: cbou@mail.ru

backup email: ya-cbou@yandex.ru

irc://irc.freenode.net/bd2

--
[view original message]
From: Dmitry <dbaryshkov@...>
To: <cbouatmailru@...>
Cc: <linux-kernel@...>, <cbou@...>, <dwmw2@...>
Subject: Re: [PATCH 1/3] power_supply: add few more values and props
Date: Sunday, January 6, 2008 - 7:13 pm

Hi,


--

With best wishes

Dmitry

--
[view original message]
From: Anton Vorontsov <cbouatmailru@...>
To: Dmitry <dbaryshkov@...>
Cc: <linux-kernel@...>, <cbou@...>, <dwmw2@...>
Subject: Re: [PATCH 1/3] power_supply: add few more values and props
Date: Sunday, January 6, 2008 - 7:11 pm

Sure thing, will do.


Thanks,


--

Anton Vorontsov

email: cbou@mail.ru

backup email: ya-cbou@yandex.ru

irc://irc.freenode.net/bd2

--
[view original message]
From: Dmitry <dbaryshkov@...>
To: <cbouatmailru@...>
Cc: <linux-kernel@...>, <cbou@...>, <dwmw2@...>
Subject: Re: [PATCH 1/3] power_supply: add few more values and props
Date: Sunday, January 6, 2008 - 7:29 pm

Hi,


--

With best wishes

Dmitry

--
Previous thread: Linux and iptables by willem on Sunday, January 6, 2008 - 6:02 am. (2 messages)

Next thread: [PATCH 2/3] pda_power: add suspend/resume support by Dmitry Baryshkov on Sunday, January 6, 2008 - 8:28 am. (1 message)