Home » Mailing list archives » linux-kernel » 2008 » January » 6

Re: [PATCH 0/7] convert semaphore to mutex in struct class

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stefan Richter <stefanr@...>
To: Dave Young <hidave.darkstar@...>
Cc: <gregkh@...>, <stern@...>, <peterz@...>, <david-b@...>, <davem@...>, <jarkao2@...>, <krh@...>, <dbrownell@...>, <James.Bottomley@...>, <a.zummo@...>, <cbou@...>, <dwmw2@...>, <khali@...>, <i2c@...>, <linux1394-devel@...>, <spi-devel-general@...>, <linux-scsi@...>, <rtc-linux@...>, <linux-kernel@...>
Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class
Date: Sunday, January 6, 2008 - 2:41 pm

Dave Young wrote:

Therefore you eventually need to repost it as a single patch.  It can't
go into one of the maintainer trees otherwise, because they only take
fully bijectable patches.  (Kernel must build and run at any point in
between any patch series.)


I was going to test it at runtime on top of 2.6.24-rc6, but the first
and second patch depend on stuff in -mm.  So, my laziness wins for now,
as -mm is not my cup of tea.

About your changelog:

	"xyz: convert semaphore to mutex in struct class

	Use mutex instead of semaphore in struct class.

	Signed-off-by: Dave Young <hidave.darkstar@gmail.com>"

You don't need the second line because it says the same as the first
line.  Either kill it, or replace it by an explanation _why_ the
semaphore is to be replaced by mutex.  (I guess you do it because they
are lighter-weight, both in semantics and in implementation, and because
there are better facilities to debug mutexes...)
-- 
Stefan Richter
-=====-==--- ---= --==-
http://arcgraph.de/sr/
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Thu Jan 3, 1:50 am)
[PATCH 1/7] driver core : convert semaphore to class in stru..., Dave Young, (Thu Jan 3, 1:52 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Stefan Richter, (Sun Jan 6, 2:41 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Sun Jan 6, 10:09 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Greg KH, (Mon Jan 7, 4:45 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Mon Jan 7, 6:00 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, David Brownell, (Mon Jan 7, 5:01 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Stefan Richter, (Mon Jan 7, 9:23 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Greg KH, (Mon Jan 7, 11:44 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Stefan Richter, (Mon Jan 7, 1:13 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Alan Stern, (Mon Jan 7, 1:25 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Greg KH, (Mon Jan 7, 1:20 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Tue Jan 8, 3:05 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Greg KH, (Tue Jan 8, 6:48 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Tue Jan 8, 9:32 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Wed Jan 9, 2:13 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Wed Jan 9, 2:37 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Wed Jan 9, 2:39 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Thu Jan 10, 5:48 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Greg KH, (Thu Jan 10, 2:39 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Thu Jan 10, 10:40 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Alan Stern, (Thu Jan 10, 11:41 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Thu Jan 10, 10:37 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Cornelia Huck, (Thu Jan 10, 9:23 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Thu Jan 10, 10:33 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Cornelia Huck, (Fri Jan 11, 4:23 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Fri Jan 11, 4:53 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Stefan Richter, (Thu Jan 10, 8:34 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Thu Jan 10, 10:18 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Jarek Poplawski, (Mon Jan 7, 10:00 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Stefan Richter, (Mon Jan 7, 12:36 pm)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Jarek Poplawski, (Thu Jan 3, 3:06 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Jarek Poplawski, (Thu Jan 3, 3:24 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Dave Young, (Thu Jan 3, 3:21 am)
Re: [PATCH 0/7] convert semaphore to mutex in struct class, Jarek Poplawski, (Thu Jan 3, 3:41 am)