Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Benjamin Herrenschmidt <benh@...>

Cc: Arjan van de Ven <arjan@...>, <linux-kernel@...>, <akpm@...>, <heiko.carstens@...>, <mingo@...>, <mpm@...>

Subject: Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON

Date: Sunday, January 6, 2008 - 10:46 am

On Sun, Jan 06, 2008 at 10:16:04PM +1100, Benjamin Herrenschmidt wrote:
quoted text> 
> On Sat, 2008-01-05 at 19:12 -0800, Arjan van de Ven wrote:
> > From: Olof Johansson <olof@lixom.net>
> > 
> > Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about
> > 4K text on a ppc64_defconfig.  The main reason seems to be that prepping
> > the arguments to the conditional trap instructions is more work than just
> > doing a compare and branch.
> 
> I'm a bit annoyed by that one ... for obvious reasons... I wish gcc
> could be better here. Also, we can't completely remove the support for
> the trap since we use that in asm in various places...

The support isn't removed, and the trap is still used. This patch has
been posted a bunch of times before and been in -mm for quite a while.


-Olof

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 0/5] enhance WARN_ON series, Arjan van de Ven, (Sat Jan 5, 11:07 pm)

[PATCH] Add bug/warn marker to generic report_bug(), Olof Johansson, (Sun Jan 6, 4:22 pm)

Re: [PATCH] Add bug/warn marker to generic report_bug(), Arjan van de Ven, (Sun Jan 6, 5:38 pm)

Re: [PATCH] Add bug/warn marker to generic report_bug(), Olof Johansson, (Sun Jan 6, 9:22 pm)

Re: [PATCH] Add bug/warn marker to generic report_bug(), Arjan van de Ven, (Mon Jan 7, 12:55 am)

Re: [patch 0/5] enhance WARN_ON series, Ingo Molnar, (Sun Jan 6, 5:26 am)

[patch 4/5] bugh-remove-have_arch_bug--have_arch_warn, Arjan van de Ven, (Sat Jan 5, 11:11 pm)

[patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON, Arjan van de Ven, (Sat Jan 5, 11:12 pm)

Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON, Benjamin Herrenschmidt, (Sun Jan 6, 7:16 am)

Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON, Olof Johansson, (Sun Jan 6, 10:46 am)

[patch 3/5] Add the end-of-trace marker and the module list ..., Arjan van de Ven, (Sat Jan 5, 11:10 pm)

Re: [patch 3/5] Add the end-of-trace marker and the module l..., David Woodhouse, (Sun Jan 6, 6:04 am)

Re: [patch 3/5] Add the end-of-trace marker and the module l..., , (Mon Jan 7, 1:31 pm)

[patch 2/5] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 11:09 pm)

Re: [patch 2/5] move WARN_ON() out of line, Olof Johansson, (Sun Jan 6, 3:40 pm)

[patch 1/5] Introduce __WARN(), Arjan van de Ven, (Sat Jan 5, 11:08 pm)

Re: [patch 1/5] Introduce __WARN(), Richard Knutsson, (Sun Jan 6, 7:44 am)

Re: [patch 1/5] Introduce __WARN(), Arjan van de Ven, (Sun Jan 6, 11:42 am)

Re: [patch 1/5] Introduce __WARN(), Richard Knutsson, (Sun Jan 6, 12:09 pm)

Re: [patch 1/5] Introduce __WARN(), Arjan van de Ven, (Sun Jan 6, 1:10 pm)

Re: [patch 1/5] Introduce __WARN(), Richard Knutsson, (Sun Jan 6, 1:42 pm)


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
Artem Bityutskiy	[PATCH 18/44 take 2] [UBI] build unit implementation
James Morris	Re: LSM conversion to static interface
git:

linux-netdev:
Paul Jackson	[PATCH] cpuset sched_load_balance kmalloc fix
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Linus Torvalds	Re: [GIT]: Networking
openbsd-misc:

Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON

Online users