[patch 1/5] Introduce __WARN()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: Arjan van de Ven <arjan@...>, <akpm@...>, <heiko.carstens@...>, <olof@...>, <mingo@...>, <mpm@...>
Date: Saturday, January 5, 2008 - 11:08 pm

From: Olof Johansson <olof@lixom.net>

Introduce __WARN() in the generic case, so the generic WARN_ON()
can use arch-specific code for when the condition is true.

Signed-off-by: Olof Johansson <olof@lixom.net>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/asm-generic/bug.h |   17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

Index: linux-2.6.24-rc6/include/asm-generic/bug.h
===================================================================
--- linux-2.6.24-rc6.orig/include/asm-generic/bug.h
+++ linux-2.6.24-rc6/include/asm-generic/bug.h
@@ -31,14 +31,19 @@ struct bug_entry {
 #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while(0)
 #endif
 
-#ifndef HAVE_ARCH_WARN_ON
+#ifndef __WARN
+#define __WARN() do {							\
+	printk("WARNING: at %s:%d %s()\n", __FILE__,			\
+		__LINE__, __FUNCTION__);				\
+	dump_stack();							\
+} while (0)
+#endif
+
+#ifndef WARN_ON
 #define WARN_ON(condition) ({						\
 	int __ret_warn_on = !!(condition);				\
-	if (unlikely(__ret_warn_on)) {					\
-		printk("WARNING: at %s:%d %s()\n", __FILE__,		\
-			__LINE__, __FUNCTION__);			\
-		dump_stack();						\
-	}								\
+	if (unlikely(__ret_warn_on))					\
+		__WARN();						\
 	unlikely(__ret_warn_on);					\
 })
 #endif

-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 0/5] enhance WARN_ON series, Arjan van de Ven, (Sat Jan 5, 11:07 pm)
[PATCH] Add bug/warn marker to generic report_bug(), Olof Johansson, (Sun Jan 6, 4:22 pm)
Re: [PATCH] Add bug/warn marker to generic report_bug(), Arjan van de Ven, (Sun Jan 6, 5:38 pm)
Re: [PATCH] Add bug/warn marker to generic report_bug(), Olof Johansson, (Sun Jan 6, 9:22 pm)
Re: [PATCH] Add bug/warn marker to generic report_bug(), Arjan van de Ven, (Mon Jan 7, 12:55 am)
Re: [patch 0/5] enhance WARN_ON series, Ingo Molnar, (Sun Jan 6, 5:26 am)
[patch 4/5] bugh-remove-have_arch_bug--have_arch_warn, Arjan van de Ven, (Sat Jan 5, 11:11 pm)
[patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON, Arjan van de Ven, (Sat Jan 5, 11:12 pm)
Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON, Benjamin Herrenschmidt, (Sun Jan 6, 7:16 am)
[patch 2/5] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 11:09 pm)
Re: [patch 2/5] move WARN_ON() out of line, Olof Johansson, (Sun Jan 6, 3:40 pm)
[patch 1/5] Introduce __WARN(), Arjan van de Ven, (Sat Jan 5, 11:08 pm)
Re: [patch 1/5] Introduce __WARN(), Richard Knutsson, (Sun Jan 6, 7:44 am)
Re: [patch 1/5] Introduce __WARN(), Arjan van de Ven, (Sun Jan 6, 11:42 am)
Re: [patch 1/5] Introduce __WARN(), Richard Knutsson, (Sun Jan 6, 12:09 pm)
Re: [patch 1/5] Introduce __WARN(), Arjan van de Ven, (Sun Jan 6, 1:10 pm)
Re: [patch 1/5] Introduce __WARN(), Richard Knutsson, (Sun Jan 6, 1:42 pm)