Home » Mailing list archives » linux-kernel » 2008 » January » 5

Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]

Previous thread: Re: [PATCH 1/5] USB Kconfig: Reorganize USB Kconfig Menu by Al Boldi on Saturday, January 5, 2008 - 11:37 am. (1 message)

Next thread: Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support by Al Boldi on Saturday, January 5, 2008 - 11:41 am. (37 messages)
[view original message]
From: Al Boldi <a1426z@...>
To: <linux-usb@...>
Cc: <linux-kernel@...>, David Brownell <david-b@...>, Greg KH <greg@...>, Andrew Morton <akpm@...>
Subject: Re: [PATCH 4/5] USB Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm
Date: Saturday, January 5, 2008 - 11:42 am

From: David Brownell <david-b@pacbell.net>


Source "drivers/usb/gadget/Kconfig" for ARCH=arm.


Cc: David Brownell <david-b@pacbell.net>

Cc: Greg KH <greg@kroah.com>

Cc: Andrew Morton <akpm@linux-foundation.org>

Signed-off-by: Al Boldi <a1426z@gawab.com>


---


--- 23.a/arch/arm/Kconfig

+++ 23.b/arch/arm/Kconfig

@@ -1049,6 +1049,8 @@ source "drivers/hid/Kconfig"


 source "drivers/usb/Kconfig"


+source "drivers/usb/gadget/Kconfig"

+

 source "drivers/mmc/Kconfig"


 source "drivers/rtc/Kconfig"


--
[view original message]
From: David Brownell <david-b@...>
To: Al Boldi <a1426z@...>
Cc: <linux-usb@...>, <linux-kernel@...>, Greg KH <greg@...>, Andrew Morton <akpm@...>
Subject: Re: [PATCH 4/5] USB Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm
Date: Saturday, January 5, 2008 - 2:46 pm

Better IMO to include such updates with the patch that reorganizes

that part of the menu ... it's conceptually a single change, and

fragmenting it will cause bisection problems.


In fact, moving the gadget Kconfig in a separate step would make

your main changes more clear too.


--
[view original message]
From: Sam Ravnborg <sam@...>
To: Al Boldi <a1426z@...>, Russell King <rmk@...>, <linux-arm-kernel@...>
Cc: <linux-usb@...>, <linux-kernel@...>, David Brownell <david-b@...>, Greg KH <greg@...>, Andrew Morton <akpm@...>
Subject: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]
Date: Saturday, January 5, 2008 - 3:20 pm

What is preventing ARM from using drivers/Kconfig?

That a better fix IMO.


	Sam

--
[view original message]
From: Russell King <rmk+lkml@...>
To: Sam Ravnborg <sam@...>
Cc: Al Boldi <a1426z@...>, <linux-arm-kernel@...>, <linux-usb@...>, <linux-kernel@...>, David Brownell <david-b@...>, Greg KH <greg@...>, Andrew Morton <akpm@...>
Subject: Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]
Date: Saturday, January 5, 2008 - 4:31 pm

Not everything in drivers/ is suitable for every ARM configuration.  It

was felt at the time better for ARM to remain separate because people

didn't want to pollute drivers/Kconfig with the ARM specific conditionals.


(mtd is conditional because it's not supported on ARM CPUs without

alignment trap support.)


--

Russell King

 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/

 maintainer of:

--
[view original message]
From: Arnd Bergmann <arnd@...>
To: Russell King <rmk+lkml@...>
Cc: Sam Ravnborg <sam@...>, Al Boldi <a1426z@...>, <linux-arm-kernel@...>, <linux-usb@...>, <linux-kernel@...>, David Brownell <david-b@...>, Greg KH <greg@...>, Andrew Morton <akpm@...>
Subject: Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]
Date: Saturday, January 5, 2008 - 6:09 pm

We made drivers/Kconfig work for s390 in the meantime, which is far more

special than arm in this regard, so I think you should try to give it

another go.


What are the main obstacles on arm that prevent you from building these

drivers?


	Arnd <><

--
[view original message]
From: Sam Ravnborg <sam@...>
To: Russell King <rmk+lkml@...>
Cc: Al Boldi <a1426z@...>, <linux-arm-kernel@...>, <linux-usb@...>, <linux-kernel@...>, David Brownell <david-b@...>, Greg KH <greg@...>, Andrew Morton <akpm@...>
Subject: Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]
Date: Saturday, January 5, 2008 - 4:54 pm

Today we would have used HAVE_ for the problematic parts and thus

it would have been easy to not select what ARM does not support.

But unfortunately thats not how it got designed.


It would be nice to revist one day to see how much is actually needed

to cleanly supprt ARM in drivers/Kconfig.


	Sam

--
[view original message]
From: Russell King <rmk+lkml@...>
To: Sam Ravnborg <sam@...>
Cc: Al Boldi <a1426z@...>, <linux-arm-kernel@...>, <linux-usb@...>, <linux-kernel@...>, David Brownell <david-b@...>, Greg KH <greg@...>, Andrew Morton <akpm@...>
Subject: Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]
Date: Saturday, January 5, 2008 - 5:09 pm

You could diff the two Kconfig files - I try to keep them so they list

the same Kconfigs in the same order to keep the diff size down.


--

Russell King

 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/

 maintainer of:

--
Previous thread: Re: [PATCH 1/5] USB Kconfig: Reorganize USB Kconfig Menu by Al Boldi on Saturday, January 5, 2008 - 11:37 am. (1 message)

Next thread: Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support by Al Boldi on Saturday, January 5, 2008 - 11:41 am. (37 messages)