Re: [patch 1/3] move WARN_ON() out of line

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Ingo Molnar <mingo@...>

Cc: Arjan van de Ven <arjan@...>, <linux-kernel@...>, Andrew Morton <akpm@...>

Subject: Re: [patch 1/3] move WARN_ON() out of line

Date: Saturday, January 5, 2008 - 2:42 am

Ingo Molnar wrote:
quoted text> * Arjan van de Ven <arjan@linux.intel.com> wrote:
>
>   
>> +#define WARN_ON(condition) do_warn_on((unsigned long)(condition), __FILE__, \
>> +					 __LINE__, __FUNCTION__)
>>     
>
> hm. This passes in 4 arguments to do_warn_on().
>
> i think we could get away with no arguments (!), by using section 
> tricks. Firstly, we can get rid of __FUNCTION__ and replace it with a 
> ksyms lookup - that is fine enough. Secondly, we could put __FILE__ and 
> __LINE__ into a text section and key it up to the return address from 
> do_warn_on().
>   

BUG_ON already does this, and WARN_ON can reuse all the same machinery.

    J
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Wed Jan 2, 8:56 pm)

Re: [patch 1/3] move WARN_ON() out of line, Jeremy Fitzhardinge, (Sat Jan 5, 2:41 am)

Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 2:01 pm)

Re: [patch 1/3] move WARN_ON() out of line, Jeremy Fitzhardinge, (Sat Jan 5, 2:45 pm)

Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 4:02 pm)

Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 2:08 pm)

Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 2:37 pm)

Re: [patch 1/3] move WARN_ON() out of line, Dmitri Vorobiev, (Sat Jan 5, 1:09 am)

Re: [patch 1/3] move WARN_ON() out of line, Pekka Enberg, (Thu Jan 3, 7:20 am)

Re: [patch 1/3] move WARN_ON() out of line, Ingo Molnar, (Thu Jan 3, 5:25 am)

Re: [patch 1/3] move WARN_ON() out of line, Jeremy Fitzhardinge, (Sat Jan 5, 2:42 am)

Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Thu Jan 3, 12:22 pm)

Re: [patch 1/3] move WARN_ON() out of line, Olof Johansson, (Thu Jan 3, 12:58 am)

Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Thu Jan 3, 5:03 pm)

Re: [patch 1/3] move WARN_ON() out of line, Matt Mackall, (Wed Jan 2, 9:59 pm)

Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Thu Jan 3, 5:06 pm)

Re: [patch 1/3] move WARN_ON() out of line, Herbert Xu, (Fri Jan 4, 10:35 pm)

Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 2:33 pm)


linux-kernel:
Theodore Tso	Re: -mm merge plans for 2.6.23 -- sys_fallocate
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Christoph Hellwig	Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linux interface for on access scan...
Andi Kleen	[PATCH] [0/45] x86 2.6.24 patches review I
git:

openbsd-misc:

linux-netdev:

Wenji Wu	RE: A Linux TCP SACK Question
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	Re: [GIT]: Networking

Re: [patch 1/3] move WARN_ON() out of line

Online users