login
Login / Register
Header Space

 
 

Home » Mailing list archives » linux-kernel » 2008 » January » 4

Re: [PATCH x86] [12/16] Optimize lock prefix switching to run less frequently

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <ak@...>
To: Thomas Gleixner <tglx@...>
Cc: LKML <linux-kernel@...>, Ingo Molnar <mingo@...>
Subject: Re: [PATCH x86] [12/16] Optimize lock prefix switching to run less frequently
Date: Friday, January 4, 2008 - 10:39 am

> The kernel process request that _all_ contributors run their patches 

That's new. When and by whom was that rule been introduced? And with what
rationale?

Even checkpatch.pl itself says to only fix the warnings that make sense.
This one didn't. And it has so many false positives in my experiences
that a lot of its warnings are useless.

So even if you require checkpatch.pl compliance it will be always
subjective because checkpatch.pl is not always correct.

Anyways if you care so much about space<->tabs why don't you just write
a filter that converts spaces to tabs for incoming patches? Like it is
traditionally done for trailing white spaces? Would be a trivial perl script.

Bothering humans with such a silly mindless thing is beyond ridiculous.

 
I wish you guys would care more about actually broken logic in patches than just 
checkpatch.pl output. When I occasionally check git-x86 I always tend to find some 
obviously broken patch that should have been caught during review before
merge.

-Andi
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH x86] [0/16] Various i386/x86-64 changes, Andi Kleen, (Thu Jan 3, 11:42 am)
[PATCH x86] [16/16] Mark memory_setup __init, Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [16/16] Mark memory_setup __init, Ingo Molnar, (Fri Jan 4, 5:25 am)
Re: [PATCH x86] [16/16] Mark memory_setup __init, Ingo Molnar, (Fri Jan 4, 5:53 am)
[PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Rafael J. Wysocki, (Thu Jan 3, 1:22 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Andi Kleen, (Thu Jan 3, 1:42 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Rafael J. Wysocki, (Thu Jan 3, 5:41 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Ingo Molnar, (Fri Jan 4, 5:23 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Rafael J. Wysocki, (Thu Jan 10, 1:14 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Thu Jan 3, 2:14 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Andi Kleen, (Thu Jan 3, 2:43 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Thu Jan 10, 5:54 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Andi Kleen, (Thu Jan 10, 5:58 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Thu Jan 10, 6:19 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Andi Kleen, (Thu Jan 10, 7:15 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Thu Jan 10, 7:26 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Andi Kleen, (Thu Jan 10, 7:42 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Rafael J. Wysocki, (Thu Jan 10, 1:17 pm)
[PATCH] x86: Change unnecessary dependencies on CONFIG_PM, Rafael J. Wysocki, (Fri Jan 11, 7:06 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Thu Jan 10, 8:47 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Andi Kleen, (Thu Jan 10, 9:12 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Thu Jan 10, 11:09 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Ingo Molnar, (Mon Jan 14, 9:52 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Mon Jan 14, 11:25 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Sam Ravnborg, (Mon Jan 14, 10:09 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Ingo Molnar, (Mon Jan 14, 10:58 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Mon Jan 14, 2:17 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Ingo Molnar, (Mon Jan 14, 11:05 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Ingo Molnar, (Mon Jan 14, 11:24 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Sam Ravnborg, (Mon Jan 14, 4:12 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Ingo Molnar, (Tue Jan 15, 11:17 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Sam Ravnborg, (Tue Jan 15, 12:25 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Andi Kleen, (Tue Jan 15, 1:11 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Sam Ravnborg, (Tue Jan 15, 2:21 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Tue Jan 15, 2:47 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Andi Kleen, (Tue Jan 15, 2:29 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Sam Ravnborg, (Tue Jan 15, 2:31 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Tue Jan 15, 1:27 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Ingo Molnar, (Mon Jan 14, 11:01 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Sam Ravnborg, (Mon Jan 14, 3:59 pm)
[patch for v2.6.24] fix section mismatch warning in page_all..., Ingo Molnar, (Tue Jan 15, 6:12 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Mon Jan 14, 2:20 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Ingo Molnar, (Mon Jan 14, 3:10 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Mon Jan 14, 3:52 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Sam Ravnborg, (Mon Jan 14, 4:01 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Mon Jan 14, 4:18 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Ingo Molnar, (Tue Jan 15, 6:14 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Tue Jan 15, 6:51 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Sam Ravnborg, (Mon Jan 14, 4:27 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Adrian Bunk, (Mon Jan 14, 4:34 pm)
[PATCH x86] [14/16] Enable RDC321X subarch only on 32bit, Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [14/16] Enable RDC321X subarch only on 32bit, Ingo Molnar, (Fri Jan 4, 5:22 am)
[PATCH x86] [13/16] i386: Set CFQ as default in i386 defconfig, Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [13/16] i386: Set CFQ as default in i386 def..., Ingo Molnar, (Fri Jan 4, 5:19 am)
[PATCH x86] [12/16] Optimize lock prefix switching to run le..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Thomas Gleixner, (Fri Jan 4, 5:42 am)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Andi Kleen, (Fri Jan 4, 8:17 am)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Thomas Gleixner, (Fri Jan 4, 10:19 am)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Andi Kleen, (Fri Jan 4, 10:39 am)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Thomas Gleixner, (Fri Jan 4, 4:34 pm)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Andi Kleen, (Fri Jan 4, 6:11 pm)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Ingo Molnar, (Fri Jan 4, 9:19 pm)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Andi Kleen, (Sat Jan 5, 10:37 am)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Pekka Enberg, (Fri Jan 4, 11:02 am)
Re: [PATCH x86] [12/16] Optimize lock prefix switching to ru..., Andi Kleen, (Fri Jan 4, 11:04 am)
[PATCH x86] [11/16] Compile apm and voyager module only when..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [11/16] Compile apm and voyager module only ..., Stephen Rothwell, (Fri Jan 4, 12:15 am)
[PATCH x86] [10/16] Document fdimage/isoimage completely in ..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [10/16] Document fdimage/isoimage completely..., Sam Ravnborg, (Fri Jan 4, 5:00 am)
Re: [PATCH x86] [10/16] Document fdimage/isoimage completely..., Ingo Molnar, (Fri Jan 4, 5:15 am)
[PATCH x86] [9/16] Remove CPU capabitilites printks on i386, Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [9/16] Remove CPU capabitilites printks on i..., Ingo Molnar, (Fri Jan 4, 5:11 am)
[PATCH x86] [8/16] Make lockdep_init __init, Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [8/16] Make lockdep_init __init, Ingo Molnar, (Fri Jan 4, 5:06 am)
[PATCH x86] [7/16] Convert lockdep to use arch_early_alloc()..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [7/16] Convert lockdep to use arch_early_all..., Ingo Molnar, (Fri Jan 4, 5:03 am)
[PATCH x86] [6/16] Add a new arch_early_alloc() interface fo..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [6/16] Add a new arch_early_alloc() interfac..., Eric Dumazet, (Thu Jan 3, 12:22 pm)
Re: [PATCH x86] [6/16] Add a new arch_early_alloc() interfac..., Andi Kleen, (Thu Jan 3, 1:17 pm)
[PATCH x86] [5/16] Replace hard coded reservations in x86-64..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Cyrill Gorcunov, (Fri Jan 4, 8:41 am)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Ingo Molnar, (Fri Jan 4, 5:00 am)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Andi Kleen, (Fri Jan 4, 8:38 am)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Ingo Molnar, (Fri Jan 4, 10:41 am)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Andi Kleen, (Fri Jan 4, 11:03 am)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Sam Ravnborg, (Fri Jan 4, 1:51 pm)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Andi Kleen, (Fri Jan 4, 2:06 pm)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Sam Ravnborg, (Fri Jan 4, 4:56 pm)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Joe Perches, (Fri Jan 4, 2:47 pm)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Andi Kleen, (Fri Jan 4, 6:13 pm)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., J. Bruce Fields, (Fri Jan 4, 6:46 pm)
Re: [PATCH x86] [5/16] Replace hard coded reservations in x8..., Andi Kleen, (Fri Jan 4, 8:23 am)
[PATCH x86] [4/16] Add /proc/irq/*/spurious to dump the spur..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [4/16] Add /proc/irq/*/spurious to dump the ..., Ingo Molnar, (Fri Jan 4, 4:58 am)
Re: [PATCH x86] [4/16] Add /proc/irq/*/spurious to dump the ..., Andi Kleen, (Fri Jan 4, 8:22 am)
[PATCH x86] [3/16] Turn irq debugging options into module pa..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [3/16] Turn irq debugging options into modul..., Ingo Molnar, (Fri Jan 4, 4:55 am)
[PATCH x86] [2/16] Add a counter for per cpu clocksource wat..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [2/16] Add a counter for per cpu clocksource..., Ingo Molnar, (Fri Jan 4, 4:53 am)
[PATCH x86] [1/16] Make clocksource watchdog cycle through o..., Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [1/16] Make clocksource watchdog cycle throu..., Ingo Molnar, (Fri Jan 4, 4:51 am)
Re: [PATCH x86] [1/16] Make clocksource watchdog cycle throu..., Andi Kleen, (Fri Jan 4, 8:59 am)

Mail archive search
Enter your search terms.
Optionally limit your search to a specific mailing list.
advanced
Colocation donated by:
Who's online
There are currently 2 users and 1253 guests online.

Online users

Syndicate
Syndicate content
© 2007 KernelTrap.  |  Powered by Drupal.  |  Legal statement.
speck-geostationary