Re: 2.6.24-git4+ regression

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Lukas Hejtmanek <xhejtman@...>
Cc: <mingo@...>, <linux-kernel@...>, Peter Zijlstra <a.p.zijlstra@...>
Date: Thursday, January 31, 2008 - 6:29 am

* Lukas Hejtmanek <xhejtman@ics.muni.cz> wrote:


if you apply the current sched-fixes (rollup patch below), does it get 
any better?

	Ingo

Index: linux/kernel/sched_fair.c
===================================================================
--- linux.orig/kernel/sched_fair.c
+++ linux/kernel/sched_fair.c
@@ -520,7 +520,7 @@ place_entity(struct cfs_rq *cfs_rq, stru
 
 	if (!initial) {
 		/* sleeps upto a single latency don't count. */
-		if (sched_feat(NEW_FAIR_SLEEPERS) && entity_is_task(se))
+		if (sched_feat(NEW_FAIR_SLEEPERS))
 			vruntime -= sysctl_sched_latency;
 
 		/* ensure we never gain time by being placed backwards. */
@@ -1106,7 +1106,11 @@ static void check_preempt_wakeup(struct 
 	}
 
 	gran = sysctl_sched_wakeup_granularity;
-	if (unlikely(se->load.weight != NICE_0_LOAD))
+	/*
+	 * More easily preempt - nice tasks, while not making
+	 * it harder for + nice tasks.
+	 */
+	if (unlikely(se->load.weight > NICE_0_LOAD))
 		gran = calc_delta_fair(gran, &se->load);
 
 	if (pse->vruntime + gran < se->vruntime)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.24-git4+ regression, Lukas Hejtmanek, (Wed Jan 30, 9:56 am)
Re: 2.6.24-git4+ regression, Srivatsa Vaddagiri, (Thu Feb 14, 12:55 pm)
Re: 2.6.24-git4+ regression, Lukas Hejtmanek, (Sun Feb 17, 4:26 pm)
Re: 2.6.24-git4+ regression, Ingo Molnar, (Mon Feb 18, 12:28 am)
Re: 2.6.24-git4+ regression, Mike Galbraith, (Mon Feb 18, 3:38 am)
Re: 2.6.24-git4+ regression, Srivatsa Vaddagiri, (Mon Feb 18, 4:20 am)
Re: 2.6.24-git4+ regression, Mike Galbraith, (Mon Feb 18, 4:36 am)
Re: 2.6.24-git4+ regression, Ingo Molnar, (Thu Jan 31, 6:29 am)
Re: 2.6.24-git4+ regression, Lukas Hejtmanek, (Mon Feb 4, 7:17 am)
Re: 2.6.24-git4+ regression, Ingo Molnar, (Mon Feb 4, 8:01 am)
Re: 2.6.24-git4+ regression, Lukas Hejtmanek, (Mon Feb 4, 8:29 am)
Re: 2.6.24-git4+ regression, Ingo Molnar, (Mon Feb 4, 9:04 am)
Re: 2.6.24-git4+ regression, Lukas Hejtmanek, (Mon Feb 4, 9:49 am)
Re: 2.6.24-git4+ regression, Peter Zijlstra, (Mon Feb 4, 7:36 am)
Re: 2.6.24-git4+ regression, Lukas Hejtmanek, (Mon Feb 4, 10:36 am)
Re: 2.6.24-git4+ regression, Peter Zijlstra, (Mon Feb 4, 10:45 am)
Re: 2.6.24-git4+ regression, Lukas Hejtmanek, (Mon Feb 4, 1:00 pm)
Re: 2.6.24-git4+ regression, Lukas Hejtmanek, (Thu Jan 31, 6:55 am)