Re: [PATCH 2/2] Char: applicom, use pci_match_id

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Jiri Slaby <jirislaby@...>

To: Andrew Morton <akpm@...>

Cc: <linux-kernel@...>, <dwmw2@...>, <xiyou.wangcong@...>

Subject: Re: [PATCH 2/2] Char: applicom, use pci_match_id

Date: Thursday, January 31, 2008 - 5:26 am

On 01/31/2008 12:10 AM, Andrew Morton wrote:
quoted text> On Wed, 30 Jan 2008 12:13:15 +0100
> Jiri Slaby <jirislaby@gmail.com> wrote:
> 
>> +		if (!pci_match_id(applicom_pci_tbl, dev));
>>  			continue;
> 
> 
> The patch was carelessly prepared, was not runtine-tested and was not
> passed through checkpatch, which detects this error.  Please fix these
> things, permanently.

Yes, you're right, I definitely need to change my workflow, this needn't happen.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 5:30 am)

Re: [Patch] Shut up warnings from files under drivers/, Sam Ravnborg, (Sat Jan 26, 5:57 am)

Re: [Patch] Shut up warnings from files under drivers/, Sam Ravnborg, (Sat Jan 26, 6:21 am)

Re: [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 6:26 am)

Re: [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 6:15 am)

Re: [Patch] Shut up warnings from files under drivers/, Jeff Garzik, (Sat Jan 26, 5:55 am)

Re: [Patch] Shut up warnings from files under drivers/, Sam Ravnborg, (Sat Jan 26, 3:17 pm)

(Updated) [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sun Jan 27, 12:15 am)

Re: (Updated) [Patch] Shut up warnings from files under driv..., Sam Ravnborg, (Sun Jan 27, 5:21 am)

(Try#3) [Patch] Shut up warnings from files under drivers/, WANG Cong, (Mon Jan 28, 1:49 am)

[PATCH 2/2] Char: applicom, use pci_match_id, Jiri Slaby, (Wed Jan 30, 7:13 am)

Re: [PATCH 2/2] Char: applicom, use pci_match_id, Andrew Morton, (Wed Jan 30, 7:10 pm)

Re: [PATCH 2/2] Char: applicom, use pci_match_id, Jiri Slaby, (Thu Jan 31, 5:26 am)

[PATCH 1/2] Char: applicom, use pci_resource_start, Jiri Slaby, (Wed Jan 30, 7:13 am)

Re: (Updated) [Patch] Shut up warnings from files under driv..., Jiri Slaby, (Sun Jan 27, 5:08 am)

Re: (Updated) [Patch] Shut up warnings from files under driv..., Jiri Slaby, (Sun Jan 27, 5:21 am)

Re: (Updated) [Patch] Shut up warnings from files under driv..., WANG Cong, (Mon Jan 28, 1:20 am)

Re: [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 10:50 pm)

Re: [Patch] Shut up warnings from files under drivers/, Sam Ravnborg, (Sat Jan 26, 3:30 pm)

Re: [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 6:18 am)

Re: [Patch] Shut up warnings from files under drivers/, Jeff Garzik, (Sat Jan 26, 7:44 am)

Navigation

Popular discussions


linux-kernel:
Vu Pham	Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Andrew Morton	Re: -mm merge plans for 2.6.23 -- sys_fallocate
linux-netdev:
David Miller	[GIT]: Networking
Gerrit Renker	[PATCH 28/37] dccp: Integration of dynamic feature activation - part 3 (client side)
David Miller	Re: htb parallelism on multi-core platforms
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
git:

openbsd-misc:

Colocation donated by: