x86 arch updates also broke s390

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Adrian Bunk
Date: Wednesday, January 30, 2008 - 5:33 pm

<--  snip  -->

...
  CC      arch/s390/kernel/asm-offsets.s
In file included from 
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/s390/kernel/asm-offsets.c:7:
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h: In function 'spin_needbreak':
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h:1931: error: implicit declaration of function '__raw_spin_is_contended'
make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1

<--  snip  -->


Guilty commit:

Commit: 95c354fe9f7d6decc08a92aa26eb233ecc2155bf 
Author: Nick Piggin <npiggin@suse.de> Wed, 30 Jan 2008 13:31:20 +0100 

    spinlock: lockbreak cleanup
    
    The break_lock data structure and code for spinlocks is quite nasty.
    Not only does it double the size of a spinlock but it changes locking to
    a potentially less optimal trylock.
    
    Put all of that under CONFIG_GENERIC_LOCKBREAK, and introduce a
    __raw_spin_is_contended that uses the lock data itself to determine whether
    there are waiters on the lock, to be used if CONFIG_GENERIC_LOCKBREAK is
    not set.
    
    Rename need_lockbreak to spin_needbreak, make it use spin_is_contended to
    decouple it from the spinlock implementation, and make it typesafe (rwlocks
    do not have any need_lockbreak sites -- why do they even get bloated up
    with that break_lock then?).
    
    Signed-off-by: Nick Piggin <npiggin@suse.de>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>




cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] x86 arch updates for v2.6.25, Ingo Molnar, (Tue Jan 29, 6:15 pm)
x86 arch updates also broke s390, Adrian Bunk, (Wed Jan 30, 5:33 pm)
Re: x86 arch updates also broke s390, Martin Schwidefsky, (Thu Jan 31, 2:34 am)
Re: x86 arch updates also broke s390, Ingo Molnar, (Thu Jan 31, 3:24 am)
Re: x86 arch updates also broke s390, Nick Piggin, (Thu Jan 31, 5:37 am)
Re: [git pull] x86 arch updates for v2.6.25, Adrian Bunk, (Thu Jan 31, 8:57 am)
Re: [git pull] x86 arch updates for v2.6.25, Ingo Molnar, (Thu Jan 31, 9:00 am)
Re: [git pull] x86 arch updates for v2.6.25, Ingo Molnar, (Thu Jan 31, 9:04 am)
Re: [git pull] x86 arch updates for v2.6.25, Adrian Bunk, (Thu Jan 31, 9:12 am)
Re: [git pull] x86 arch updates for v2.6.25, Ingo Molnar, (Thu Jan 31, 9:15 am)
Re: [git pull] x86 arch updates for v2.6.25, WANG Cong, (Thu Jan 31, 9:21 am)
Re: [git pull] x86 arch updates for v2.6.25, Adrian Bunk, (Thu Jan 31, 9:24 am)
sparc compile error caused by x86 arch updates, Adrian Bunk, (Thu Jan 31, 9:29 am)
Re: [git pull] x86 arch updates for v2.6.25, Ingo Molnar, (Thu Jan 31, 9:46 am)
Re: sparc compile error caused by x86 arch updates, Jeremy Fitzhardinge, (Thu Jan 31, 9:50 am)
Re: [git pull] x86 arch updates for v2.6.25, Jeremy Fitzhardinge, (Thu Jan 31, 9:52 am)
Re: sparc compile error caused by x86 arch updates, Ingo Molnar, (Thu Jan 31, 10:43 am)
Re: sparc compile error caused by x86 arch updates, Jeremy Fitzhardinge, (Thu Jan 31, 10:55 am)
Re: sparc compile error caused by x86 arch updates, Adrian Bunk, (Thu Jan 31, 11:21 am)
Re: sparc compile error caused by x86 arch updates, Ingo Molnar, (Thu Jan 31, 11:38 am)
Re: x86 arch updates also broke s390, Ingo Molnar, (Fri Feb 1, 2:48 am)
Re: x86 arch updates also broke s390, Ingo Molnar, (Fri Feb 1, 2:52 am)
Re: x86 arch updates also broke s390, Martin Schwidefsky, (Fri Feb 1, 2:54 am)
Re: x86 arch updates also broke s390, Ingo Molnar, (Fri Feb 1, 3:02 am)
Re: [git pull] x86 arch updates for v2.6.25, Maxim Levitsky, (Mon Feb 4, 7:36 pm)
Re: [git pull] x86 arch updates for v2.6.25, Linus Torvalds, (Mon Feb 4, 8:27 pm)
Re: [git pull] x86 arch updates for v2.6.25, Phil Oester, (Mon Feb 4, 9:11 pm)
Re: [git pull] x86 arch updates for v2.6.25, Andrew Morton, (Mon Feb 4, 9:54 pm)
Re: [git pull] x86 arch updates for v2.6.25, John Stoffel, (Tue Feb 5, 10:45 am)
Re: [git pull] x86 arch updates for v2.6.25, H. Peter Anvin, (Tue Feb 5, 10:52 am)
Re: [git pull] x86 arch updates for v2.6.25, Jan Kiszka, (Wed Feb 6, 5:08 am)
Re: [git pull] x86 arch updates for v2.6.25, Daniel Phillips, (Thu Feb 7, 12:20 pm)
Re: [git pull] x86 arch updates for v2.6.25, Daniel Phillips, (Thu Feb 7, 1:00 pm)
Re: [git pull] x86 arch updates for v2.6.25, Christoph Hellwig, (Thu Feb 7, 9:48 pm)
Re: [git pull] x86 arch updates for v2.6.25, Jan Kiszka, (Fri Feb 8, 2:51 am)
Re: [git pull] x86 arch updates for v2.6.25, Andi Kleen, (Fri Feb 8, 10:00 am)
Re: [git pull] x86 arch updates for v2.6.25, Jan Kiszka, (Fri Feb 8, 10:48 am)
Re: [git pull] x86 arch updates for v2.6.25, Bernhard Kaindl, (Fri Feb 8, 11:24 am)
Re: [git pull] x86 arch updates for v2.6.25, Andi Kleen, (Fri Feb 8, 11:57 am)
Re: [RFC][PATCH] KGDB: remove kgdb-own fault handling, Jason Wessel, (Fri Feb 8, 3:16 pm)
Re: [git pull] x86 arch updates for v2.6.25, Amit Shah, (Sat Feb 9, 7:11 am)
Re: [git pull] x86 arch updates for v2.6.25, Jiri Kosina, (Sun Feb 10, 5:30 am)
Re: [git pull] x86 arch updates for v2.6.25, Amit Shah, (Tue Feb 12, 12:16 am)
Re: [git pull] x86 arch updates for v2.6.25, Ingo Molnar, (Wed Feb 13, 1:56 am)
Re: [git pull] x86 arch updates for v2.6.25, Amit Shah, (Wed Feb 13, 3:19 am)