linux-kernel mailing list

FromSubjectsort iconDate
Stefan Richter
[GIT PULL] FireWire updates post 2.6.24
Linus, please pull from the for-linus branch at git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git for-linus to receive the following IEEE 1394/ FireWire subsystem updates. Once again it is almost all about bug fixes. Most notable are David Moore's fixes for isochronous reception which greatly enhance the new firewire stack's usability in the IIDC domain (uncompressed video from industrial cameras and webcams). The storage driver firewire-sbp2 received some attention ...
Jan 30, 6:53 pm 2008
Stefan Richter
Re: [GIT PULL] FireWire updates post 2.6.24
Patches recently added to linux1394-2.6.git/for-linus: Jarod Wilson (3): firewire: replace subtraction with bitwise and firewire: fw-sbp2: increase login orb reply timeout, fix "failed to login" firewire: fw-sbp2: Use sbp2 device-provided mgt orb timeout for logins Stefan Richter (6): firewire: fw-sbp2: skip unnecessary logout firewire: fw-sbp2: try to increase reconnect_hold (speed up reconnection) firewire: fw-sbp2: use device generation, not card generation...
Jan 30, 6:55 pm 2008
Rafael J. Wysocki
[Regression] 2.6.24-git8 (and earlier): Multiple processes s...
Hi, Recently I've been observing problems with unmounting the /home fs on reboot and/or shutdown on two test boxes. After some more investigation I've found that this is due to some KDE processes stuck in D states after their owner has logged out. This happens 100% of the time if there's a suspend/resume cycle before the user logs out (ie. the user logs into KDE, works for some time, suspends the box to RAM and resmes one or more times and then logs out). Still, I also observe the symptoms on...
Jan 30, 6:38 pm 2008
Rafael J. Wysocki
Re: [Regression] 2.6.24-git8 (and earlier): Multiple process...
Update. After reverting: commit 37bb6cb4097e29ffee970065b74499cbf10603a3 Author: Peter Zijlstra <a.p.zijlstra@chello.nl> Date:   Fri Jan 25 21:08:32 2008 +0100     hrtimer: unlock hrtimer_wakeup I no longer get processes in the D state, but there still is a problem with artswrapper (this is an openSUSE 10.3 system, x86-64). Namely, after a suspend/resume cycle and logging out/logging in the user, artswrapper gets stuck somewhere, apparently in the running (R) state. For this re...
Jan 30, 7:42 pm 2008
James Bottomley
[GIT PATCH] intermediate SCSI update for 2.6.24
This isn't the final update I promised, most of this is fixing bugs in the previous update which became more evident with wider testing (a nasty set of cases where we have &cmnd->sense_buffer instead of &cmnd->sense_buffer[0] which cause problems now that sense_buffer is a pointer instead and a bug in the setup of immediate request sense commands that lead to some USB devices becoming unusable). However, the two feature updates it has are to convert SCSI to allow it to use bidirectiona...
Jan 30, 5:44 pm 2008
Konrad Rzeszutek
[PATCH] Add iSCSI iBFT support (v0.4.6)
This patch (v0.4.6) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI connection information so that they can automagically mount the iSCSI share/target. Currently the iSCSI information is hard-coded in the initrd. The /sysfs entries are read-only one-name-and-value fields. ...
Jan 30, 5:37 pm 2008
Steven Rostedt
[PATCH 20/23 -v8] trace preempt off critical timings
Add preempt off timings. A lot of kernel core code is taken from the RT patch latency trace that was written by Ingo Molnar. This adds "preemptoff" and "preemptirqsoff" to /debugfs/tracing/available_tracers Now instead of just tracing irqs off, preemption off can be selected to be recorded. When this is selected, it shares the same files as irqs off timings. One can either trace preemption off, irqs off, or one or the other off. By echoing "preemptoff" into /debugfs/tracing/current_tracer, re...
Jan 30, 5:04 pm 2008
Sven Geggus
XFS oops in vanilla 2.6.24
Hi there, I get the following with 2.6.24: Ending clean XFS mount for filesystem: dm-0 BUG: unable to handle kernel paging request at virtual address f2134000 printing eip: c021a13a *pde = 010b5067 *pte = 32134000 Oops: 0000 [#1] PREEMPT DEBUG_PAGEALLOC Modules linked in: radeon drm rfcomm l2cap sym53c8xx scsi_transport_spi snd_via82xx 8139too snd_mpu401_uart snd_ens1371 snd_rawmidi snd_ac97_codec ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd_page_alloc via_agp agpgart Pid: 3889, co...
Jan 30, 4:23 pm 2008
Steven Rostedt
[PATCH 11/23 -v8] mcount based trace in the form of a header...
This is a simple trace that uses the mcount infrastructure. It is designed to be fast and small, and easy to use. It is useful to record things that happen over a very short period of time, and not to analyze the system in general. An interface is added to the debugfs /debugfs/tracing/ This patch adds the following files: available_tracers list of available tracers. Currently only "function" is available. current_tracer The trace that is currently active. Empty on s...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 19/23 -v8] Trace irq disabled critical timings
This patch adds latency tracing for critical timings (how long interrupts are disabled for). "irqsoff" is added to /debugfs/tracing/available_tracers Note: tracing_max_latency also holds the max latency for irqsoff (in usecs). (default to large number so one must start latency tracing) tracing_thresh threshold (in usecs) to always print out if irqs off is detected to be longer than stated here. If irq_thresh is non-zero, then max_irq_latency is ignored. Here's...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 06/23 -v8] handle accurate time keeping over long del...
From: John Stultz <johnstul@us.ibm.com> Handle accurate time even if there's a long delay between accumulated clock cycles. Signed-off-by: John Stultz <johnstul@us.ibm.com> Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- arch/powerpc/kernel/time.c | 3 +- arch/x86/kernel/vsyscall_64.c | 5 ++- include/asm-x86/vgtod.h | 2 - include/linux/clocksource.h | 58 ++++++++++++++++++++++++++++++++++++++++-- kernel/time/timekeeping.c | 36 +++++++++...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 22/23 -v8] Add event tracer.
This patch adds a event trace that hooks into various events in the kernel. Although it can be used separately, it is mainly to help other traces (wakeup and preempt off) with seeing various events in the traces without having to enable the heavy mcount hooks. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- lib/tracing/Kconfig | 12 + lib/tracing/Makefile | 1 lib/tracing/trace_events.c | 478 ++++++++++++++++++++++++++++++++++++++++++++ lib/tracing/trace_ir...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 18/23 -v8] mcount tracer for wakeup latency timings.
This patch adds hooks to trace the wake up latency of the highest priority waking task. "wakeup" is added to /debugfs/tracing/available_tracers Also added to /debugfs/tracing tracing_max_latency holds the current max latency for the wakeup wakeup_thresh if set to other than zero, a log will be recorded for every wakeup that takes longer than the number entered in here (usecs for all counters) (deletes previous trace) Examples: (with mcount_enabled = 0...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 23/23 -v8] Critical latency timings histogram
This patch adds hooks into the latency tracer to give us histograms of interrupts off, preemption off and wakeup timings. This code was based off of work done by Yi Yang <yyang@ch.mvista.com> But heavily modified to work with the new tracer, and some clean ups by Steven Rostedt <srostedt@redhat.com> This adds the following to /debugfs/tracing latency_hist/ - root dir for historgrams. Under latency_hist there is (depending on what's configured): interrupt_off_latency/...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 02/23 -v8] Add basic support for gcc profiler instrum...
If CONFIG_MCOUNT is selected and /proc/sys/kernel/mcount_enabled is set to a non-zero value the mcount routine will be called everytime we enter a kernel function that is not marked with the "notrace" attribute. The mcount routine will then call a registered function if a function happens to be registered. [This code has been highly hacked by Steven Rostedt, so don't blame Arnaldo for all of this ;-) ] Update: It is now possible to register more than one mcount function. If only one mcou...
Jan 30, 5:03 pm 2008
Steven Rostedt
[PATCH 04/23 -v8] x86_64: notrace annotations
Add "notrace" annotation to x86_64 specific files. Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- arch/x86/kernel/head64.c | 2 +- arch/x86/kernel/setup64.c | 4 ++-- arch/x86/kernel/smpboot_64.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) Index: linux-mcount.git/arch/x86/kernel/head64.c =================================================================== --- linux-mcount.git.ori...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 08/23 -v8] add get_monotonic_cycles
From: John Stultz <johnstul@us.ibm.com> The latency tracer needs a way to get an accurate time without grabbing any locks. Locks themselves might call the latency tracer and cause at best a slow down. This patch adds get_monotonic_cycles that returns cycles from a reliable clock source in a monotonic fashion. Signed-off-by: John Stultz <johnstul@us.ibm.com> Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- include/linux/clocksource.h | 54 +++++++++++++++++++++++++++...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 17/23 -v8] Add marker in try_to_wake_up
Add markers into the wakeup code, to allow the tracer to record wakeup timings. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- kernel/sched.c | 8 ++++++++ 1 file changed, 8 insertions(+) Index: linux-mcount.git/kernel/sched.c =================================================================== --- linux-mcount.git.orig/kernel/sched.c 2008-01-30 15:26:37.000000000 -0500 +++ linux-mcount.git/kernel/sched.c 2008-01-30 15:35:02.000000000 -0500 @@ -1885,6 +1885,10 @@ static int t...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 16/23 -v8] trace generic call to schedule switch
This patch adds hooks into the schedule switch tracing to allow other latency traces to hook into the schedule switches. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- lib/tracing/trace_sched_switch.c | 135 +++++++++++++++++++++++++++++++++------ lib/tracing/tracer.h | 14 ++++ 2 files changed, 131 insertions(+), 18 deletions(-) Index: linux-mcount.git/lib/tracing/tracer.h =================================================================== --- linux-mcount.git.or...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 21/23 -v8] Add markers to various events
This patch adds markers to various events in the kernel. (interrupts, task activation and hrtimers) Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- arch/x86/kernel/apic_32.c | 2 ++ arch/x86/kernel/irq_32.c | 1 + arch/x86/kernel/irq_64.c | 2 ++ arch/x86/kernel/traps_32.c | 2 ++ arch/x86/kernel/traps_64.c | 2 ++ arch/x86/mm/fault_32.c | 3 +++ arch/x86/mm/fault_64.c | 3 +++ kernel/hrtimer.c | 7 +++++++ kernel/sched.c ...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 05/23 -v8] add notrace annotations to vsyscall.
Add the notrace annotations to some of the vsyscall functions. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- arch/x86/kernel/vsyscall_64.c | 3 ++- arch/x86/vdso/vclock_gettime.c | 15 ++++++++------- arch/x86/vdso/vgetcpu.c | 3 ++- include/asm-x86/vsyscall.h | 3 ++- 4 files changed, 14 insertions(+), 10 deletions(-) Index: linux-mcount.git/arch/x86/kernel/vsyscall_64.c =================================================================== --- linux-mcoun...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 09/23 -v8] add notrace annotations to timing events
This patch adds notrace annotations to timer functions that will be used by tracing. This helps speed things up and also keeps the ugliness of printing these functions down. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- arch/x86/kernel/apic_32.c | 2 +- arch/x86/kernel/hpet.c | 2 +- arch/x86/kernel/time_32.c | 2 +- arch/x86/kernel/tsc_32.c | 2 +- arch/x86/kernel/tsc_64.c | 4 ++-- arch/x86/lib/delay_32.c | 6 +++--- drivers/cl...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 00/23 -v8] mcount and latency tracing utility -v8
[ version 8 of mcount / trace patches: changes include: Added read_barrier_depends to mcount and sched function loops incase anyone is crazy enough to port this to alpha. (Suggested by Peter Ziljstra) Added smp_rmb for the wakeup_sched_switch to match the smp_wmb in the wakeup_reset. (Pointed out by Peter Ziljstra) Replaced all the atomic_inc/atomic_read with atomic_inc_returned. (Suggested by Frank Ch. Eigler) Found that the tracer ctrl variable wasn't fu...
Jan 30, 5:03 pm 2008
Steven Rostedt
[PATCH 10/23 -v8] mcount tracer add preempt_enable/disable n...
The tracer may need to call preempt_enable and disable functions for time keeping and such. The trace gets ugly when we see these functions show up for all traces. To make the output cleaner this patch adds preempt_enable_notrace and preempt_disable_notrace to be used by tracer (and debugging) functions. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- include/linux/clocksource.h | 5 +++-- include/linux/preempt.h | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 35 i...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 07/23 -v8] initialize the clock source to jiffies clo...
The latency tracer can call clocksource_read very early in bootup and before the clock source variable has been initialized. This results in a crash at boot up (even before earlyprintk is initialized). Since the clock->read variable points to NULL. This patch simply initializes the clock to use clocksource_jiffies, so that any early user of clocksource_read will not crash. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Acked-by: John Stultz <johnstul@us.ibm.com> --- include...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 14/23 -v8] Add tracing of context switches
This patch adds context switch tracing, of the format of: _------=> CPU# / _-----=> irqs-off | / _----=> need-resched || / _---=> hardirq/softirq ||| / _--=> preempt-depth |||| / ||||| delay cmd pid ||||| time | caller \ / ||||| \ | / swapper-0 1d..3 137us+: ...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 01/23 -v8] printk - dont wakeup klogd with interrupts...
[ This patch is added to the series since the wakeup timings trace may lockup without it. ] I thought that one could place a printk anywhere without worrying. But it seems that it is not wise to place a printk where the runqueue lock is held. I just spent two hours debugging why some of my code was locking up, to find that the lockup was caused by some debugging printk's that I had in the scheduler. The printk's were only in rare paths so they shouldn't be too much of a problem, but after I h...
Jan 30, 5:03 pm 2008
Steven Rostedt
[PATCH 03/23 -v8] Annotate core code that should not be traced
Mark with "notrace" functions in core code that should not be traced. The "notrace" attribute will prevent gcc from adding a call to mcount on the annotated funtions. Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- lib/smp_processor_id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-mcount.git/lib/smp_processor_id.c ===================================================================...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 12/23 -v8] Add context switch marker to sched.c
Add marker into context_switch to record the prev and next tasks. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- kernel/sched.c | 2 ++ 1 file changed, 2 insertions(+) Index: linux-mcount.git/kernel/sched.c =================================================================== --- linux-mcount.git.orig/kernel/sched.c 2008-01-30 14:36:00.000000000 -0500 +++ linux-mcount.git/kernel/sched.c 2008-01-30 15:25:31.000000000 -0500 @@ -2198,6 +2198,8 @@ context_switch(struct rq *rq, stru...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 13/23 -v8] Make the task State char-string visible to...
The tracer wants to be able to convert the state number into a user visible character. This patch pulls that conversion string out the scheduler into the header. This way if it were to ever change, other parts of the kernel will know. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- include/linux/sched.h | 2 ++ kernel/sched.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) Index: linux-mcount.git/include/linux/sched.h ========================================...
Jan 30, 5:04 pm 2008
Steven Rostedt
[PATCH 15/23 -v8] Generic command line storage
Saving the comm of tasks for each trace is very expensive. This patch includes in the context switch hook, a way to store the last 100 command lines of tasks. This table is examined when a trace is to be printed. Note: The comm may be destroyed if other traces are performed. Later (TBD) patches may simply store this information in the trace itself. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- lib/tracing/Kconfig | 1 lib/tracing/trace_function.c | 2 ...
Jan 30, 5:04 pm 2008
marcin.slusarz
[PATCH 00/10] udf: cleanups
Hi This patchset contains various UDF fs cleanups. [PATCH 01/10] udf: udf_CS0toUTF8 cleanup [PATCH 02/10] udf: fix udf_build_ustr [PATCH 03/10] udf: udf_CS0toNLS cleanup [PATCH 04/10] udf: constify crc [PATCH 05/10] udf: simple cleanup of truncate.c [PATCH 06/10] udf: truncate: create function for updating of Allocation Ext Descriptor [PATCH 07/10] udf: replace all adds to little endians variables with le*_add_cpu [PATCH 08/10] udf: simplify __udf_read_inode [PATCH 09/10] udf: replace udf_*_of...
Jan 30, 5:03 pm 2008
marcin.slusarz
[PATCH 10/10] udf: constify udf_bitmap_lookup array
udf_bitmap_lookup never changes, so constify it Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Jan Kara <jack@suse.cz> --- fs/udf/super.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/udf/super.c b/fs/udf/super.c index 3afe764..6bb2a5b 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -1969,7 +1969,7 @@ static int udf_statfs(struct dentry *dentry, struct kstatfs *buf) return 0; } -static unsigned char udf_bitmap_lookup[16] = {...
Jan 30, 5:04 pm 2008
marcin.slusarz
[PATCH 09/10] udf: replace udf_*_offset macros with functions
- translate udf_file_entry_alloc_offset macro into function - translate udf_ext0_offset macro into function - add comment about crypticly named fields in struct udf_inode_info Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Jan Kara <jack@suse.cz> --- fs/udf/udfdecl.h | 29 +++++++++++++++++++---------- include/linux/udf_fs_i.h | 4 ++-- 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h index c6c457b..375b...
Jan 30, 5:03 pm 2008
marcin.slusarz
[PATCH 08/10] udf: simplify __udf_read_inode
- move all brelse(ibh) after main if, because it's called on every path except one where ibh is null - move variables to the most inner blocks Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Jan Kara <jack@suse.cz> --- fs/udf/inode.c | 52 +++++++++++++++++++++++----------------------------- 1 files changed, 23 insertions(+), 29 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 68db2ea..c2d0477 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -1...
Jan 30, 5:03 pm 2008
marcin.slusarz
[PATCH 07/10] udf: replace all adds to little endians variab...
replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); sparse didn't generate any new warning with this patch Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com Cc: Jan Kara <jack@suse.cz> --- fs/udf/balloc.c | 13 ++++--------- fs/udf/ialloc.c | 12 ++++-------- fs/udf/inode.c | 16 ++++------------...
Jan 30, 5:03 pm 2008
marcin.slusarz
[PATCH 06/10] udf: truncate: create function for updating of...
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Jan Kara <jack@suse.cz> --- fs/udf/truncate.c | 56 +++++++++++++++++++++------------------------------- 1 files changed, 23 insertions(+), 33 deletions(-) diff --git a/fs/udf/truncate.c b/fs/udf/truncate.c index f64f827..eb98616 100644 --- a/fs/udf/truncate.c +++ b/fs/udf/truncate.c @@ -180,6 +180,24 @@ void udf_discard_prealloc(struct inode *inode) brelse(epos.bh); } +static void udf_update_alloc_ext_desc(struc...
Jan 30, 5:03 pm 2008
marcin.slusarz
[PATCH 05/10] udf: simple cleanup of truncate.c
- remove one indentation level by little code reorganization - convert "if (smth) BUG();" to "BUG_ON(smth);" Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Jan Kara <jack@suse.cz> --- fs/udf/truncate.c | 76 +++++++++++++++++++++++----------------------------- 1 files changed, 34 insertions(+), 42 deletions(-) diff --git a/fs/udf/truncate.c b/fs/udf/truncate.c index fe61be1..f64f827 100644 --- a/fs/udf/truncate.c +++ b/fs/udf/truncate.c @@ -224,34 +224,29 @@ void ...
Jan 30, 5:03 pm 2008
marcin.slusarz
[PATCH 04/10] udf: constify crc
- constify internal crc table - mark udf_crc "in" parameter as const Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Jan Kara <jack@suse.cz> --- fs/udf/crc.c | 4 ++-- fs/udf/udfdecl.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/udf/crc.c b/fs/udf/crc.c index b166129..f178c63 100644 --- a/fs/udf/crc.c +++ b/fs/udf/crc.c @@ -23,7 +23,7 @@ #include "udfdecl.h" -static uint16_t crc_table[256] = { +static const uint16_t c...
Jan 30, 5:03 pm 2008
marcin.slusarz
[PATCH 03/10] udf: udf_CS0toNLS cleanup
- fix error handling - always zero output variable - don't zero explicitely fields zeroed by memset - mark "in" paramater as const Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Jan Kara <jack@suse.cz> --- fs/udf/unicode.c | 19 ++++++++----------- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c index f4e54e5..d068d33 100644 --- a/fs/udf/unicode.c +++ b/fs/udf/unicode.c @@ -248,35 +248,32 @@ error_out: } s...
Jan 30, 5:03 pm 2008
marcin.slusarz
[PATCH 02/10] udf: fix udf_build_ustr
udf_build_ustr was completely broken when size >= UDF_NAME_LEN - 1 or size < 2 nobody noticed because all callers set size to acceptable values (constants) Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Jan Kara <jack@suse.cz> --- fs/udf/unicode.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c index f969617..f4e54e5 100644 --- a/fs/udf/unicode.c +++ b/fs/udf/unicode.c @@ -47,16 +47,16 ...
Jan 30, 5:03 pm 2008
marcin.slusarz
[PATCH 01/10] udf: udf_CS0toUTF8 cleanup
- fix error handling - always zero output variable - don't zero explicitely fields zeroed by memset - mark "in" paramater as const - remove outdated comment Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Jan Kara <jack@suse.cz> --- fs/udf/udfdecl.h | 2 +- fs/udf/unicode.c | 27 ++++++++++----------------- 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h index 681dc2b..0c525e8 100644 --- a/fs/udf/udfdecl.h ++...
Jan 30, 5:03 pm 2008
Arjan van de Ven
[PATCH] x86: introduce /dev/mem restrictions with a config o...
From: Arjan van de Ven <arjan@linux.intel.com> Subject: [PATCH] x86: introduce /dev/mem restrictions with a config option This patch introduces a restriction on /dev/mem: Only non-memory can be read or written unless the newly introduced config option is set. The X server needs access to /dev/mem for the PCI space, but it doesn't need access to memory; both the file permissions and SELinux permissions of /dev/mem just make X effectively super-super powerful. With the exception of the BIOS a...
Jan 30, 4:48 pm 2008
David Teigland
[GIT PULL] dlm updates for 2.6.25
Linus, Please pull dlm updates for 2.6.25 from: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git for-linus In the past, the dlm patches went through the gfs2 git tree. We've moved to a separate tree because the dlm work is now largely independent from gfs2, and dlm patches are mostly relevant for other applications. There are no new features, only fixes for various bugs or problems. They stem mainly from mixed architecture testing, and new tests that overlap recovery with u...
Jan 30, 4:29 pm 2008
Adrian Bunk
[2.6 patch] make s2io.c:init_tti() static
This patch makes the needlessly global init_tti() static. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- 1e8c2b07be955b181814e4c24366517a66557908 diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 5fab7d7..bc94e84 100644 --- a/drivers/net/s2io.c +++ b/drivers/net/s2io.c @@ -1088,7 +1088,7 @@ static int s2io_print_pci_mode(struct s2io_nic *nic) * '-1' on failure */ -int init_tti(struct s2io_nic *nic, int link) +static int init_tti(struct s2io_nic *nic, int link) { ...
Jan 30, 4:02 pm 2008
Adrian Bunk
[2.6 patch] net/sunqe.c section fix
This patch fixes the following section mismatch: <-- snip --> ... WARNING: drivers/net/sunqe.o(.devinit.text+0x4): Section mismatch in reference from the function qec_sbus_probe() to the function .init.text:qec_ether_init() ... <-- snip --> Signed-off-by: Adrian Bunk <bunk@kernel.org> --- drivers/net/sunqe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) bee65cb0dd698bbda02b1087bffed51e3a2488cb diff --git a/drivers/net/sunqe.c b/drivers/net/su...
Jan 30, 4:03 pm 2008
Adrian Bunk
[2.6 patch] scsi/qlogicpti.c section fixes
This patch fixes the following section mismatches: <-- snip --> ... WARNING: drivers/scsi/qlogicpti.o(.devexit.text+0x8): Section mismatch in reference from the function qpti_sbus_remove() to the function .init.text:qpti_chain_del() WARNING: drivers/scsi/qlogicpti.o(.devinit.text+0x56c): Section mismatch in reference from the function qpti_sbus_probe() to the function .init.text:qpti_map_regs() WARNING: drivers/scsi/qlogicpti.o(.devinit.text+0x580): Section mismatch in reference from the fu...
Jan 30, 4:03 pm 2008
James Bottomley
Re: [2.6 patch] scsi/qlogicpti.c section fixes
OK, look, this is really getting out of hand. __init is possibly justifiable with a few hundred k savings on boot. __devinit and the rest are surely killable on the grounds they provide little benefit for all the pain they cause. all __exit seems to do is set us up for unreferenced pointers in discarded sections, so could we kill that too? James --
Jan 30, 5:00 pm 2008
Adrian Bunk
Re: [2.6 patch] scsi/qlogicpti.c section fixes
When you are on x86 what you see as "Freeing unused kernel memory: " cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
Jan 30, 6:28 pm 2008
Sam Ravnborg
Re: [2.6 patch] scsi/qlogicpti.c section fixes
We now at last have some infrastructure that does proper consistency check of the use of annotation. So it is by no means getting out-of-hands.. To my understanding Adrian just fixed a potential oops. You have a driver that surely are thought to be hotplugable - otherwise qpti_sbus_probe() would not have been annotated __devinit. And had it ever been hotplugged then you had called a function in Again - savings when we build-in the drivers. And without the checks we see 'funny' linker errors on the...
Jan 30, 5:20 pm 2008
previous daytodaynext day
January 29, 2008January 30, 2008January 31, 2008