Home » Mailing list archives » linux-kernel » 2008 » January » 30

Re: [PATCH 2/2] Char: applicom, use pci_match_id

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton <akpm@...>
To: Jiri Slaby <jirislaby@...>
Cc: <linux-kernel@...>, <dwmw2@...>, <jirislaby@...>, <xiyou.wangcong@...>
Subject: Re: [PATCH 2/2] Char: applicom, use pci_match_id
Date: Wednesday, January 30, 2008 - 7:10 pm

On Wed, 30 Jan 2008 12:13:15 +0100
Jiri Slaby <jirislaby@gmail.com> wrote:



The patch was carelessly prepared, was not runtine-tested and was not
passed through checkpatch, which detects this error.  Please fix these
things, permanently.

It's hard to overemphasise how out-of-balance the economics are here.  You
saved maybe thirty person-seconds by skipping the review and checkpatch
steps.  But the cost (if this bug had gone into mainline) would be many
many thousands times higher than this.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 5:30 am)
Re: [Patch] Shut up warnings from files under drivers/, Sam Ravnborg, (Sat Jan 26, 5:57 am)
Re: [Patch] Shut up warnings from files under drivers/, Sam Ravnborg, (Sat Jan 26, 6:21 am)
Re: [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 6:26 am)
Re: [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 6:15 am)
Re: [Patch] Shut up warnings from files under drivers/, Jeff Garzik, (Sat Jan 26, 5:55 am)
Re: [Patch] Shut up warnings from files under drivers/, Sam Ravnborg, (Sat Jan 26, 3:17 pm)
(Updated) [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sun Jan 27, 12:15 am)
Re: (Updated) [Patch] Shut up warnings from files under driv..., Sam Ravnborg, (Sun Jan 27, 5:21 am)
(Try#3) [Patch] Shut up warnings from files under drivers/, WANG Cong, (Mon Jan 28, 1:49 am)
[PATCH 2/2] Char: applicom, use pci_match_id, Jiri Slaby, (Wed Jan 30, 7:13 am)
Re: [PATCH 2/2] Char: applicom, use pci_match_id, Andrew Morton, (Wed Jan 30, 7:10 pm)
Re: [PATCH 2/2] Char: applicom, use pci_match_id, Jiri Slaby, (Thu Jan 31, 5:26 am)
[PATCH 1/2] Char: applicom, use pci_resource_start, Jiri Slaby, (Wed Jan 30, 7:13 am)
Re: (Updated) [Patch] Shut up warnings from files under driv..., Jiri Slaby, (Sun Jan 27, 5:08 am)
Re: (Updated) [Patch] Shut up warnings from files under driv..., Jiri Slaby, (Sun Jan 27, 5:21 am)
Re: (Updated) [Patch] Shut up warnings from files under driv..., WANG Cong, (Mon Jan 28, 1:20 am)
Re: [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 10:50 pm)
Re: [Patch] Shut up warnings from files under drivers/, Sam Ravnborg, (Sat Jan 26, 3:30 pm)
Re: [Patch] Shut up warnings from files under drivers/, WANG Cong, (Sat Jan 26, 6:18 am)
Re: [Patch] Shut up warnings from files under drivers/, Jeff Garzik, (Sat Jan 26, 7:44 am)