To: Andrea Arcangeli <andrea@...>, Christoph Lameter <clameter@...>
Cc: Christoph Lameter <clameter@...>, Robin Holt <holt@...>, Avi Kivity <avi@...>, Izik Eidus <izike@...>, Nick Piggin <npiggin@...>, <kvm-devel@...>, Benjamin Herrenschmidt <benh@...>, Peter Zijlstra <a.p.zijlstra@...>, <steiner@...>, <linux-kernel@...>, <linux-mm@...>, <daniel.blueman@...>, Hugh Dickins <hugh@...>
> Robin, if you don't mind, could you please post or upload somewhere
Dean is still actively working on updating the xpmem patch posted
here a few months ago reworked for the mmu_notifiers. I am sure
we can give you a early look, but it is in a really rough state.
http://marc.info/?l=linux-mm&w=2&r=1&s=xpmem&q=t
The need to sleep comes from the fact that these PFNs are sent to other
hosts on the same NUMA fabric which have direct access to the pages
and then placed into remote process's page tables and then filled into
their TLBs. Our only means of communicating the recall is async.
I think I need to straighten this discussion out in my head a little bit.
Am I correct in assuming Andrea's original patch set did not have any SMP
race conditions for KVM? If so, then we need to start looking at how to
implement Christoph's and my changes in a safe fashion. Andrea, I agree
complete that our introduction of the range callouts have introduced
SMP races.
The three issues we need to simultaneously solve is revoking the remote
page table/tlb information while still in a sleepable context and not
having the remote faulters become out of sync with the granting process.
Currently, I don't see a way to do that cleanly with a single callout.
Could we consider doing a range-based recall and lock callout before
clearing the processes page tables/TLBs, then use the _page or _range
callouts from Andrea's patch to clear the mappings, finally make a
range-based unlock callout. The mmu_notifier user would usually use ops
for either the recall+lock/unlock family of callouts or the _page/_range
family of callouts.
Thanks,
Robin
--
