Home » Mailing list archives » linux-kernel » 2008 » January » 3

Re: [patch 1/3] move WARN_ON() out of line

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Molnar <mingo@...>
To: Arjan van de Ven <arjan@...>
Cc: <linux-kernel@...>, Andrew Morton <akpm@...>
Subject: Re: [patch 1/3] move WARN_ON() out of line
Date: Thursday, January 3, 2008 - 5:25 am

* Arjan van de Ven <arjan@linux.intel.com> wrote:


hm. This passes in 4 arguments to do_warn_on().

i think we could get away with no arguments (!), by using section 
tricks. Firstly, we can get rid of __FUNCTION__ and replace it with a 
ksyms lookup - that is fine enough. Secondly, we could put __FILE__ and 
__LINE__ into a text section and key it up to the return address from 
do_warn_on().

the condition code should not be passed in at all i think - it creates 
extra function calls to do_warn_on() all the time.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Wed Jan 2, 8:56 pm)
Re: [patch 1/3] move WARN_ON() out of line, Jeremy Fitzhardinge, (Sat Jan 5, 2:41 am)
Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 2:01 pm)
Re: [patch 1/3] move WARN_ON() out of line, Jeremy Fitzhardinge, (Sat Jan 5, 2:45 pm)
Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 4:02 pm)
Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 2:08 pm)
Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 2:37 pm)
Re: [patch 1/3] move WARN_ON() out of line, Dmitri Vorobiev, (Sat Jan 5, 1:09 am)
Re: [patch 1/3] move WARN_ON() out of line, Pekka Enberg, (Thu Jan 3, 7:20 am)
Re: [patch 1/3] move WARN_ON() out of line, Ingo Molnar, (Thu Jan 3, 5:25 am)
Re: [patch 1/3] move WARN_ON() out of line, Jeremy Fitzhardinge, (Sat Jan 5, 2:42 am)
Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Thu Jan 3, 12:22 pm)
Re: [patch 1/3] move WARN_ON() out of line, Olof Johansson, (Thu Jan 3, 12:58 am)
Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Thu Jan 3, 5:03 pm)
Re: [patch 1/3] move WARN_ON() out of line, Matt Mackall, (Wed Jan 2, 9:59 pm)
Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Thu Jan 3, 5:06 pm)
Re: [patch 1/3] move WARN_ON() out of line, Herbert Xu, (Fri Jan 4, 10:35 pm)
Re: [patch 1/3] move WARN_ON() out of line, Arjan van de Ven, (Sat Jan 5, 2:33 pm)