Re: freeze vs freezer

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Nigel Cunningham
Date: Thursday, January 3, 2008 - 2:19 am

Hi.

Rafael J. Wysocki wrote:

Sorry. I wasn't very unambiguous, was I? And I'm not sure now whether
you're meaning "How does fuse support relate to freezing block devices?"
or "What's this about fuse support?". Let me therefore seek to answer
both questions:

Higher level, I know (filesystems rather than block devices), but I was
meaning the general concept of blocking new requests and completing
existing ones worked fine for the supposedly impossible fuse support.

Re fuse support, let me start by saying "I know this doesn't handle all
situations, but I think it's a good enough proof-of-concept implementation".

I added some simple hooks to the code for submitting new work to fuse
threads.

#define FUSE_MIGHT_FREEZE(superblock, desc) \
do { \
       int printed = 0; \
       while(superblock->s_frozen != SB_UNFROZEN) { \
               if (!printed) { \
                       printk("%d frozen in " desc ".\n", current->pid); \
                       printed = 1; \
               } \
               try_to_freeze(); \
               yield(); \
       } \
} while (0)

On top of this, I made a (too simple at the moment) freeze_filesystems
function which iterates through &super_blocks in reverse order, freezing
fuse filesystems or ordinary ones. I say 'too simple' because it doesn't
currently allow for the possibility of someone mounting (say) ext3 on
fuse, but that would just be an extension of what's already done.

The end result is:

int freeze_processes(void)
{
        int error;

        printk(KERN_INFO "Stopping fuse filesystems.\n");
        freeze_filesystems(FS_FREEZER_FUSE);
        freezer_state = FREEZER_FILESYSTEMS_FROZEN;
        printk(KERN_INFO "Freezing user space processes ... ");
        error = try_to_freeze_tasks(FREEZER_USER_SPACE);
        if (error)
                goto Exit;
        printk(KERN_INFO "done.\n");

        sys_sync();
        printk(KERN_INFO "Stopping normal filesystems.\n");
        freeze_filesystems(FS_FREEZER_NORMAL);
        freezer_state = FREEZER_USERSPACE_FROZEN;
        printk(KERN_INFO "Freezing remaining freezable tasks ... ");
        error = try_to_freeze_tasks(FREEZER_KERNEL_THREADS);
        if (error)
                goto Exit;
        printk(KERN_INFO "done.");
        freezer_state = FREEZER_FULLY_ON;
 Exit:
        BUG_ON(in_atomic());
        printk("\n");
        return error;
}

Sorry if that's more info than you wanted.

Nigel
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
freeze vs freezer, Jeremy Fitzhardinge, (Wed Nov 21, 8:54 pm)
Re: freeze vs freezer, Rafael J. Wysocki, (Fri Nov 23, 4:47 pm)
Re: freeze vs freezer, Jeremy Fitzhardinge, (Mon Nov 26, 11:44 am)
Re: freeze vs freezer, David Chinner, (Mon Nov 26, 2:17 pm)
Re: freeze vs freezer, Rafael J. Wysocki, (Mon Nov 26, 2:20 pm)
Re: freeze vs freezer, Rafael J. Wysocki, (Mon Nov 26, 2:53 pm)
Re: freeze vs freezer, Matthew Garrett, (Mon Nov 26, 10:38 pm)
Re: freeze vs freezer, Rafael J. Wysocki, (Tue Nov 27, 10:40 am)
Re: freeze vs freezer, Kyle Moffett, (Tue Nov 27, 1:33 pm)
Re: freeze vs freezer, Rafael J. Wysocki, (Tue Nov 27, 4:01 pm)
Re: freeze vs freezer, Kyle Moffett, (Tue Nov 27, 4:14 pm)
Re: freeze vs freezer, Jeremy Fitzhardinge, (Tue Nov 27, 4:32 pm)
Re: freeze vs freezer, Pavel Machek, (Wed Jan 2, 9:02 am)
Re: freeze vs freezer, Nigel Cunningham, (Wed Jan 2, 2:30 pm)
Re: freeze vs freezer, Rafael J. Wysocki, (Wed Jan 2, 3:04 pm)
Re: freeze vs freezer, Nigel Cunningham, (Thu Jan 3, 2:19 am)
Re: freeze vs freezer, Oliver Neukum, (Thu Jan 3, 2:47 am)
Re: freeze vs freezer, Nigel Cunningham, (Thu Jan 3, 2:52 am)
Re: freeze vs freezer, Oliver Neukum, (Thu Jan 3, 4:15 am)
Re: freeze vs freezer, Rafael J. Wysocki, (Thu Jan 3, 3:31 pm)
Re: freeze vs freezer, Oliver Neukum, (Fri Jan 4, 1:54 pm)
Re: freeze vs freezer, Kyle Moffett, (Fri Jan 4, 6:38 pm)
Re: freeze vs freezer, Pavel Machek, (Sat Jan 5, 2:18 pm)
Re: freeze vs freezer, Nigel Cunningham, (Sat Jan 5, 4:01 pm)
Re: freeze vs freezer, Pavel Machek, (Mon Jun 23, 12:16 am)
Re: freeze vs freezer, Henrique de Moraes H ..., (Mon Jun 23, 7:00 am)
Re: freeze vs freezer, Elias Oltmanns, (Tue Jun 24, 1:08 am)
Re: freeze vs freezer, Pavel Machek, (Thu Jun 26, 8:09 am)
Re: [xfs-masters] Re: freeze vs freezer, Dave Chinner, (Sun Jun 29, 3:12 pm)
Re: [xfs-masters] Re: freeze vs freezer, Rafael J. Wysocki, (Sun Jun 29, 4:22 pm)
Re: [xfs-masters] Re: freeze vs freezer, Christoph Hellwig, (Sun Jun 29, 11:11 pm)
Re: [xfs-masters] Re: freeze vs freezer, Dave Chinner, (Sun Jun 29, 11:29 pm)
Re: [xfs-masters] Re: freeze vs freezer, Jeremy Fitzhardinge, (Sun Jun 29, 11:37 pm)
Re: [xfs-masters] Re: freeze vs freezer, Dave Chinner, (Mon Jun 30, 5:33 am)
Re: [xfs-masters] Re: freeze vs freezer, Rafael J. Wysocki, (Mon Jun 30, 1:34 pm)
Re: [xfs-masters] Re: freeze vs freezer, Rafael J. Wysocki, (Mon Jun 30, 2:00 pm)
Re: [xfs-masters] Re: freeze vs freezer, Dave Chinner, (Mon Jun 30, 3:21 pm)
Re: [xfs-masters] Re: freeze vs freezer, Rafael J. Wysocki, (Mon Jun 30, 3:38 pm)
Re: [xfs-masters] Re: freeze vs freezer, Dave Chinner, (Mon Jun 30, 11:38 pm)
Re: [xfs-masters] Re: freeze vs freezer, Pavel Machek, (Tue Jul 1, 1:59 am)
Re: [xfs-masters] Re: freeze vs freezer, Rafael J. Wysocki, (Tue Jul 1, 7:35 am)
Re: [xfs-masters] Re: freeze vs freezer, Dave Chinner, (Tue Jul 1, 2:12 pm)
Re: [xfs-masters] Re: freeze vs freezer, Rafael J. Wysocki, (Tue Jul 1, 2:21 pm)
Re: [xfs-masters] Re: freeze vs freezer, Eric Sandeen, (Thu Jul 3, 12:43 pm)