Re: Problem with ata layer in 2.6.24

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Gene Heskett <gene.heskett@...>
Cc: Jeff Garzik <jeff@...>, Linux Kernel Mailing List <linux-kernel@...>, Linux IDE mailing list <linux-ide@...>
Date: Tuesday, January 29, 2008 - 2:41 am

On Mon, 28 Jan 2008 14:13:21 -0500
Gene Heskett <gene.heskett@gmail.com> wrote:


 0x0
dma
968
read


I had this error too, or maybe only a similar one, and another, neither
of which of i still have the error output laying around, so I'm posting both
fixes, that i found here on lkml:
1) disabling ncq like that:
"echo 1 > /sys/block/sda/device/queue_depth"=20
2) this patch: libata_drain_fifo_on_stuck_drq_hsm.patch=20
( applies to 2.6.24 too )

Signed-off-by: Mark Lord <mlord@pobox.com>
---

--- old/drivers/ata/libata-sff.c	2007-09-28 09:29:22.000000000 -0400
+++ linux/drivers/ata/libata-sff.c	2007-09-28 09:39:44.000000000 -0400
@@ -420,6 +420,28 @@
 	ap->ops->irq_on(ap);
 }
=20
+static void ata_drain_fifo(struct ata_port *ap, struct ata_queued_cmd *qc)
+{
+	u8 stat =3D ata_chk_status(ap);
+	/*
+	 * Try to clear stuck DRQ if necessary,
+	 * by reading/discarding up to two sectors worth of data.
+	 */
+	if ((stat & ATA_DRQ) && (!qc || qc->dma_dir !=3D DMA_TO_DEVICE)) {
+		unsigned int i;
+		unsigned int limit =3D qc ? qc->sect_size : ATA_SECT_SIZE;
+
+		printk(KERN_WARNING "Draining up to %u words from data FIFO.\n",
+									limit);
+		for (i =3D 0; i < limit ; ++i) {
+			ioread16(ap->ioaddr.data_addr);
+			if (!(ata_chk_status(ap) & ATA_DRQ))
+				break;
+		}
+		printk(KERN_WARNING "Drained %u/%u words.\n", i, limit);
+	}
+}
+
 /**
  *	ata_bmdma_drive_eh - Perform EH with given methods for BMDMA controller
  *	@ap: port to handle error for
@@ -476,7 +498,7 @@
 	}
=20
 	ata_altstatus(ap);
-	ata_chk_status(ap);
+	ata_drain_fifo(ap, qc);
 	ap->ops->irq_clear(ap);
=20
 	spin_unlock_irqrestore(ap->lock, flags);
-





--=20
Florian Attenberger <valdyn@gmail.com>
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Problem with ata layer in 2.6.24, Gene Heskett, (Sun Jan 27, 10:22 pm)
Re: Problem with ata layer in 2.6.24, Jeff Garzik, (Mon Jan 28, 3:08 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 3:13 pm)
Re: Problem with ata layer in 2.6.24, Florian Attenberger, (Tue Jan 29, 2:41 am)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 11:04 am)
Re: Problem with ata layer in 2.6.24, Jeff Garzik, (Tue Jan 29, 12:58 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 1:12 pm)
Re: Problem with ata layer in 2.6.24, Jeff Garzik, (Tue Jan 29, 1:32 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 1:53 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Tue Jan 29, 12:12 pm)
Re: Problem with ata layer in 2.6.24, rgheck, (Tue Jan 29, 12:50 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 12:36 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Tue Jan 29, 2:09 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Mon Jan 28, 2:54 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Mon Jan 28, 3:01 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 3:04 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Mon Jan 28, 4:22 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Mon Jan 28, 4:32 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 8:10 pm)
Re: Problem with ata layer in 2.6.24, Mikael Pettersson, (Mon Jan 28, 4:17 am)
Re: Problem with ata layer in 2.6.24, Peter Zijlstra, (Mon Jan 28, 8:03 am)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 8:54 am)
Re: Problem with ata layer in 2.6.24, Richard Heck, (Mon Jan 28, 10:44 am)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 1:01 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 9:19 am)
Re: Problem with ata layer in 2.6.24, Mikael Pettersson, (Mon Jan 28, 9:57 am)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 12:35 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 12:56 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Mon Jan 28, 2:20 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 2:59 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Mon Jan 28, 4:43 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 8:06 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Mon Jan 28, 11:16 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 12:07 am)
Re: Problem with ata layer in 2.6.24, Dave Neuer, (Mon Jan 28, 1:06 pm)
Re: Problem with ata layer in 2.6.24, Kasper Sandberg, (Tue Jan 29, 12:23 am)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 12:49 am)
Re: Problem with ata layer in 2.6.24, Kasper Sandberg, (Tue Jan 29, 1:01 am)
Re: Problem with ata layer in 2.6.24, Tejun Heo, (Sat Feb 2, 3:13 am)
Re: Problem with ata layer in 2.6.24, Calvin Walton, (Mon Jan 28, 12:50 pm)
Re: Problem with ata layer in 2.6.24, Zan Lynx, (Mon Jan 28, 1:20 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 1:30 pm)
Re: Problem with ata layer in 2.6.24, Daniel Barkalow, (Mon Jan 28, 1:59 pm)
Re: Problem with ata layer in 2.6.24, Richard Heck, (Mon Jan 28, 2:23 pm)
Re: Problem with ata layer in 2.6.24, Daniel Barkalow, (Mon Jan 28, 4:01 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 8:05 pm)
Re: Problem with ata layer in 2.6.24, Daniel Barkalow, (Mon Jan 28, 8:34 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 9:31 pm)
Re: Problem with ata layer in 2.6.24, Daniel Barkalow, (Mon Jan 28, 9:51 pm)
Re: Problem with ata layer in 2.6.24, Michal Jaegermann, (Tue Jan 29, 12:48 am)
Re: Problem with ata layer in 2.6.24, Alan Cox, (Tue Jan 29, 8:12 am)
Re: Problem with ata layer in 2.6.24, Daniel Barkalow, (Tue Jan 29, 2:14 pm)
Re: Problem with ata layer in 2.6.24, Alan Cox, (Tue Jan 29, 2:46 pm)
Re: Problem with ata layer in 2.6.24, Daniel Barkalow, (Tue Jan 29, 3:14 pm)
Re: Problem with ata layer in 2.6.24, Alan Cox, (Tue Jan 29, 3:34 pm)
Re: Problem with ata layer in 2.6.24, rgheck, (Tue Jan 29, 1:06 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Tue Jan 29, 2:11 pm)
Re: Problem with ata layer in 2.6.24, rgheck, (Tue Jan 29, 2:28 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Tue Jan 29, 2:32 pm)
Re: Problem with ata layer in 2.6.24, Alan Cox, (Tue Jan 29, 1:12 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 10:51 am)
Re: Problem with ata layer in 2.6.24, Alan Cox, (Tue Jan 29, 11:47 am)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 12:32 pm)
Re: Problem with ata layer in 2.6.24, Mikael Pettersson, (Tue Jan 29, 12:48 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 1:04 pm)
Re: Problem with ata layer in 2.6.24, Alan Cox, (Tue Jan 29, 2:54 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 6:41 pm)
Re: Problem with ata layer in 2.6.24, Mark Lord, (Tue Jan 29, 8:19 pm)
Re: Problem with ata layer in 2.6.24, Alan Cox, (Tue Jan 29, 6:48 pm)
Re: Problem with ata layer in 2.6.24, Daniel Barkalow, (Tue Jan 29, 1:38 pm)
Re: Problem with ata layer in 2.6.24, Alan Cox, (Tue Jan 29, 1:44 pm)
Re: Problem with ata layer in 2.6.24, Daniel Barkalow, (Tue Jan 29, 2:12 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 1:59 pm)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Tue Jan 29, 10:30 am)
Re: Problem with ata layer in 2.6.24, Gene Heskett, (Mon Jan 28, 1:44 pm)
Re: Problem with ata layer in 2.6.24, Mikael Pettersson, (Mon Jan 28, 8:26 am)
Re: Problem with ata layer in 2.6.24, Ingo Molnar, (Mon Jan 28, 8:45 am)
Re: Problem with ata layer in 2.6.24, Kasper Sandberg, (Sun Jan 27, 11:19 pm)