Home » Mailing list archives » linux-kernel » 2008 » January » 29

Re: [patch 1/6] mmu_notifier: Core code

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Lameter <clameter@...>
To: Robin Holt <holt@...>
Cc: Andrea Arcangeli <andrea@...>, Avi Kivity <avi@...>, Izik Eidus <izike@...>, Nick Piggin <npiggin@...>, <kvm-devel@...>, Benjamin Herrenschmidt <benh@...>, Peter Zijlstra <a.p.zijlstra@...>, <steiner@...>, <linux-kernel@...>, <linux-mm@...>, <daniel.blueman@...>, Hugh Dickins <hugh@...>
Subject: Re: [patch 1/6] mmu_notifier: Core code
Date: Monday, January 28, 2008 - 9:19 pm

On Mon, 28 Jan 2008, Robin Holt wrote:


Must have slipped somehow. Patch needs to be applied after the rcu fix.

Please repeat the other relevant comments if they are still relevant.... I 
thought I had worked through them.



mmu_notifier_release: remove mmu_notifier struct from list before calling ->release

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 mm/mmu_notifier.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/mm/mmu_notifier.c
===================================================================
--- linux-2.6.orig/mm/mmu_notifier.c	2008-01-28 17:17:05.000000000 -0800
+++ linux-2.6/mm/mmu_notifier.c	2008-01-28 17:17:10.000000000 -0800
@@ -21,9 +21,9 @@ void mmu_notifier_release(struct mm_stru
 		rcu_read_lock();
 		hlist_for_each_entry_safe_rcu(mn, n, t,
 					  &mm->mmu_notifier.head, hlist) {
+			hlist_del_rcu(&mn->hlist);
 			if (mn->ops->release)
 				mn->ops->release(mn, mm);
-			hlist_del_rcu(&mn->hlist);
 		}
 		rcu_read_unlock();
 		synchronize_rcu();
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 1/6] mmu_notifier: Core code, Christoph Lameter, (Mon Jan 28, 4:28 pm)
Re: [patch 1/6] mmu_notifier: Core code, Andy Whitcroft, (Tue Feb 5, 2:05 pm)
Re: [patch 1/6] mmu_notifier: Core code, Christoph Lameter, (Tue Feb 5, 2:19 pm)
Re: [patch 1/6] mmu_notifier: Core code, Peter Zijlstra, (Tue Feb 5, 2:17 pm)
Re: [patch 1/6] mmu_notifier: Core code, Robin Holt, (Tue Jan 29, 12:07 pm)
Re: [patch 1/6] mmu_notifier: Core code, Andrea Arcangeli, (Tue Jan 29, 9:59 am)
Re: [patch 1/6] mmu_notifier: Core code, Christoph Lameter, (Tue Jan 29, 3:49 pm)
Re: [patch 1/6] mmu_notifier: Core code, Avi Kivity, (Tue Jan 29, 4:41 pm)
Re: [patch 1/6] mmu_notifier: Core code, Andrea Arcangeli, (Tue Jan 29, 10:34 am)
Re: [patch 1/6] mmu_notifier: Core code, Robin Holt, (Mon Jan 28, 8:05 pm)
Re: [patch 1/6] mmu_notifier: Core code, Christoph Lameter, (Mon Jan 28, 9:19 pm)
Re: [patch 1/6] mmu_notifier: Core code, Christoph Lameter, (Mon Jan 28, 6:06 pm)