Home » Mailing list archives » linux-kernel » 2008 » January » 28

[PATCH 7/7] fix lines over 80 characters

Previous thread: [PATCH 6/7] X86: include missing KERN_ facility level by Paolo Ciarrocchi on Monday, January 28, 2008 - 7:08 pm. (3 messages)

Next thread: [PATCH] Improve Documentation/stable_api_nonsense.txt by Heikki Orsila on Monday, January 28, 2008 - 7:09 pm. (9 messages)
[view original message]
From: Paolo Ciarrocchi <paolo.ciarrocchi@...>
To: Ingo Molnar <mingo@...>, Linux Kernel <linux-kernel@...>
Subject: [PATCH 7/7] fix lines over 80 characters
Date: Monday, January 28, 2008 - 7:08 pm

fix lines over 80 characters


Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>

---

 arch/x86/math-emu/errors.c |    6 ++++--

 1 files changed, 4 insertions(+), 2 deletions(-)


diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c

index 569a62e..e5a5b80 100644

--- a/arch/x86/math-emu/errors.c

+++ b/arch/x86/math-emu/errors.c

@@ -75,7 +75,8 @@ void FPU_printall(void)

 	  FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);


 	  if (FPU_modrm >= 0300)

-	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8, FPU_modrm & 7);

+	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,

+		FPU_modrm & 7);

 	  else

 	    printk(KERN_ERR " /%d, mod=%d rm=%d\n",

 		   (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);

@@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)

 	printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);


       if (n == EX_INTERNAL) {

-	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n", int_type);

+	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",

+		int_type);

 	  FPU_printall();

 	}

 #ifdef PRINT_MESSAGES

--

1.5.4.rc3


--
[view original message]
From: Stefan Richter <stefanr@...>
To: Paolo Ciarrocchi <paolo.ciarrocchi@...>
Cc: Ingo Molnar <mingo@...>, Linux Kernel <linux-kernel@...>
Subject: Re: [PATCH 7/7] fix lines over 80 characters
Date: Tuesday, January 29, 2008 - 8:46 am

The "fix" is still not conforming to CodingStyle.


Besides, why don't you leave these lines as they are?  There is no

important information hidden behind the 80th column in the existing code.

--

Stefan Richter

-=====-==--- ---= ===-=

http://arcgraph.de/sr/

--
[view original message]
From: Paolo Ciarrocchi <paolo.ciarrocchi@...>
To: Stefan Richter <stefanr@...>
Cc: Ingo Molnar <mingo@...>, Linux Kernel <linux-kernel@...>
Subject: Re: [PATCH 7/7] fix lines over 80 characters
Date: Thursday, January 31, 2008 - 6:54 pm

Yes, you are right.

Ingo, patch 7 deserves to be deleted.


Ciao,

--

Paolo

http://paolo.ciarrocchi.googlepages.com/

--
Previous thread: [PATCH 6/7] X86: include missing KERN_ facility level by Paolo Ciarrocchi on Monday, January 28, 2008 - 7:08 pm. (3 messages)

Next thread: [PATCH] Improve Documentation/stable_api_nonsense.txt by Heikki Orsila on Monday, January 28, 2008 - 7:09 pm. (9 messages)