Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek | KernelTrap

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Alan Cox <alan@...>

To: Andrew Morton <akpm@...>

Cc: Andi Kleen <ak@...>, Trond Myklebust <Trond.Myklebust@...>, Steve French <smfrench@...>, <swhiteho@...>, <sfrench@...>, <vandrove@...>, <linux-kernel@...>, <linux-fsdevel@...>

Subject: Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

Date: Monday, January 28, 2008 - 8:56 am

> > No specific spec, just general quality of implementation.
quoted text> 
> I completely agree.  If one thread writes A and another writes B then the
> kernel should record either A or B, not ((A & 0xffffffff00000000) | (B &
> 0xffffffff))

Agree entirely: the spec doesn't allow for random scribbling in the wrong
place. It doesn't cover which goes first or who "wins" the race but
provides pwrite/pread for that situation. Writing somewhere unrelated is
definitely not to spec and not good.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] [0/18] Implement some low hanging BKL removal fruit ..., Andi Kleen, (Sat Jan 26, 10:17 pm)

Re: [PATCH] [0/18] Implement some low hanging BKL removal fr..., Nick Piggin, (Sun Jan 27, 9:59 pm)

Re: [PATCH] [0/18] Implement some low hanging BKL removal fr..., Andi Kleen, (Sun Jan 27, 11:15 pm)

[PATCH] [5/18] BKL-removal: Remove incorrect comment referin..., Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [6/18] BKL-removal: Convert ext4 to use unlocked_ioctl, Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [3/18] BKL-removal: Convert ext3 to use unlocked_ioctl, Andi Kleen, (Sat Jan 26, 10:17 pm)

Re: [PATCH] [3/18] BKL-removal: Convert ext3 to use unlocked..., Andrew Morton, (Mon Jan 28, 1:33 am)

Re: [PATCH] [3/18] BKL-removal: Convert ext3 to use unlocked..., Andi Kleen, (Mon Jan 28, 2:02 am)

[PATCH] [11/18] BKL-removal: Convert ocfs2 over to unlocked_..., Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [12/18] BKL-removal: Convert CIFS over to unlocked_i..., Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [13/18] BKL-removal: Add compat_ioctl for cifs, Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [16/18] BKL-removal: Convert socket fasync to unlock..., Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [9/18] BKL-removal: Use unlocked_ioctl for jfs, Andi Kleen, (Sat Jan 26, 10:17 pm)

Re: [PATCH] [9/18] BKL-removal: Use unlocked_ioctl for jfs, Dave Kleikamp, (Sun Jan 27, 7:05 pm)

[PATCH] [18/18] BKL-removal: Convert bad_inode to unlocked_f..., Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [17/18] BKL-removal: Convert fuse to unlocked_fasync, Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [15/18] BKL-removal: Convert pipe over to unlocked_f..., Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [14/18] BKL-removal: Add unlocked_fasync, Andi Kleen, (Sat Jan 26, 10:17 pm)

Re: [PATCH] [14/18] BKL-removal: Add unlocked_fasync, KOSAKI Motohiro, (Sun Jan 27, 3:05 am)

[PATCH] [10/18] BKL-removal: Implement a compat_ioctl handle..., Andi Kleen, (Sat Jan 26, 10:17 pm)

Re: [PATCH] [10/18] BKL-removal: Implement a compat_ioctl ha..., Dave Kleikamp, (Sun Jan 27, 7:05 pm)

[PATCH] [4/18] ext3: Remove incorrect BKL comment, Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Andi Kleen, (Sat Jan 26, 10:17 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Steve French, (Sun Jan 27, 12:57 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Andi Kleen, (Sun Jan 27, 10:43 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Trond Myklebust, (Sun Jan 27, 1:56 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Steve French, (Sun Jan 27, 6:18 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Andi Kleen, (Sun Jan 27, 10:44 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Trond Myklebust, (Sun Jan 27, 7:08 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Andi Kleen, (Sun Jan 27, 10:58 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Trond Myklebust, (Mon Jan 28, 12:13 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Andi Kleen, (Mon Jan 28, 12:38 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Andrew Morton, (Mon Jan 28, 1:13 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Alan Cox, (Mon Jan 28, 8:56 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Andi Kleen, (Mon Jan 28, 9:27 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Alan Cox, (Mon Jan 28, 9:38 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Andi Kleen, (Mon Jan 28, 10:10 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Diego Calleja, (Mon Jan 28, 11:13 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Alan Cox, (Mon Jan 28, 10:50 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Andi Kleen, (Mon Jan 28, 4:17 am)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Steve French, (Mon Jan 28, 2:33 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Dave Kleikamp, (Mon Jan 28, 3:34 pm)

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek, Trond Myklebust, (Mon Jan 28, 12:51 am)

[PATCH] [7/18] BKL-removal: Remove incorrect comments referi..., Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [2/18] BKL-removal: Remove incorrect BKL comment in ..., Andi Kleen, (Sat Jan 26, 10:17 pm)

[PATCH] [1/18] BKL-removal: Convert ext2 over to use unlocke..., Andi Kleen, (Sat Jan 26, 10:17 pm)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
Artem Bityutskiy	[PATCH 18/44 take 2] [UBI] build unit implementation
James Morris	Re: LSM conversion to static interface
git:

linux-netdev:
Paul Jackson	[PATCH] cpuset sched_load_balance kmalloc fix
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Linus Torvalds	Re: [GIT]: Networking
openbsd-misc:

Colocation donated by:

Who's online

There are currently 1 user and 474 guests online.

Online users

sellhousefast

Syndicate