Fix build with CONFIG_BLOCK off. Building git-2d94dfc with CONFIG_BLOCK turned off gives me: drivers/base/core.c: In function 'device_add_class_symlinks': drivers/base/core.c:704: error: 'part_type' undeclared (first use in this function) drivers/base/core.c:704: error: (Each undeclared identifier is reported only once drivers/base/core.c:704: error: for each function it appears in.) drivers/base/core.c: In function 'device_remove_class_symlinks': drivers/base/core.c:743: error: 'part_type' ...

Hi everyone, I'm having trouble to determine the cause of the following behavior. I'm not even sure that I'm supposed to hot plug and unplug a SATA drive from a nForce3 Ultra (apparently CK8S, on a Gigabyte K8NS Ultra 939 mobo) SATA interface, to begin with. The information is hard to find given that the sata_nv driver supports a range of different hardware. I've recently acquired an external drive with (among others) an eSATA interface, so I also bought a eSATA->SATA bracket and intend to ...

Honestly, this is the least interesting merge push I've had in a while. We're all doing debugging and such, so nothing major is below. I have some queued stuff (notably a sata_mv update) still to come, but this is the stuff that's been pending and in -mm for a while. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/Kconfig | 9 + ...

BEEP isn't actually used here and should probably be a C function if needed. Note: in real mode you can also produce a beep by calling int $0x10 with %ax = 0x0e07. Please note that some int $0x10 implementations clobber certain registers... see the INT10 macro in the bootup code. Seriously cool, though, that you're getting this far. -hpa --

Yes, it's normal. Dual core AMD64 machines really do have unstable TSC. Lee --

Subject: x86: deprecate change_page_attr() From: Arjan van de Ven <arjan@linux.intel.com> With the introduction of the new API, no driver or non-archcore code needs to use c-p-a anymore, so this patch also deprecates the EXPORT_SYMBOL of CPA (it's a horrible API after all). Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> --- arch/x86/mm/pageattr.c | 2 +- include/asm-x86/cacheflush.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) Index: ...

Subject: x86: a new API for drivers/etc to control cache and other page attributes From: Arjan van de Ven <arjan@linux.intel.com> Right now, if drivers or other code want to change, say, a cache attribute of a page, the only API they have is change_page_attr(). c-p-a is a really bad API for this, because it forces the caller to know *ALL* the attributes he wants for the page, not just the 1 thing he wants to change. So code that wants to set a page uncachable, needs to be aware of the NX ...

Thanks for keeping your eyes on us. Your sign-off will go in when I build the for-linus branch. Get well, -- Stefan Richter -=====-==--- ---= ==--= http://arcgraph.de/sr/ --

find a workaround below - but i'm not sure it's the right one. Ingo Index: linux/drivers/crypto/Kconfig =================================================================== --- linux.orig/drivers/crypto/Kconfig +++ linux/drivers/crypto/Kconfig @@ -89,6 +89,7 @@ config CRYPTO_DEV_HIFN_795X select CRYPTO_ALGAPI select CRYPTO_BLKCIPHER depends on PCI + depends on DEV_HIFN_795X = HW_RANDOM help This option allows you to have support for HIFN 795x crypto adapters. --

hey, that's my punishment for not reading my email promptly :) Could have saved me some time in the Kconfig web of dependencies :-/ Ingo --

We are pleased to announce the 2.6.24-rt1 tree, which can be downloaded from the location: http://rt.et.redhat.com/download/ Information on the RT patch can be found at: http://rt.wiki.kernel.org/index.php/Main_Page Changes since 2.6.24-rc8-rt1 - ported to 2.6.24 to build a 2.6.24-rt1 tree, the following patches should be applied: http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.24.tar.bz2 http://rt.et.redhat.com/download/patch-2.6.24-rt1.bz2 And like always, ...

Hey Andrew, Please add this patch along with Greg KH's kobject fixes. This module is dependent on the fixes that Greg KH has in his patches git tree. This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI connection information so that they can ...

This patch is against the x86-git which included the kgdb core. Per review request from the x86-git maintainers, the kgdb-core has had the kgdb_handle_exception() separated into individual functions. This patch does nothing other than re-organize the code. There are no functional kgdb changes. kgdb_handle_exception now calls gdb_serial_stub() to handle the debugger communications. The gdb_serial_stub() has call out to sub handlers for all the major gdb serial packet ...

In x86 PAE mode, stop treating pmds as a special case. Previously they were always allocated and freed with the pgd. The modifies the code to be the same as 64-bit mode, where they are allocated on demand. This is a step on the way to unifying 32/64-bit pagetable allocation as much as possible. There is a complicating wart, however. When you install a new reference to a pmd in the pgd, the processor isn't guaranteed to see it unless you reload cr3. Since reloading cr3 also has ...

Convert macros into inline functions, for better type-checking. This patch required a little bit of fiddling with headers in order to make __(pte|pmd)_free_tlb inline rather than macros. asm-generic/tlb.h includes asm/pgalloc.h, though it doesn't directly use any pgalloc definitions. I removed this include to avoid an include cycle, but it may cause secondary compile failures by things depending on the indirect inclusion; arch/x86/mm/hugetlbpage.c was one such place; there may be ...

The constructors for PAE and non-PAE pgd_ctors are more or less identical, and can be made into the same function. Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> Cc: William Irwin <wli@holomorphy.com> --- arch/x86/mm/pgtable_32.c | 43 +++++++++++-------------------------------- 1 file changed, 11 insertions(+), 32 deletions(-) diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c --- a/arch/x86/mm/pgtable_32.c +++ b/arch/x86/mm/pgtable_32.c @@ -224,50 +224,32 @@ ...

If SHARED_KERNEL_PMD is false, then we need to allocate and initialize the kernel pmd. We can easily piggy-back this onto the existing pmd prepopulation code. Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> --- arch/x86/mm/pgtable_32.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c --- a/arch/x86/mm/pgtable_32.c +++ b/arch/x86/mm/pgtable_32.c @@ -269,7 +269,7 @@ static void ...

PAE mode requires that we reload cr3 in order to guarantee that changes to the pgd will be noticed by the processor. This means that in principle pud_clear needs to reload cr3 every time. However, because reloading cr3 implies a tlb flush, we want to avoid it where possible. pud_clear() is only used in a couple of places: - in free_pmd_range(), when pulling down a range of process address space, and - huge_pmd_unshare() In both cases, the calling code will do a a tlb flush anyway, ...

Hi Ingo, This series addresses various cleanups in pagetable allocation in the direction of unifying 32/64 bits (that's still a while off yet). The significant change in here is that I'm separating the lifetime of a pmd from its pgd in the 32-bit PAE case. This makes it logically the same as 64-bit pagetable allocation, and it overall simplifies the code. The patches are: - A pure Xen fix I tacked on for convenience - Use the same pgd_list mechanism for 32 and 64 bits - Add an mm ...

Hi! I have just updated my server to 2.6.24 and the dl2k driver has stopped working. The problem seems to be when autoselecting the media, the driver says that the card is set as "Auto 1000 Mbps, Half duplex" instead of the usual "Auto 1000 Mbps, Full duplex", I have tried setting "options dl2k media=1000mbps_fd" but that didn't seem to change anything (the driver still said "Auto 1000 Mbps, Half duplex"). I've been playing with ethtools and got it to work at 100FD by setting it manually, ...

It only matters (for a processor which supports PGE) if we actually use This one makes me nervous, as it feels like a side effect of implementation, and not a guarantee by design. -hpa --

Hm, but then chapter 10 goes and makes things confusing with "Alternative INVLPG Behavior"; but I guess if software needs to explicitly enable this behaviour in a yet-to-be-determined way, its OK... Is there any guide about the tradeoff of when to use invlpg vs flushing the whole tlb? 1 page? 10? 90% of the tlb? J --

Hi, here is the first release of patches for KVM to support the Nested Paging (NPT) feature of AMD QuadCore CPUs for comments and public testing. This feature improves the guest performance significantly. I measured an improvement of around 17% using kernbench in my first tests. This patch series is basically tested with Linux guests (32 bit legacy paging, 32 bit PAE ...

Let SVM detect if the Nested Paging feature is available on the hardware. Disable it to keep this patch series bisectable. Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> --- arch/x86/kvm/svm.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 0c58527..49bb57a 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -47,6 +47,8 @@ MODULE_LICENSE("GPL"); #define SVM_FEATURE_LBRV (1 << 1) #define ...

The generic x86 code has to know if the specific implementation uses Nested Paging. In the generic code Nested Paging is called Hardware Assisted Paging (HAP) to avoid confusion with (future) HAP implementations of other vendors. This patch exports the availability of HAP to the generic x86 code. Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> --- arch/x86/kvm/svm.c | 7 +++++++ arch/x86/kvm/vmx.c | 7 +++++++ include/asm-x86/kvm_host.h | 2 ++ 3 files changed, 16 ...

This would probably be better as an integer. Then we don't have to do nasty things like implicitly cast a literal to a char *. Regards, --

A quick sniff test and things look pretty good. I was able to start running the install CDs for 32-bit and 64-bit Ubuntu, 32-bit OpenSuSE, 64-bit Fedora, and 32-bit Win2k8. I'll do a more thorough run of kvm-test on Monday when I have a better connection to my machine. Nice work! Regards, --

To disable the use of the Nested Paging feature even if it is available in hardware this patch adds a module parameter. Nested Paging can be disabled by passing npt=off to the kvm_amd module. Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> --- arch/x86/kvm/svm.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 49bb57a..2e718ff 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -48,6 +48,9 @@ ...

This patch contains the SVM architecture dependent changes for KVM to enable support for the Nested Paging feature of AMD Barcelona and Phenom processors. Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> --- arch/x86/kvm/svm.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 63 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index d0bfdd8..578d8ec 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -47,7 +47,12 @@ ...

Hmm, I used int for that first but typing npt=off seemed more userfriendly to me than npt=0. So I used char* for it. Joerg -- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager ...

In looking at this code some more, I'm a bit confused. We have an array of kobjects in per_cpu(threshold_banks, cpu)[bank]->kobj Now the kobject in the struct threshold_bank structure is a "static" one, one that should govern the lifecycle of the object, yet there is no release function for it at all. I don't see a way for it to ever be properly torn down. But it's the bank kobjects that are dynamic. They look to be created properly, and the life cycle is correct because they are ...

Oh wait, I do see a change. We are now (finally) emitting a kobject uevent for these devices, which somehow the code can't handle properly. Let me go poke this some more, unfortunatly I don't have any AMD 64 boxes here anymore, only Intel based processors, so I can't run this module... thanks, greg k-h --

Does this happen on just Linus's tree? Can you send me a .config file for this? What is threshold_init()? Is it something new in the x86.git tree? thanks, greg k-h --

Calling initcall 0xffffffff80ba1dee: threshold_init_device+0x0/0x3f() kobject: 'threshold_bank4' (ffff8108265450c0): kobject_add_internal: parent: 'machinecheck0', set: '<NULL>' kobject: 'misc0' (ffff810425497418): kobject_add_internal: parent: 'threshold_bank4', set: '<NULL>' kobject: 'misc1' (ffff810425497498): kobject_add_internal: parent: 'threshold_bank4', set: '<NULL>' kobject: 'misc2' (ffff810425497518): kobject_add_internal: parent: 'threshold_bank4', set: '<NULL>' Unable to handle ...

Linus, please pull the latest scheduler git tree for v2.6.25 from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git it contains various enhancements to the scheduler - find the full shortlog is below. 96 commits from 19 authors - scheduler developers have been busy again. :-/ The scheduling behavior of the kernel to normal users should not change over v2.6.24, but there are a good number of new features and enhancements under the hood: - various ...

Hm, I thought we fixed the CONFIG_BLOCK disabled issues with Randy's older patch. Randy, wasn't this already addressed somehow? Jeremy, do you have a .config I can use to try to duplicate and fix this? thanks, greg k-h --

When compiling current git with CONFIG_BLOCK disabled, I'm seeing this compile error: CC drivers/base/core.o /home/jeremy/hg/xen/paravirt/linux/drivers/base/core.c: In function ‘device_add_class_symlinks’: /home/jeremy/hg/xen/paravirt/linux/drivers/base/core.c:655: error: ‘part_type’ undeclared (first use in this function) /home/jeremy/hg/xen/paravirt/linux/drivers/base/core.c:655: error: (Each undeclared identifier is reported only ...

Now that it missed 2.6.24, you probably want to send it to -stable too. Even though the patch is trivial, it might be a good idea to cc: v4l2 maintainer and / or driver author. Thanks Guennadi --- Guennadi Liakhovetski --

Hi All, Would appreciate feedback on this patch. Thanks in advance, Wim. commit 4956e4e5e77b5a8f87bcfe6127ef17a406edf94b Author: Wim Van Sebroeck <wim@iguana.be> Date: Mon Dec 31 17:21:33 2007 +0000 [PATCH] SMBIOS/DMI - add type 41 = Onboard Devices Extended Information From version 2.6 of the SMBIOS standard, type 10 (On Board Devices Information) becomes obsolete. The reason for this is that no further fields can be added to this structure without adversely ...

Yep, thanks for noticing, i'll delete the duplicate. -Len --

Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com> --- drivers/infiniband/hw/ehca/ehca_irq.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c index 863b34f..b5ca94c 100644 --- a/drivers/infiniband/hw/ehca/ehca_irq.c +++ b/drivers/infiniband/hw/ehca/ehca_irq.c @@ -403,6 +403,8 @@ static void parse_ec(struct ehca_shca *shca, u64 eqe) sport->port_state = IB_PORT_ACTIVE; ...

Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/shaggy/jfs-2.6.git for-linus This will update the following files: fs/jfs/jfs_dtree.c | 27 +++++++++++-------------- fs/jfs/jfs_dtree.h | 4 +-- fs/jfs/jfs_imap.c | 4 +-- fs/jfs/jfs_logmgr.c | 34 ++++++++++++++----------------- fs/jfs/jfs_metapage.c | 43 ++++++++++++++++++++++------------------ fs/jfs/jfs_mount.c | 2 - fs/jfs/jfs_umount.c | 4 +-- fs/jfs/namei.c | 4 ...

Hi David, Simply post them to the list with subjects beginning with "[PATCH] 2.4: " so that we notice them. Please CC me because I can easily miss them as they now represent about 1/2000 of the mails here! Also, you should ensure that your patches are really relevant to the usage people have of 2.4 nowadays. If you fix bugs, that's fine. If you want to contribute new drivers/features, you should first check that they are correctly working in 2.6 so that people do not get trapped when they ...

remove the newly added __KERNEL__ block from linux/vt.h Signed-off-by: Olaf Hering <olaf@aepfle.de> --- include/linux/Kbuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/Kbuild +++ b/include/linux/Kbuild @@ -157,7 +157,6 @@ header-y += veth.h header-y += video_decoder.h header-y += video_encoder.h header-y += videotext.h -header-y += vt.h header-y += x25.h unifdef-y += acct.h @@ -348,6 +347,7 @@ unifdef-y += videodev.h unifdef-y += ...

On Jan 24, 2008 3:35 PM, William Warren An update: I don't know whether it is a kernel problem or a hardware problem, but the instructions pertaining to removing and adding SCSI devices live above doesn't work on a PE2850 (which uses "LSI Logic / Symbios Logic 53c1030 PCI-X Fusion-MPT Dual Ultra320 SCSI (rev 08)", aka Dell's PERC controller 4e/Di, driven by the mpt* drivers.) It *appears* to work, but the bus seems to grind to a near halt. This may be an inaccurate conclusion, but I'm ...

Hi Ingo, Can I talk you into dropping these patches of mine from sched-devel (or not send them to Linus): da0f9440cdcb1edd5424de91f326de83de3fe5f9 sched: make sure jiffies is up to date before calling __update_rq_clock() 6eb300ad38fef6db4efe177067a65aaa771596da sched: fix rq->clock overflows detection with CONFIG_NO_HZ They are not of good enough quality, and I'm working on a better approach. Thanks. -- Guillaume --

sure, done. what method are you using of determining quality? Could you perhaps try to automate it? (even better would be some self-test within the kernel that detects badness) Ingo --

If the machine goes oops and softlocks (e.g. bug in root filesystem, lock held but not released, box essentially dead), ping also still or that. --

Thanks. I remember having fixed it ... -- Professionals are predictable, it's the amateurs that are dangerous. --

I don't think it's a good idea to keep the network running in the soft panic. A lot of people have set ups that use ping was a watchdog and with nfsroot/ip=dhcp ping does work quite well before mounting root and then the watchdog might not pick up the soft panic. Using a polled keyboard driver after panic seems to be the better option to me, but if you want softpanic you should probably at least add a suitable panic notifier to the network stack to shut it all down. -Andi --

Enabling this option changes a hard panic on boot errors to a soft panic, which does not stop the system completely. You can still scroll the screen and read the messages. Signed-Off-By: Bodo Eggert <7eggert@gmx.de> diff -pruN -X dontdiff linux-2.6.24.pure/include/linux/kernel.h linux-2.6.24.softpanic/include/linux/kernel.h --- linux-2.6.24.pure/include/linux/kernel.h 2008-01-25 15:09:36.000000000 +0100 +++ linux-2.6.24.softpanic/include/linux/kernel.h 2008-01-25 15:31:26.000000000 +0100 @@ ...

As per MAINTAINERS, m68knommu is handled by: UCLINUX (AND M68KNOMMU) P: Greg Ungerer M: gerg@uclinux.org L: uclinux-dev@uclinux.org (subscribers-only) I already forwarded a copy of your email to Greg. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. ...

fec.c is only used on M68k Coldfire CPUs. Remove leftover PowerPC code from this driver. Signed-off-by: Jochen Friedrich <jochen@scram.de> --- drivers/net/fec.c | 136 +--------------------------------------------------- 1 files changed, 3 insertions(+), 133 deletions(-) diff --git a/drivers/net/fec.c b/drivers/net/fec.c index 0fbf1bb..0499cbb 100644 --- a/drivers/net/fec.c +++ b/drivers/net/fec.c @@ -23,6 +23,9 @@ * * Bug fixes and cleanup by Philippe De Muyter (phdm@macqel.be) ...

Yes, that certainly makes more sense, although IMHO the second sentence is still somewhat redundant. (My problem was mainly with the second sentence. I should have made that more clear, sorry.) --

Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the includes accordingly. Signed-off-by: Jochen Friedrich <jochen@scram.de> --- arch/powerpc/platforms/8xx/ep88xc.c | 1 + arch/powerpc/platforms/8xx/mpc86xads_setup.c | 2 +- arch/powerpc/platforms/8xx/mpc885ads_setup.c | 2 +- arch/powerpc/sysdev/Makefile | 4 ++-- arch/powerpc/sysdev/{commproc.c => cpm1.c} | ...

Sounds like a problem in your drivers, and/or your memory controller. Especially the memory controller. -hpa --

asm-generic/errno-base.h:#define EFAULT 14 /* Bad address */ --

This is reproduceable and it happens every time. IMHO, I also suspect this could be caused by some obscure timing issues, as the kernel is booting up from an FPGA-prototyped SoC, the same Linux image was running fine on a previous build of FPGA-prototyped SoC, but it's coming across this /init failed problem repeatedly on the currently running newly built bit file. --

Here is the terminal printout from the correct bootup on a previous build. <6>Freeing init memory: 584K Freeing init memory: 584K init started: BusyBox v0.60.5 (2006.06.15-11:12+0000) multi-call binary Bummer, could not run '/etc/init.d/rcS': No such file or directory ÿ Please press Enter to activate this console. It looks that it's printing out several ÿ first and then replaced them with "init started: BusyBox..." seems quite obscure, as the only difference between those two FPGA builds ...

Hi, my kernel 2.6.23.1 oopsed today in diskstats_show(), leaving the block_subsys_lock mutex locked. I have an Athlon 64 X2 (dual-core), architecture x86_64. I have not tried with 2.6.24 yet, but it looks like there was no relevant change in 2.6.24. Right before the crash, I was torturing cryptsetup to experiment with encryption - I created and deleted device mapper objects in a loop. The NULL dereference happened inside "disk_stat_read(gp, time_in_queue)", because the percpu pointer ...

I think it is reasonable to implement it as the generic system call, as you said. Does XFS folks think so? Cheers, Takashi --

thanks Andreas, applied! Ingo --

Hi, I am experiencing unpredictable results with the following test without other processes running (exception is udev, I believe): cd /usr/src/test tar -jxf ../linux-2.6.22.12 cp ../working-config linux-2.6.22.12/.config cd linux-2.6.22.12 make oldconfig time make -j3 > /dev/null # This is what I note down as a "test" result cd /usr/src ; umount /usr/src/test ; mkfs.ext3 /dev/cc/test and then reboot The kernel is booted with the parameter mem=81920000 For 2.6.23.14 the results vary ...

I'm going to run some tests without limiting the memory to 80 megabytes (so that it is 2 gigabyte) and see how much it varies then, but iff I recall correctly it did not vary much. I'll reply to this e-mail with the results. I can do some bisecting next week and see if I find any, but it will probably take a lot of time considering that I need to do enough runs.. how much should this vary anyways? The kernel is compiled as an UP kernel and there is nothing running in parallel with it.. it ...

First off, not all tests are good tests. In particular, small timing differences can get magnified horrendously by heading into swap. That said, do you have the means and standard deviations of those runs? That's a good way to tell whether the tests are converging or not, and whether your results are telling you anything. Also as you're on a uniprocessor system, make -j2 is probably going to be faster than make -j3. Perhaps immaterial to whatever you're trying to test, but there you go. --

Yes, but it requires that the filesystem be stored under LVM. Unlike what EVMS v1 allowed us to do, we can't currently take a snapshot of a bare block device. This patch could potentially be useful for systems That's the problem. You can't afford to freeze for very long. What you *could* do is to start putting processes to sleep if they attempt to write to the frozen filesystem, and then detect the deadlock case where the process holding the file descriptor used to freeze the filesystem ...

Hi, Currently, ext3 doesn't have the freeze feature which suspends write requests. So, we cannot get a backup which keeps the filesystem's consistency with the storage device's features (snapshot, replication) while it is mounted. In many case, a commercial filesystems (e.g. VxFS) has the freeze feature and it would be used to get the consistent backup. So I am planning on implementing the ioctl of the freeze feature for ext3. I think we can get the consistent backup with the following ...

I am also wondering whether we should have system call(s) for these: And just convert XFS to use them too? Pekka --

Hi, I've dropped out a couple of the patches related to journaling. Those will now do an extra round of my git tree and will likely be merged next time. Other than that, the patches in the GFS2 -nme git tree are exactly as recently posted. Please consider pulling the following changes, Steve. --------------------------------------------------------------------------------- The following changes since commit 49914084e797530d9baaf51df9eda77babc98fa8: Linus Torvalds (1): Linux ...

Tim, Please consider the included patch to fix a 1-bit bug in the software emulation of parport epp addr read mode. I am not subscribed to the LKML. Thanks Stephan --- linux-2.6.24-rc6/drivers/parport/ieee1284_ops.c~ 2007-10-09 22:31:38.000000000 +0200 +++ linux-2.6.24-rc6/drivers/parport/ieee1284_ops.c 2008-01-24 22:15:05.000000000 +0100 @@ -888,7 +888,7 @@ /* Event 59: set nSelectIn (nAStrb) high */ parport_frob_control (port, PARPORT_CONTROL_SELECT, - ...

thanks, i have applied your fix to x86.git. It seems this does not need to be backported to v2.6.24.1 because node_to_pxm() masked the bad effects of this bug, right? Ingo --

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Matt Domsch <Matt_Domsch@dell.com> Cc: Matt Tolentino <matthew.e.tolentino@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/firmware/efivars.c | 22 ++++++++++------------ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 018ca1c..e17cd81 100644 --- a/drivers/firmware/efivars.c +++ ...

Dynamically create the kset instead of declaring it statically. This makes the kobject attributes now work properly that I broke in the previous patch. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Michael Holzheu <holzheu@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Volker Sameske <sameske@de.ibm.com> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- arch/s390/kernel/ipl.c | 73 ...

If you want to keep them, add it to the patch description; that way they will be retained in "git log" without expanding the size of the .c file. :) --

This macro is no longer used. ksets should be created dynamically with a call to kset_create_and_add() not declared statically. Yes, there are 5 remaining static struct kset usages in the kernel tree, but they will be fixed up soon. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/class.c | 11 +++++++++-- include/linux/kobject.h | 6 ------ 2 files changed, 9 insertions(+), 8 deletions(-) diff --git ...

From: Dave Young <hidave.darkstar@gmail.com> Convert to use the class iteration api. Signed-off-by: Dave Young <hidave.darkstar@gmail.com> Cc: Alessandro Zummo <a.zummo@towertech.it> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/rtc/interface.c | 22 ++++++++++++---------- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index f1e00ff..7e3ad4f 100644 --- a/drivers/rtc/interface.c +++ ...

The old kobject_add() function is on longer in use, so let us remove it from the public scope (kset mess in the kobject.c file still uses it, but that can be cleaned up later very simply.) Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/kobject.h | 1 - lib/kobject.c | 22 ++++++++-------------- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/include/linux/kobject.h b/include/linux/kobject.h index ...

Thanks Linus. I'll pass this on to the mkinitrd maintainer. We'll try to get this sorted out for you :) Jon. --

Using a kset for this trivial directory is an overkill. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Mike Halcrow <mhalcrow@us.ibm.com> Cc: Phillip Hellewell <phillip@hellewell.homeip.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/ecryptfs/main.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c index d984eac..4f13321 100644 --- a/fs/ecryptfs/main.c +++ b/fs/ecryptfs/main.c @@ -734,7 +734,7 @@ ...

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/bus.c | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 6309560..e3b1010 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -166,7 +166,7 @@ static struct kset_uevent_ops bus_uevent_ops = { .filter = bus_uevent_filter, }; ...

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Steven Whitehouse <swhiteho@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/gfs2/sys.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index a0bdc4a..44cfaae 100644 --- a/fs/gfs2/sys.c +++ b/fs/gfs2/sys.c @@ -221,7 +221,7 @@ static struct kobj_type gfs2_ktype = { .sysfs_ops = ...

From: Li Yang <leo@zh-kernel.org> Signed-off-by: Li Yang <leo@zh-kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Documentation/zh_CN/SubmittingDrivers | 168 +++++++++++++++++++++++++++++++++ 1 files changed, 168 insertions(+), 0 deletions(-) create mode 100644 Documentation/zh_CN/SubmittingDrivers diff --git a/Documentation/zh_CN/SubmittingDrivers b/Documentation/zh_CN/SubmittingDrivers new file mode 100644 index 0000000..5f4815c --- /dev/null +++ ...

From: TripleX Chung <triplex@zh-kernel.org> Signed-off-by: TripleX Chung <triplex@zh-kernel.org> Signed-off-by: Li Yang <leo@zh-kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Documentation/zh_CN/SubmittingPatches | 416 +++++++++++++++++++++++++++++++++ 1 files changed, 416 insertions(+), 0 deletions(-) create mode 100644 Documentation/zh_CN/SubmittingPatches diff --git a/Documentation/zh_CN/SubmittingPatches b/Documentation/zh_CN/SubmittingPatches new file mode ...

Acked-by: Christoph Lameter <clameter@sgi.com> --

From: Dave Young <hidave.darkstar@gmail.com> Signed-off-by: Dave Young <hidave.darkstar@gmail.com> Signed-off-by: Li Yang <leo@zh-kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Documentation/zh_CN/oops-tracing.txt | 212 ++++++++++++++++++++++++++++++++++ 1 files changed, 212 insertions(+), 0 deletions(-) create mode 100644 Documentation/zh_CN/oops-tracing.txt diff --git a/Documentation/zh_CN/oops-tracing.txt b/Documentation/zh_CN/oops-tracing.txt new file mode ...

This isn't used by anything in the driver core, and by no one in the 204 different usages of it in the kernel tree. Remove this field so no one gets any idea that it is needed to be used. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/device.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/linux/device.h b/include/linux/device.h index a3b3ff1..313e0b3 100644 --- a/include/linux/device.h +++ ...

The old kobject_init() function is on longer in use, so let us remove it from the public scope (kset mess in the kobject.c file still uses it, but that can be cleaned up later very simply.) Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/kobject.h | 1 - lib/kobject.c | 11 +++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/include/linux/kobject.h b/include/linux/kobject.h index ...

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Matt Domsch <Matt_Domsch@dell.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/firmware/edd.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index fc567fa..f07f370 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -631,7 +631,7 @@ static struct kobj_type ...

No one except the kobject core calls it so make the function static. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/kobject.h | 2 -- lib/kobject.c | 9 ++++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/linux/kobject.h b/include/linux/kobject.h index 4a0d27f..2d19a07 100644 --- a/include/linux/kobject.h +++ b/include/linux/kobject.h @@ -79,8 +79,6 @@ static inline const char * kobject_name(const struct kobject * kobj) ...

Now that kobjects properly clean up their name structures, no matter if they have a release function or not, we can drop this empty module kobject release function too (it was needed prior to this because of the way we handled static kobject names, we based the fact that if a release function was present, then we could safely free the name string, now we are more smart about things and only free names we have previously set.) Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg ...

This lets users create dynamic kobjects much easier. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/kobject.h | 3 ++ lib/kobject.c | 81 ++++++++++++++++++++++++++++++++++++---------- 2 files changed, 66 insertions(+), 18 deletions(-) diff --git a/include/linux/kobject.h b/include/linux/kobject.h index f91aeb7..33e7a61 100644 --- a/include/linux/kobject.h +++ b/include/linux/kobject.h @@ -91,6 +91,9 @@ extern ...

We don't need a kset here, a simple kobject will do just fine, so dynamically create the kobject and use it. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Joel Becker <joel.becker@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/configfs/mount.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/configfs/mount.c b/fs/configfs/mount.c index 374ddbd..1330046 100644 --- a/fs/configfs/mount.c +++ b/fs/configfs/mount.c @@ ...

At this point in the object's lifetime, it is the same exact thing. So both are correct :) thanks, greg k-h --

Cool, well ignore my objection then... Jeff --

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Steven Whitehouse <swhiteho@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/gfs2/locking/dlm/sysfs.c | 22 ++++++++++------------ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/fs/gfs2/locking/dlm/sysfs.c b/fs/gfs2/locking/dlm/sysfs.c index 93e66b2..0a86140 100644 --- a/fs/gfs2/locking/dlm/sysfs.c +++ b/fs/gfs2/locking/dlm/sysfs.c @@ -189,7 ...

From: Tony Jones <tonyj@suse.de> struct class_device is going away, this converts the code to use struct device instead. Signed-off-by: Tony Jones <tonyj@suse.de> Cc: Tim Waugh <tim@cyberelk.net> Cc: Jens Axboe <axboe@kernel.dk> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/block/paride/pg.c | 6 +++--- drivers/block/paride/pt.c | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git ...

We don't need a kset here, a simple kobject will do just fine, so dynamically create the kobject and use it. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/debugfs/inode.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index f7f1351..6672142 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -426,20 +426,19 @@ exit: } ...

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Steven Whitehouse <swhiteho@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/dlm/lockspace.c | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index 18e4a17..83a9c4d 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c @@ -166,7 +166,7 @@ static struct kobj_type dlm_ktype = { ...

From: Alan Stern <stern@rowland.harvard.edu> This patch (as1015) reverts changes that were made to the driver core about four years ago. The intent back then was to avoid certain kinds of invalid memory accesses by leaving kernel objects allocated as long as any of their children were still allocated. The original and correct approach was to wait only as long as any children were still _registered_; that's what this patch reinstates. This fixes a problem in the SCSI core made visible by the ...

Needed for future firmware subsystem cleanups. In the end, the firmware_register/unregister functions will be deleted entirely, but we need this symbol so that subsystems can migrate over. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Matt Domsch <Matt_Domsch@dell.com> Cc: Matt Tolentino <matthew.e.tolentino@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/firmware.c | 3 ++- include/linux/kobject.h | 2 ++ 2 files changed, 4 insertions(+), 1 ...

This converts the code to use the new kobject functions, cleaning up the logic in doing so. Cc: Jens Axboe <axboe@kernel.dk> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- block/elevator.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index e452deb..5445c3c 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -185,9 +185,7 @@ static elevator_t *elevator_alloc(struct ...

This converts the code to use the new kobject functions, cleaning up the logic in doing so. Cc: Christoph Lameter <clameter@sgi.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- mm/slub.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index d26177f..5cc4b7d 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4025,13 +4025,12 @@ static int sysfs_slab_add(struct kmem_cache *s) name = ...

From: Stephen Rothwell <sfr@canb.auug.org.au> This name is just passed to platform_device_alloc which has its parameter declared const. Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/platform.c | 2 +- include/linux/platform_device.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index bdd59e8..48d5db4 100644 --- ...

No one is calling this anymore, so just remove it and hard-code the one internal-use of it. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/kobject.h | 1 - lib/kobject.c | 13 +------------ 2 files changed, 1 insertions(+), 13 deletions(-) diff --git a/include/linux/kobject.h b/include/linux/kobject.h index 2590847..63967da 100644 --- a/include/linux/kobject.h +++ b/include/linux/kobject.h @@ -158,7 +158,6 @@ ...

Dynamically create the kset instead of declaring it statically. We also rename power_subsys to power_kset to catch all users of the variable and we properly export it so that people don't have to guess that it really is present in the system. The pseries code is wierd, why is it createing /sys/power if CONFIG_PM is disabled? Oh well, stupid big boxes ignoring config options... Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- ...

Don't try to call the "raw" sysfs_create_file when we already have a helper function to do this kind of work for us. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/usb/core/driver.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index c51f8e9..7c3aaa9 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -91,8 +91,8 @@ static int usb_create_newid_file(struct usb_driver ...

Right. I assumed that Linus was calling mkinitrd but was being bitten by one of the occasional assumptions (I believe we make in that script) that certain things are always modular. I just mailed the maintainer, suggesting we screen against the one of the Modules.* files (perhaps Modules.order might become a good candidate in due course...). Jon. --

/sys/kernel is where these things should go. Also updated the documentation and tool that used this directory. Cc: Kay Sievers <kay.sievers@vrfy.org> Acked-by: Christoph Lameter <clameter@sgi.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Documentation/vm/slabinfo.c | 2 +- Documentation/vm/slub.txt | 2 +- mm/slub.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/vm/slabinfo.c ...

Dynamically create the kset instead of declaring it statically. We also rename devices_subsys to devices_kset to catch all users of the variable. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/base.h | 2 +- drivers/base/core.c | 16 ++++++++-------- drivers/base/power/shutdown.c | 2 +- drivers/base/sys.c | 4 +--- 4 files changed, 11 insertions(+), 13 deletions(-) diff --git ...

From: Cornelia Huck <cornelia.huck@de.ibm.com> Make setup_parent() void as get_device_parent() will always return either a valid kobject or NULL. Introduce cleanup_glue_dir() to drop reference grabbed on "glue" directory by get_device_parent(). Use it for cleanup in device_move() and device_add() on errors. This should fix the refcounting problem reported in http://marc.info/?l=linux-kernel&m=120052487909200&w=2 Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Cc: Dave Young ...

From: Cornelia Huck <cornelia.huck@de.ibm.com> This is lot like default attributes for devices (and indeed, a lot of the code is lifted from there). Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/driver.c | 42 +++++++++++++++++++++++++++++++++++++++++- include/linux/device.h | 1 + 2 files changed, 42 insertions(+), 1 deletions(-) diff --git a/drivers/base/driver.c b/drivers/base/driver.c index ...

Due to the low level nature of these patches, and because they touch so many different parts of the kernel, a number of the subsystem maintainers have asked me to get them in first to make merging other trees easier. Here are a pretty large number of kobject, documentation, and driver core patches against your 2.6.24 git tree. They can be broken down into these major areas: - Documentation updates (language translations and fixes, as well as kobject and kset documenatation updates.) - ...

Stop using kobject_register, as this way we can control the sending of the uevent properly, after everything is properly initialized. Cc: Dave Larson <larson1@us.ibm.com> Cc: Santiago Leon <santil@us.ibm.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/net/ibmveth.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 7d7758f..bee3037 100644 --- ...

Sorry, I've been a bit laid up with illness to pull out any upstreamable pieces. Attached is the original version I sent to you that still has the Ingo-specific need_config file. Hopefully I'll be back in action and can finish this soon. This is functionally equivalent to Ingo's patch at: http://people.redhat.com/mingo/auto-qa-patches/Kconfig-qa.patch Instead, create a need_config file and invoke randconfig as: make randconfig KCONFIG_ALLCONFIG=need_config Signed-off-by: Harvey ...

Ok, I'll queue it up myself in my trees and send it to you in a few days. Have a nice trip, greg k-h --

From: Frank Seidel <fseidel@suse.de> Minor cleanups and removal of in-file changelog: - Correction of misspellings and wrong encoded Name - changed 'unsigned' to 'unsigned int' for better readability - use of generic devicefile access macro - fixed/added explanatory comment to ntty_put_char Signed-off-by: Frank Seidel <fseidel@suse.de> --- drivers/char/nozomi.c | 122 ++++++++++++++------------------------------------ 1 file changed, 36 insertions(+), 86 deletions(-) --- ...

From: TripleX Chung <triplex@zh-kernel.org> Signed-off-by: TripleX Chung <triplex@zh-kernel.org> Signed-off-by: Li Yang <leo@zh-kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Documentation/zh_CN/SubmittingPatches | 416 +++++++++++++++++++++++++++++++++ 1 files changed, 416 insertions(+), 0 deletions(-) create mode 100644 Documentation/zh_CN/SubmittingPatches diff --git a/Documentation/zh_CN/SubmittingPatches b/Documentation/zh_CN/SubmittingPatches new file mode ...

By all means - if you have text that explains the who/what/why of the patch, put it in the patch description, so that 6 months later idiots like me have a fighting chance of figuring out whether the patch incorrectly implements the right idea, or if it correctly implements the wrong idea. ;)

These files should not be "normal" sysfs files as they really are binary ones. This patch makes them binary files and saves code in doing so. Cc: Kay Sievers <kay.sievers@vrfy.org> Tested-by: Matt Domsch <Matt_Domsch@dell.com> Cc: Matt Tolentino <matthew.e.tolentino@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/firmware/efivars.c | 51 +++++++++++++++++++------------------------ 1 files changed, 23 insertions(+), 28 deletions(-) diff --git ...

The PCI bus should not be trying to declare its own attribute type. Especially as this code could never ever be called because the driver core overwrites the driver kobject type to be its own internal type. Delete all of this code as it was never being used and is not correct. Also update my copyright on the file while I'm touching things there. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/pci/pci-driver.c | 50 ++++----------------------------------------- 1 files ...

I've merged it all, but it causes lots of scary warnings: - from the purely broken ones: ehci_hcd: no version for "struct_module" found: kernel tainted. - to the scary ones: sysfs: duplicate filename 'ehci_hcd' can not be created WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Pid: 610, comm: insmod Tainted: GF 2.6.24-gb47711bf #28 Call Trace: [<ffffffff802bd63c>] sysfs_add_one+0x54/0xbd [<ffffffff802bdbc0>] create_dir+0x4f/0x87 [<ffffffff802bdc2d>] ...

Dynamically create the kset instead of declaring it statically. We also rename kernel_subsys to kernel_kset to catch all users of this symbol with a build error instead of an easy-to-ignore build warning. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/configfs/mount.c | 2 +- fs/debugfs/inode.c | 2 +- fs/dlm/lockspace.c | 2 +- fs/gfs2/locking/dlm/sysfs.c | 3 +-- include/linux/kobject.h | 4 ...

The module driver specific code should belong in the driver core, not in the kernel/ directory. So move this code. This is done in preparation for some struct device_driver rework that should be confined to the driver core code only. This also lets us keep from exporting these functions, as no external code should ever be calling it. Thanks to Andrew Morton for the !CONFIG_MODULES fix. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/Makefile | 1 + ...

Using a kset for this simple directory is an overkill. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Thibaut VARENE <varenet@parisc-linux.org> Cc: Matthew Wilcox <matthew@wil.cx> Cc: Grant Grundler <grundler@parisc-linux.org> Cc: Kyle McMartin <kyle@parisc-linux.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/parisc/pdc_stable.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/parisc/pdc_stable.c ...

From: Randy Dunlap <randy.dunlap@oracle.com> Make SYSFS_DEPRECATED depend on SYSFS since files that check CONFIG_SYSFS_DEPRECATED don't check for CONFIG_SYSFS first. Also don't prompt user about SYSFS_DEPRECATED if SYSFS=n. Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- init/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index b9d11a8..f5becd2 100644 --- ...

From: Kay Sievers <kay.sievers@vrfy.org> All kobjects require a dynamically allocated name now. We no longer need to keep track if the name is statically assigned, we can just unconditionally free() all kobject names on cleanup. Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- arch/arm/kernel/time.c | 4 ++-- arch/arm/mach-integrator/integrator_ap.c | 2 +- arch/arm/mach-pxa/cm-x270.c | 2 +- ...

From: Dave Young <hidave.darkstar@gmail.com> Convert to use the class iteration api. Signed-off-by: Dave Young <hidave.darkstar@gmail.com> Cc: Anton Vorontsov <cbou@mail.ru> Cc: David Woodhouse <dwmw2@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/power/apm_power.c | 116 +++++++++++++++++++++--------------- drivers/power/power_supply_core.c | 74 ++++++++++++----------- 2 files changed, 107 insertions(+), 83 deletions(-) diff --git ...

As we are replacing the documentation, it's easier to do this in a two stage pass, delete the old file and add the new one. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Documentation/kobject.txt | 289 --------------------------------------------- 1 files changed, 0 insertions(+), 289 deletions(-) delete mode 100644 Documentation/kobject.txt diff --git a/Documentation/kobject.txt b/Documentation/kobject.txt deleted file mode 100644 index ...

Kay pointed out that kobject_set_name was being very stupid, doing two allocations for every call, when it should just be using the kernel function kvasprintf() instead. This change adds the internal kobject_set_name_vargs() function, which other follow-on patches will be using. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- lib/kobject.c | 71 +++++++++++++++++++++++++------------------------------- 1 files changed, 32 insertions(+), 39 ...

From: Denis Cheng <crquan@gmail.com> LIST_HEAD has been widely used, so switch to this simpler method. Signed-off-by: Denis Cheng <crquan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/attribute_container.c | 9 +-------- drivers/base/base.h | 1 - drivers/base/init.c | 1 - 3 files changed, 1 insertions(+), 10 deletions(-) diff --git a/drivers/base/attribute_container.c b/drivers/base/attribute_container.c index ...

The distro mkinird can reconstruct it containing your freshly built modules (if any) and any other distro goo which needs to go in there. /initrd-2.6.23.14-107.fc8.img doesn't come out of an rpm; its built by an installer script when you install the kernel, and you can run the same script on your kernels. Does you use "make modules_install install" when you build the kernel? It just does the right thing for me under F8, including rebuilding initrd and updating grub.conf. J --

Stop using kobject_register, as this way we can control the sending of the uevent properly, after everything is properly initialized. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/bus.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 937fc10..aea5793 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -643,15 +643,12 @@ int ...

This provides a much-needed kobject and kset documentation update. Thanks to Kay Sievers, Alan Stern, Jonathan Corbet, Randy Dunlap, Jan Engelhardt, and others for reviewing and providing help with this document. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Documentation/kobject.txt | 386 +++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 386 insertions(+), 0 deletions(-) create mode 100644 Documentation/kobject.txt diff ...

This allows an easier way to get to the device klist associated with a struct bus_type (you have three to choose from...) This will make it easier to move these fields to be dynamic in a future patch. The only user of this is the PCI core which horribly abuses this interface to rearrange the order of the pci devices. This should be done using the existing bus device walking functions, but that's left for future patches. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg ...

My wish is that distros would just boot without requiring an initrd. I know how to make them for redhat and debian based distros, but the fact that you can't (easily) cross-build them makes it a very tedious construct. I can butcher the distros into booting and ignore the errors on bootup that whine that modules are missing, but really. --

kobject_create_and_add is the same as kobject_add_dir, so drop kobject_add_dir. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/core.c | 3 ++- fs/partitions/check.c | 6 +++--- include/linux/kobject.h | 1 - kernel/module.c | 6 +++--- lib/kobject.c | 12 ------------ 5 files changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index ...

The kobject in the bridge code is only used for registering with sysfs, not for any lifespan rules. This patch changes it to be only a pointer and use the simpler api for this kind of thing. Cc: Stephen Hemminger <shemminger@linux-foundation.org> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- net/bridge/br_if.c | 2 +- net/bridge/br_private.h | 2 +- net/bridge/br_sysfs_br.c | 14 ++++---------- net/bridge/br_sysfs_if.c | 2 ...

This converts the code to use the new kobject functions, cleaning up the logic in doing so. Cc: Neil Brown <neilb@suse.de> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/md/md.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index f79efb3..7ae9740 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -1383,16 +1383,13 @@ static int bind_rdev_to_array(mdk_rdev_t * ...

That's really wierd, I don't see that at all here just running with your 2.6.24 + my git tree and lots of USB drivers built into the kernel also (like ehci_hcd). $ cat /proc/sys/kernel/tainted 0 Odd... $ uname -r 2.6.24-ge374a2bf-dirty Strange, I thought that the uname id would show the git version that you were running, but that doesn't show a valid id. But that's probably a different issue in the build system somewhere... thanks, greg k-h --

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Matt Domsch <Matt_Domsch@dell.com> Cc: Matt Tolentino <matthew.e.tolentino@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/firmware/efivars.c | 22 ++++++++++------------ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 018ca1c..e17cd81 100644 --- a/drivers/firmware/efivars.c +++ ...

We don't need a "default" ktype for a kset. We should set this explicitly every time for each kset. This change is needed so that we can make ksets dynamic, and cleans up one of the odd, undocumented assumption that the kset/kobject/ktype model has. This patch is based on a lot of help from Kay Sievers. Nasty bug in the block code was found by Dave Young <hidave.darkstar@gmail.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Dave Young <hidave.darkstar@gmail.com> Signed-off-by: Greg ...

This makes the code a bit simpler and and gets us one step closer to deleting the deprecated subsys_attr code. NOTE, this needs the next patch in the series in order to work properly. This will build, but the sysfs files will not properly operate. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Thibaut VARENE <varenet@parisc-linux.org> Cc: Matthew Wilcox <matthew@wil.cx> Cc: Grant Grundler <grundler@parisc-linux.org> Cc: Kyle McMartin <kyle@parisc-linux.org> Signed-off-by: Greg Kroah-Hartman ...

We don't need a kset here, a simple kobject will do just fine, so dynamically create the kobject and use it. Thanks to Cornelia for the build fix. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Michael Holzheu <holzheu@de.ibm.com> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- arch/s390/hypfs/inode.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c index ...

From: Robert P. J. Day <rpjday@crashcourse.ca> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> --- Documentation/pnp.txt | 4 ++-- Documentation/s390/cds.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/pnp.txt b/Documentation/pnp.txt index 481faf5..a327db6 100644 --- a/Documentation/pnp.txt +++ b/Documentation/pnp.txt @@ -17,9 +17,9 @@ The User Interface ------------------ The Linux Plug and Play user interface provides a ...

As pointed out by Kay. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- lib/kobject.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index 3590f02..9500339 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -334,8 +334,6 @@ int kobject_rename(struct kobject * kobj, const char *new_name) sprintf(devpath_string, "DEVPATH_OLD=%s", devpath); envp[0] = devpath_string; envp[1] = ...

Don't try to call the "raw" sysfs_create_file when we already have a helper function to do this kind of work for us. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/pci/pci-driver.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 6d1a216..73e3629 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -96,17 +96,21 @@ pci_create_newid_file(struct pci_driver *drv) { ...

This patch removes the kobject, and a few other driver-core-only fields out of struct driver and into the driver core only. Now drivers can be safely create on the stack or statically (like they currently are.) Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/base.h | 8 +++++ drivers/base/bus.c | 71 +++++++++++++++++++++++++--------------------- drivers/base/dd.c | 24 ++++++++-------- drivers/base/driver.c ...

From: Kay Sievers <kay.sievers@vrfy.org> We save the current state in the object itself, so we can do proper cleanup when the last reference is dropped. If the initial reference is dropped, the object will be removed from sysfs if needed, if an "add" event was sent, "remove" will be send, and the allocated resources are released. This allows us to clean up some driver core usage as well as allowing us to do other such changes to the rest of the kernel. Signed-off-by: Kay Sievers ...

Ok, in looking at the code, this should also be showing up for you on a "clean" 2.6.24 release, I didn't change anything in this code path. This is the sysfs core telling you that someone did something stupid :) Yes, that's new, but the "error" was always there, I just made the warning more visible to get people to pay attention to it, and find the real errors where this happens (and it has found them, which is a good thing.) But in this case, it doesn't look like the module loading ...

Acked-by: Mark Fasheh <mark.fasheh@oracle.com> -- Mark Fasheh Principal Software Developer, Oracle mark.fasheh@oracle.com --

--

From: Rafael J. Wysocki <rjw@sisk.pl> This patch reorganizes the way suspend and resume notifications are sent to drivers. The major changes are that now the PM core acquires every device semaphore before calling the methods, and calls to device_add() during suspends will fail, while calls to device_del() during suspends will block. It also provides a way to safely remove a suspended device with the help of the PM core, by using the device_pm_schedule_removal() callback introduced ...

Stop using kobject_register, as this way we can control the sending of the uevent properly, after everything is properly initialized. Cc: Roland Dreier <rolandd@cisco.com> Cc: Sean Hefty <mshefty@ichips.intel.com> Cc: Hal Rosenstock <hal.rosenstock@gmail.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/infiniband/core/sysfs.c | 35 +++++++++-------------------------- include/rdma/ib_verbs.h | 2 +- 2 files changed, 10 ...

--

These functions are no longer called or needed, so we can remove them. As I rewrote the whole firmware.c file, add my copyright. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/firmware.c | 19 ++----------------- include/linux/device.h | 5 ----- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/drivers/base/firmware.c b/drivers/base/firmware.c index c7f635b..9efff48 100644 --- a/drivers/base/firmware.c +++ ...

device_shutdown does not need to be in a separate file. Move it into the driver core file where it belongs. This also moves us one more step closer to making devices_kset static, now only the crazy sysdevs are keeping that from happening... Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/core.c | 20 ++++++++++++++++++- drivers/base/power/Makefile | 1 - drivers/base/power/shutdown.c | 43 ----------------------------------------- 3 files changed, 19 ...

Dynamically create the kset instead of declaring it statically. We also rename module_subsys to module_kset to catch all users of the variable. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/module.h | 4 +++- kernel/module.c | 7 +++---- kernel/params.c | 29 +++++++++-------------------- 3 files changed, 15 insertions(+), 25 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index ...

From: Frank Seidel <fseidel@suse.de> This is a driver to control the cardbus wireless data card that works on 3g networks. Greg Kroah-Hartman <gregkh@suse.de> did the initial driver cleanup. Thanks to Arnaud Patard <apatard@mandriva.com> for help with bugfixing. Thanks to Alan Cox for a lot of tty fixes. Thanks to Satyam Sharma <satyam@infradead.org> for fixing buildbreakage. Thanks to Frank Seidel <fseidel@suse.de> for a lot of bugfixes and rewriting to make it a sane Linux driver Thanks ...

Cannot see anything wrong (but then sysfs is mainly a mystery to me) Acked-by: Christoph Lameter <clameter@sgi.com> --

From: Tony Jones <tonyj@suse.de> Signed-off-by: Tony Jones <tonyj@suse.de> Cc: Jens Axboe <axboe@kernel.dk> Cc: Sam Hopkins <sah@coraid.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/block/aoe/aoechr.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c index 39e563e..d5480e3 100644 --- a/drivers/block/aoe/aoechr.c +++ ...

On Thu, 24 Jan 2008 23:32:45 -0800 This is fine, no issues. -- Stephen Hemminger <stephen.hemminger@vyatta.com> --

The IBM asm driver is using a kobject only for reference counting, nothing else. So switch it to use a kref instead, which is all that is needed, and is much smaller. Cc: Max Asböck <amax@us.ibm.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/misc/ibmasm/command.c | 12 +++--------- drivers/misc/ibmasm/ibmasm.h | 10 ++++++---- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/misc/ibmasm/command.c ...

From: Zhang Le <r0bertz@gentoo.org> Signed-off-by: Zhang Le <r0bertz@gentoo.org> Signed-off-by: Li Yang <leo@zh-kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Documentation/zh_CN/CodingStyle | 701 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 701 insertions(+), 0 deletions(-) create mode 100644 Documentation/zh_CN/CodingStyle diff --git a/Documentation/zh_CN/CodingStyle b/Documentation/zh_CN/CodingStyle new file mode 100644 index 0000000..ecd9307 --- ...

Stop using kobject_register, as this way we can control the sending of the uevent properly, after everything is properly initialized. Acked-by: Doug Thompson <dougthompson@xmission.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/edac/edac_device_sysfs.c | 39 +++++++++++-------------------------- drivers/edac/edac_mc_sysfs.c | 28 ++++++++------------------ drivers/edac/edac_pci_sysfs.c | 29 +++++++-------------------- ...

This code is really really really broken. So much so that it's almost impossible to fix with a simple patch, so just comment out the offending registration with the kobject core, and mark the driver as broken. The problem is that the code is trying to register a "raw" struct device, which is not allowed. struct device is only for use within the driver model. This is being done to try to use the firmware layer which wants a struct device. To properly fix this, use something easy, like ...

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Matt Domsch <Matt_Domsch@dell.com> Cc: Matt Tolentino <matthew.e.tolentino@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/firmware/efivars.c | 19 +++++++++---------- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index ebc3853..018ca1c 100644 --- a/drivers/firmware/efivars.c +++ ...

From: Jan Engelhardt <jengelh@computergmbh.de> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/uio/uio.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index 03b66fb..cc246fa 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -39,7 +39,7 @@ struct uio_device { static int uio_major; static DEFINE_IDR(uio_idr); -static struct file_operations ...

Stop using kobject_register, as this way we can control the sending of the uevent properly, after everything is properly initialized. Cc: Steven Whitehouse <swhiteho@redhat.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/dlm/lockspace.c | 26 ++++---------------------- fs/gfs2/locking/dlm/sysfs.c | 13 +++---------- fs/gfs2/sys.c | 10 +++------- 3 files changed, 10 insertions(+), 39 deletions(-) diff --git ...

There is no need for kobject_unregister() anymore, thanks to Kay's kobject cleanup changes, so replace all instances of it with kobject_put(). Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/bus.c | 4 ++-- drivers/base/sys.c | 2 +- drivers/block/pktcdvd.c | 2 +- drivers/cpufreq/cpufreq.c | 4 +--- drivers/cpuidle/sysfs.c | 4 ++-- ...

rpadlpar pci hotplug driver was doing some pretty bad stuff with the sysfs files. This cleans up the logic to be sane and gets rid of the gratuitous kset that is not needed for a simple directory like this. Note, this patch is not even build tested, let alone run-time tested. Someone with access to this hardware and can test would be greatly appreciated. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: John Rose <johnrose@austin.ibm.com> Cc: Badari Pulavarty <pbadari@gmail.com> Cc: Kamalesh ...

Clean up the kobject.c and kobject_uevent.c files to follow the proper coding style rules. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- lib/kobject.c | 139 +++++++++++++++++++++++--------------------------- lib/kobject_uevent.c | 7 +-- 2 files changed, 67 insertions(+), 79 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index 8dc3245..1d63ead 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -18,58 +18,57 @@ #include <linux/stat.h> #include ...

From: Dave Young <hidave.darkstar@gmail.com> Add the following class iteration functions for driver use: class_for_each_device class_find_device class_for_each_child class_find_child Signed-off-by: Dave Young <hidave.darkstar@gmail.com> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/class.c | 133 ++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/device.h | 9 +++- 2 files changed, 140 ...

This converts the code to use the new kobject functions, cleaning up the logic in doing so. Cc: Stephen Hemminger <shemminger@linux-foundation.org> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- net/bridge/br_if.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index dadec94..298e0f4 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -258,12 +258,6 @@ static ...

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/sys.c | 27 +++++++++++---------------- 1 files changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/base/sys.c b/drivers/base/sys.c index 7693c95..29eadc6 100644 --- a/drivers/base/sys.c +++ b/drivers/base/sys.c @@ -126,19 +126,16 @@ void sysdev_class_remove_file(struct sysdev_class *c, } ...

This makes the code a bit simpler and and gets us one step closer to deleting the deprecated subsys_attr code. NOTE, this needs the next patch in the series in order to work properly. This will build, but the sysfs files will not properly operate. Thanks to Cornelia for the build fix on this patch. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Michael Holzheu <holzheu@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Volker Sameske <sameske@de.ibm.com> Cc: Cornelia Huck ...

that "slim" combination is what i use for about 25% of all my bisections - i build, boot and stress-test randconfig configs. If i find a problem with a given .config, i do _not_ go around and change the .config to make a bisection point work. (and the automated bisection scripts definitely wont do it either.) so what is a 'weird config' to you is a real testing barrier for others. And crap like that quickly mounts up. Having a buildable and bootable kernel at every bisection point is ...

From: Randy Dunlap <randy.dunlap@oracle.com> When SYSFS=n and MODULES=y, build ends with: linux-2.6.24-rc6-mm1/drivers/base/module.c: In function 'module_add_driver': linux-2.6.24-rc6-mm1/drivers/base/module.c:49: error: 'module_kset' undeclared (first use in this function) make[3]: *** [drivers/base/module.o] Error 1 Below is one possible fix. Build-tested with all 4 config combinations of SYSFS & MODULES. Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Greg ...

For most of these issues I do merge them together. However, for some odd kernel configurations, like this one, I didn't, my The odds that a "normal" person has sysfs turned off and modules enabled, trying to bisect things, is pretty slim :) thanks, greg k-h --

Ah, now I get it, sorry, I'll go check that error path, not exactly a normal one :) thanks, greg k-h --

From: Cornelia Huck <cornelia.huck@de.ibm.com> CC: Ursula Braun <ubraun@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/s390/net/netiucv.c | 16 ++++++---------- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/s390/net/netiucv.c b/drivers/s390/net/netiucv.c index c7ea938..d6e93f1 100644 --- a/drivers/s390/net/netiucv.c +++ b/drivers/s390/net/netiucv.c @@ -2089,6 +2089,11 @@ ...

Now ksets can be dynamically created on the fly, no static definitions are required. Thanks to Miklos for hints on how to make this work better for the callers. And thanks to Kay for finding some stupid bugs in my original version and pointing out that we need to handle the fact that kobject's can have a kset as a parent and to handle that properly in kobject_add(). Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Miklos Szeredi <miklos@szeredi.hu> Signed-off-by: Greg Kroah-Hartman ...

Yes, I do agree that this is important, I'll work to not let this happen again. Especially now that I have your build scripts, I'm working on setting up something like that myself here. thanks, greg k-h --

This makes the code a bit simpler and and gets us one step closer to deleting the deprecated subsys_attr code. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Dirk Behme <dirk.behme@de.bosch.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- arch/arm/mach-omap1/pm.c | 22 ++++++++-------------- 1 files changed, 8 insertions(+), 14 deletions(-) diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c index 402113c..63edafb 100644 --- a/arch/arm/mach-omap1/pm.c +++ ...

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Christoph Lameter <clameter@sgi.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- mm/slub.c | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 40bdf41..886131c 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3962,7 +3962,7 @@ static struct kset_uevent_ops slab_uevent_ops = { .filter = uevent_filter, }; ...

The odds are very low, as long as not more patch sets come up which introduce intermediate broken kernels. What exactly is the advantage of breaking the kernel with patch 1 and then fix it again with patch 2 instead of doing the straight forward conversions all with one patch? --

In the call to kobject_unregister(), which has then later in the series been converted to a call to kobject_put(). thanks, greg k-h --

From: Dave Young <hidave.darkstar@gmail.com> Convert to use the class iteration api. Signed-off-by: Dave Young <hidave.darkstar@gmail.com> Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/ieee1394/nodemgr.c | 314 +++++++++++++++++++++++++------------------- 1 files changed, 176 insertions(+), 138 deletions(-) diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c index 90dc75b..511e432 100644 --- ...

From: Kay Sievers <kay.sievers@vrfy.org> Remove the no longer needed subsys_attributes, they are all converted to the more sensical kobj_attributes. There is no longer a magic fallback in sysfs attribute operations, all kobjects which create simple attributes need explicitely a ktype assigned, which tells the core what was intended here. Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/sysfs/file.c | 63 ...

Using a kset for this simple directory is an overkill. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Matt Domsch <Matt_Domsch@dell.com> Cc: Matt Tolentino <matthew.e.tolentino@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/firmware/efivars.c | 18 ++++++++---------- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index d1ad481..7f9f086 100644 --- a/drivers/firmware/efivars.c +++ ...

This also renames fs_subsys to fs_kobj to catch all current users with a build error instead of a build warning which can easily be missed. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/ecryptfs/main.c | 2 +- fs/fuse/inode.c | 2 +- fs/gfs2/sys.c | 2 +- fs/namespace.c | 11 +++++------ include/linux/fs.h | 2 +- 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/fs/ecryptfs/main.c ...

Sure :-) This one is rebased on the current state in git. Thanks, Frank --- drivers/char/nozomi.c | 122 ++++++++++++++------------------------------------ 1 file changed, 36 insertions(+), 86 deletions(-) --- a/drivers/char/nozomi.c +++ b/drivers/char/nozomi.c @@ -2,7 +2,7 @@ * nozomi.c -- HSDPA driver Broadband Wireless Data Card - Globe Trotter * * Written by: Ulf Jakobsson, - * Jan �erfeldt, + * Jan Åkerfeldt, * Stefan Thomasson, ...

Stop using kobject_register, as this way we can control the sending of the uevent properly, after everything is properly initialized. Cc: Shaohua Li <shaohua.li@intel.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/cpuidle/sysfs.c | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c index 0f3515e..059db9c 100644 --- a/drivers/cpuidle/sysfs.c +++ ...

From: Emil Medve <Emilian.Medve@Freescale.com> Removed duplicates defined elsewhere Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/i2c/chips/isp1301_omap.c | 6 ------ drivers/isdn/gigaset/gigaset.h | 6 ------ include/linux/device.h | 24 +++++++++++++++--------- 3 files changed, 15 insertions(+), 21 deletions(-) diff --git a/drivers/i2c/chips/isp1301_omap.c ...

But do you use an initrd that tries to load the same driver too? I'm too lazy to want to do my own initrd. I just use the prepackaged ones and rely on the fact that my private kernel will refuse to load modules That *is* the git version you're running: e374a2bf. The "-g" is for "git" and the "-dirty" is because you have some non-checked-in changes in addition. I works for me: [torvalds@hp linux]$ git show --abbrev-commit -s --pretty=oneline e374a2bf e374a2b... Kobject: fix ...

This allows an easier way to get to the kset associated with a struct bus_type (you have three to choose from...) This will make it easier to move these fields to be dynamic in a future patch. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/bus.c | 6 ++++++ drivers/pci/hotplug/pci_hotplug_core.c | 5 ++++- include/linux/device.h | 2 ++ 3 files changed, 12 insertions(+), 1 ...

These functions are no longer used and are the last remants of the old subsystem crap. So delete them for good. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/base/bus.c | 6 +++--- drivers/base/class.c | 4 ++-- include/linux/kobject.h | 3 --- lib/kobject.c | 13 ------------- 4 files changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 6796d3e..871607b ...

This makes the code a bit simpler and and gets us one step closer to deleting the deprecated subsys_attr code. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Manish Ahuja <mahuja@us.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- arch/powerpc/platforms/pseries/power.c | 20 ++++++++------------ 1 files changed, 8 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/platforms/pseries/power.c b/arch/powerpc/platforms/pseries/power.c index c36febe..90706cf 100644 --- ...

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Matt Domsch <Matt_Domsch@dell.com> Cc: Matt Tolentino <matthew.e.tolentino@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/firmware/efivars.c | 22 ++++++++++------------ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 018ca1c..e17cd81 100644 --- a/drivers/firmware/efivars.c +++ ...

Dynamically create the kset instead of declaring it statically. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Matt Domsch <Matt_Domsch@dell.com> Cc: Matt Tolentino <matthew.e.tolentino@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/firmware/efivars.c | 19 +++++++++---------- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index ebc3853..018ca1c 100644 --- a/drivers/firmware/efivars.c +++ ...

From: Shane Huang <shane.huang@amd.com> SB700 SATA MSI bug will be fixed in SB700 revision A21 at hardware level, but the SB700 revision older than A21 will also be found in the market. This patch modify the original quirk commit bc38b411fe696fad32b261f492cb4afbf1835256 instead of withdrawing it. The patch also removes quirk to 0x4395 because 0x4395 is SB800 device ID. Signed-off-by: Shane Huang <shane.huang@amd.com> Signed-off-by: Tejun Heo <htejun@gmail.com> --- Okay, here's reformatted ...

Seems to me that is the same argument used for lock_kernel. I am saying we have a perfectly reasonable way to seperate the protections down to their smallest. For the things hanging off the mm, mmap_sem, for the other list, a list specific lock. Keep in mind that on a 2048p SSI MPI job starting up, we have 2048 ranks doing this at the same time 6 times withing their address range. That seems like a lock which could get hot fairly quickly. It may be for a That will be fine as long as we ...

We need to fix the next define to not use column 81. Found a couple of more 80 column infractions. Will be fixed in next Ok. We could switch this to mmap_sem protection for the mm_struct but the rmap notifier is not associated with an mm_struct. So we would need to keep it there. Since we already have a spinlock: Just use it for both to Peter already mentioned that and I have posted patches that address this The TLB entries are removed by earlier invalidate_range calls. I would ...

Diff so far against V1 - Improve RCU support. (There is now a sychronize_rcu in mmu_release which is bad.) - Clean compile for !MMU_NOTIFIER - Use mmap_sem for serializing additions the mmu_notifier list in the mm_struct (but still global spinlock for mmu_rmap_notifier. The registration function is called only a couple of times)) - --- include/linux/list.h | 14 ++++++++++++++ include/linux/mm_types.h | 2 -- include/linux/mmu_notifier.h | 39 ...

Core code for mmu notifiers. Signed-off-by: Christoph Lameter <clameter@sgi.com> Signed-off-by: Andrea Arcangeli <andrea@qumranet.com> --- include/linux/mm_types.h | 8 ++ include/linux/mmu_notifier.h | 152 +++++++++++++++++++++++++++++++++++++++++++ include/linux/page-flags.h | 9 ++ kernel/fork.c | 2 mm/Kconfig | 4 + mm/Makefile | 1 mm/mmap.c | 2 mm/mmu_notifier.c | 91 ...

These notifiers here use the Linux rmaps to perform the callbacks. In order to walk the rmaps locks must be held. Callbacks can therefore only operate in an atomic context. Signed-off-by: Christoph Lameter <clameter@sgi.com> --- mm/filemap_xip.c | 1 + mm/fremap.c | 1 + mm/memory.c | 1 + mm/mremap.c | 2 ++ mm/rmap.c | 12 +++++++++++- 5 files changed, 16 insertions(+), 1 deletion(-) Index: ...

The invalidation of address ranges in a mm_struct needs to be performed when pages are removed or permissions etc change. invalidate_range() is generally called with mmap_sem held but no spinlocks are active. Exceptions: We hold i_mmap_lock in __unmap_hugepage_range and sometimes in zap_page_range. Should we pass a parameter to indicate the different lock situation? Comments state that mmap_sem must be held for remap_pfn_range() but various drivers do not seem to do ...

This is a patchset implementing MMU notifier callbacks based on Andrea's earlier work. These are needed if Linux pages are referenced from something else than tracked by the rmaps of the kernel. To do: - Make locking requirements for the callbacks consistent and document them accurately. - Insure that the callbacks are complete - Feedback from uses of the callbacks for KVM, RDMA, XPmem and GRU Andrea's mmu_notifier #4 -> RFC V1 - Merge subsystem rmap based with Linux rmap based ...

try_to_unmap is called from multiple places. The placement here also covers f.e. page migration. We also need to do this in the page_mkclean case because the permissions on an external pte are restricted there. So we need a refault to update We actually need both version. We have hardware that has a driver without rmap that does not sleep. On the other hand XPmem has rmap capability and Well we still have to review this stuff more and I have a vague feeling that not all the multiple ...

How does the called process sleep or how does it coordinate async work with try_to_unmap? We need to sleep. On a seperate note, I think the page flag needs to be set by the process when it is acquiring the page for export. But since the same page could be acquired by multiple export mechanisms, we should not clear it in the exporting driver, but rather here after all exportors have been called to invalidate_page. That lead me to believe we should add a flag to get_user_pages() ...

thanks, applied. Ingo --

I will do it. But I have some other thing to do now, so I will send it on next Monday. Best Regards, Huang Ying --

thanks, applied. you've changed it from nocache-noexec to cached-exec. I suspect that's what we want - except if an early EFI area can be non-prefetchable device memory. Can that ever happen? Would you like to have PAGE_KERNEL_NOCACHE_EXEC perhaps? I implemented that yesterday but did not commit it yet. (see the patch below) Ingo -----------------> Subject: x86: add PAGE_KERNEL_EXEC_NOCACHE From: Ingo Molnar <mingo@elte.hu> add PAGE_KERNEL_EXEC_NOCACHE. Signed-off-by: ...

ok, i fixed that in the patch and reordered the PAGE_KERNEL_NOCACHE_EXEC you are right in that there is no immediate correctness reason for it. The reason is to eventually get away from any MTRR dependencies. If some other OS uses PATs and the BIOS sets up the wrong MTRR, then the other OS might still having a working EFI, while Linux might crash and burn. So we try to get both the MTRRs and the pagetable attributes match the purpose of the area in question. If _both_ levels of ...

This patch fixes some bugs of making EFI runtime code executable. - Use change_page_attr in i386 too. Because the runtime code may be mapped not through ioremap. - If there is no _PAGE_NX in __supported_pte_mask, the change_page_attr is not called. - Make efi_ioremap map pages as PAGE_KERNEL_EXEC, because EFI runtime code may be mapped through efi_ioremap. Signed-off-by: Huang Ying <ying.huang@intel.com> --- arch/x86/kernel/efi.c | 35 ++++++++++++++++++++++++++++++----- ...

thanks, applied. Ingo --

thanks, applied. Ingo --

i guess it would be nicer to have the proper accessors to just clear the NX bit from ref-prot - instead of re-constructing the *kpte from scratch. But i see no other way to do it right now than to access pgprot_val() as an lvalue. Jeremy, what would be the best approach here? Ingo --

I don't think its a good idea to treat pgprot_val() as an lvalue - it precludes it from being turned into an inline function. I know there are numerous other places which do, but we should avoid making it worse. J --

Strictly, I should say on 32-bit, EFI runtime service won't work in kexeced kernel. That is, on EFI 32 platform, it is possible that: - Boot kernel A with EFI runtime service - kexec kernel B without EFI runtime service (such as with noefi in kernel command line) I suspect this method can be used on 32-bit platform. Because the fixmap area on 32-bit is more limited than 64-bit. And because identity map area on 32-bit is too limited, it is possible that all EFI runtime code, data, IO areas ...

so this basically means that on 32-bit kexec wont work right - i.e. only 64-bit has been enhanced this way? What am i missing? Ingo --

This patch fixes some bugs of EFI memory handing code. - On x86_64, it is possible that EFI memory map can not be mapped via identity map, so efi_map_memmap is removed, just use early_ioremap. - On i386, the EFI memory map mapping take effect cross paging_init, so it is not necessary to use efi_map_memmap. - EFI memory map is unmapped in efi_enter_virtual_mode to avoid early_ioremap leak. Signed-off-by: Huang Ying <ying.huang@intel.com> --- arch/x86/kernel/efi.c | 2 ...

Yes. The efifb driver try to ioremap 0x40000000 on my 64-bit box and it failed because 0x40000000 < (end_pfn_map << PAGE_SHIFT) and it is Best Regards, Huang Ying --

Andrew, Thanks for your comments. cap_set_flag() and cap_from_text() checks whether required capability code is in between 0 and __CAP_BITS, or not. I don't think it works correctly. Is it necessary to obtain this bound dynamically? > Further, if anyone ever wants to translate the capabilities into another > language, it seems like user-space is a much better place for that than > in the kernel. Are you intend to translate "cap_net_admin" into native language representation, for ...

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 KaiGai, While this is cute :-), I guess I'm still not all that convinced that this is needed. libcap already had some (admittedly not quite working) support for numeric values of capabilities not currently defined (which I believe is now fixed in top of trunk): # ./setcap 35=i ./setcap # ./getcap ./setcap ./setcap = 35+i Although, I obviously can't argue that this is as readable as your approach, it does seem unlikely that the rate of ...

We can apply this patch to libcap. This patch enables setcap command to print the list of capabilities running kernel supported, if the kernel exports capability code/name pairs. It is useful to confirm the name of capability when setting. Thanks, ---- Signed-off-by: KaiGai Kohei <kaigai@ak.jp.nec.com> diff --git a/progs/setcap.c b/progs/setcap.c index dc13c06..1b9ed45 100644 --- a/progs/setcap.c +++ b/progs/setcap.c @@ -4,6 +4,7 @@ * This sets the capabilities of a given file. ...

On !PAE 32-bit, _PAGE_NX will be 0, making is_prefetch always return early. The test is sufficient on PAE as __supported_pte_mask is updated in the same places as nx_enabled in init_32.c which also takes disable_nx into account. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/x86/mm/fault.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index bdf0282..32755eb 100644 --- ...

Thanks, this gets me to usermode under kvm. J --

I don't think this makes sense to move outside the AMD workaround because the normal MTRRs don't have an implicit hidden 4GB semantics. -Andi --

it's available ... 3 .. 2 ... 1 ... NOW! ;-) Ingo --

Yes, it does. And for the record: [root@qemu ~]# cat /proc/mtrr [root@qemu ~]# J --

great, thanks for checking. Ingo --

no, to be fully generic it would have to be able to 'split' e820 entries up and punch holes into them - but we dont want to go that far i think. The most common problem is mismatch at the end of a range. but what matters more is to have full, generic _detection_ of the problem - and that's what we dont do right now. (and that's what my reply outlines) The _fixup_ which we base on this information can then be anything from "trivially trim the end" up to a complex "punch holes" ...

thanks, applied. Shouldnt we put in an exception for when there is MTRR support, but they dont cover anything. Still emit a warning - but booting up real slow is still better than losing all of RAM and crashing ... i also updated the messages, they now go like this: WARNING: strange, CPU MTRRs all blank? and: WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 45MB of RAM. Ingo --

so the ram size less 4g is way out for your case. again, can you post /proc/mtrrs with v2 patch? Thanks YH --

Though I don't see this form of message; have you pushed your changes out to the public x86.git#mm tree? J --

on 32 bit, max_pfn is supposed to be 0? will look at it. YH --

so check it mtrr is there, also check if mem less 4G and is AMD as early Signed-off-by: Yinghai Lu <yinghai.lu@sun.com> Index: linux-2.6/arch/x86/kernel/cpu/mtrr/main.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/cpu/mtrr/main.c +++ linux-2.6/arch/x86/kernel/cpu/mtrr/main.c @@ -642,13 +642,10 @@ early_param("disable_mtrr_trim", disable #define Tom2Enabled (1U << 21) #define Tom2ForceMemTypeWB (1U << 22) -static __init int ...

so the boot msg say: WARNING: strange, CPU MTRRs all blank? YH --

Yes. WARNING: strange, CPU MTRRs all blank? ------------[ cut here ]------------ WARNING: at /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/cpu/mtrr/main.c:710 mtrr_trim_uncached_memory+0xf8/0x17b() Modules linked in: Pid: 0, comm: swapper Not tainted 2.6.24 #1938 [<c012804c>] warn_on_slowpath+0x41/0x51 [<c01285d4>] ? __call_console_drivers+0x4e/0x5a [<c03c3e85>] ? _spin_unlock_irqrestore+0xf/0x2f [<c03c3e91>] ? _spin_unlock_irqrestore+0x1b/0x2f [<c012880c>] ? ...

so more strict check if mtrr is there really. bail out if mtrr all blank when qemu cpu model is used and check if is AMD as early also remove 4G less check, according to hpa. Signed-off-by: Yinghai Lu <yinghai.lu@sun.com> Index: linux-2.6/arch/x86/kernel/cpu/mtrr/main.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/cpu/mtrr/main.c +++ linux-2.6/arch/x86/kernel/cpu/mtrr/main.c @@ -642,13 +642,10 @@ early_param("disable_mtrr_trim", ...

The problem is re-occuring for me with current x86.git. Looks like v2 did the trick, and v3 is broken... J --

It's true that there was before no way to touch only part of the FPU state via ptrace. The user_regset interface genericizes access to every regset to permit partial access, subject to the size and align fields. Access to some part of the data is certainly of use for some regsets, like the general registers and TLS, which always have exposed means to touch just one chunk (e.g. PTRACE_POKEUSR, PTRACE_SET_THREAD_AREA). It's a very worthwhile thing that we have a uniform interface for all the ...

Well, is the generic regset code enforce the need for this now? Can we disallow the usage cases where the user passes smaller target buffer size or requests data from in between. We were disallowing such usage scenarios before, isn't it? thanks, suresh --

Roland, Just happen to notice this bug. Can you please ack the bug fix which needs to goto x86 mm tree. thanks. --- [patch] x86, i387: use convert_to_fxsr() in fpregs_set() This fixes the bug introduced recently during the revamp of the code. fpregs_set() need to use convert_to_fxsr() rather than copying into the fxsave struct directly. Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> --- diff --git a/arch/x86/kernel/i387.c b/arch/x86/kernel/i387.c index 7e354a3..93a1706 ...

ah, this explains the weird chunk in your other patch. Ingo --

The change from current to tsk in do_page_fault is safe as this is set at the very beginning of the function. Removes a likely() annotation from the X86_64 version, this could have instead been added to X86_32. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/x86/mm/fault.c | 43 ++++++++++++++----------------------------- 1 files changed, 14 insertions(+), 29 deletions(-) diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index 14a0c6e..95fe8bf 100644 --- ...

ACK. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --

That would be great, from my perspective :) -- Greetings Michael. --

Let's see how many drivers are going to need that. If there's more than a couple, it will certainly make sense to have a global variable like this. Thanks, Rafael --

From: Rafael J. Wysocki <rjw@sisk.pl> Make it possible to unregister a led classdev object in a safe way during a suspend/resume cycle. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- drivers/leds/led-class.c | 13 +++++++++---- include/linux/leds.h | 10 +++++++++- 2 files changed, 18 insertions(+), 5 deletions(-) Index: linux-2.6.24-rc8-mm1/drivers/leds/led-class.c =================================================================== --- ...

From: Rafael J. Wysocki <rjw@sisk.pl> Move the declaration of device_pm_schedule_removal() to device.h and make it exported, as it will be used directly by some drivers for unregistering device objects during suspend/resume cycles in a safe way. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- drivers/base/power/main.c | 1 + drivers/base/power/power.h | 1 - include/linux/device.h | 6 ++++++ 3 files changed, 7 insertions(+), 1 deletion(-) Index: ...

Agreed. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --

Let's call it a deoptimization, but ok. I suspect you'll hear about it again at some point in the future in form of performance regressions. I'm a little surprised you chose this to simply way though. My feeling was always that the primary way to simply cpa would have been to get rid of the separate flushing step (which in hindsight was probably not a useful optimization and it caused fairly tricky code) Also Linus used to have pretty strong opinions in the past about using What fast ...

that's a point you are still missing badly in all these discussions about unification and sound design practices: code reuse and a clean, layered design. PAGEALLOC now uses change_page_attr() again and that approach is working really well. You made PAGEALLOC use a special-purpose remapping function but that would make c_p_a() unrobust indirectly - simply because it would be used much less. So i've removed that change and have fixed c_p_a() instead to both be fast and scalable ...

In hidinput_configure_usage(device), IS_CHICONY_TACTICAL_PAD(devic) gets passed the 'device' parameter. But that macro still references its parameter by 'device' instead of by its local name 'x'. Signed-off-by: Philipp Matthias Hahn <pmhahn@titan.lahn.de> --- linux/drivers/hid/hid-input.c 2008-01-25 09:57:17.000000000 +0100 +++ linux/drivers/hid/hid-input.c 2008-01-25 10:56:35.835871529 +0100 @@ -87,7 +87,7 @@ #define map_key_clear(c) do { map_key(c); clear_bit(c, bit); } while (0) /* ...

My point was about "obvious" errors, and I really think that one or two configuration will found most of these, doing in an automatic way, and without delay the process. Anyway more test are surely better. BTW, IIRC there are already few "testing farms" which tests automatically a lot of environment and configuration (IIRC, few hours, but a lot of changeset will broke bisect (few doc tell us how to continue bisecting on compile errors). As usual, "One level more indirections" ;-) . Along ...

As a tester, I'm not so happy. The last few merge windows were a nightmare for us (the tester). It remember me the 2.1.x times, but with few differences: - more changes, so bugs are unnoticed/ignored in the first weeks or - or people are pushing more patches possible, so they delay bug corrections to later times (after merge windows). If it continues so, I should stop testing the kernel on the merge windows (but it seems that other testers already give up the early merge phase). As a ...

An amazing amount of stuff gets caught when it's tested in Andrew Morton's -mm tree. You think -rc1's are bad now, consider that much of what will be 25-rc1 already got tried as 24-rc6-mm1 and 24-rc8-mm1. Without those, the It's true that a compile on x86 and a compile on PowerPC should flush out most of the truly stupid mistakes, but those are usually found and fixed literally within hours. Anyhow, the proper time for test compiles is *before* it goes into the git trees at all - it should ...

Adrian, please drop this version of the patches. I'll send you a new one addressing the feedback and indicating the ack I received from the driver maintainer in a private email. Thanks, Dmitri --

fs/bfs/bfs.h is not visible to the rest of the kernel, it's the right place for bfs-internal code. Whether there's an "extern" written is just a syntax thing with zero semantical implications. We tend to not write the "extern" in the kernel, but that's nothing cast in stone. But prototypes really belong into header files - bugs in this area are rare, but when they occur they can cause nasty hard-to-debug bugs (e.g. depending on the calling convention on the architecture calling the ...

This is basically a kernel workaround for stupid app behavior. It wouldn't be the first time we've provided such an option, but we shouldn't do it without a very good justification. At the very least, we need a test case that demonstrates the problem and benchmark results that prove that this approach actually fixes it. I suspect we can find a cleaner fix for the problem. -- Chris --

my understanding is that the journal is limited to 128M or so. This prevents you from making it big enough to avoid all problems. --

Then we'd also have to fix dcache.h: #define DCACHE_NFSFS_RENAMED 0x0002 /* this dentry has been "silly * renamed" and has to be * deleted on the last dput() */ by adding \ at the end of the comments, to unbreak cooledit and mc. (The problem is not the comment, but the seemingly stray " in the 2nd line) --

Miklos, I'll check this today evening (a bit busy now). - Cyrill - --

Yes, it's going to be removed so don't use it. Actually, basing this patch on top of -mm is a good idea because there are quite some changes As Cyrill wrote, it could be zeroed out in case there is no anchor in the specified block. So I guess you have to store the passed value somewhere else.. Honza -- Jan Kara <jack@suse.cz> SuSE CR Labs --

OK. Cyrill, Jan, thanks for the reviews. Miklos --

Hmm, given that options are modified by remount for some filesystems, it's probably the best to display the effective state. So your code should display the right thing as it is. Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR --

[Miklos Szeredi - Fri, Jan 25, 2008 at 10:29:21AM +0100] | > | + /* is this correct? */ | > | + if (sbi->s_anchor[2] != 0) | > | + seq_printf(seq, ",anchor=%u", sbi->s_anchor[2]); | > | > you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2] | > in sake of style unification but we should wait for Jan's | > decision (i'm not the expert in this area ;) | | I think UDF_SB_ANCHOR macro was removed by some patch in -mm. | | I'm more interested if the second element of the s_anchor array ...

[Miklos Szeredi - Fri, Jan 25, 2008 at 04:50:15PM +0100] | > > > | + /* is this correct? */ | > > > | + if (sbi->s_anchor[2] != 0) | > > > | + seq_printf(seq, ",anchor=%u", sbi->s_anchor[2]); | > > > | > > > you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2] | > > > in sake of style unification but we should wait for Jan's | > > > decision (i'm not the expert in this area ;) | > > | > > I think UDF_SB_ANCHOR macro was removed by some patch in -mm. | > Yes, it's going to be removed ...

Ah, OK. I'm happy to implement logic to display the all missing options. I should have updated nfs_show_mount_options() when I wrote the NFS mount option parser. For NFS, umount also needs to read some of the options in order to determine how mountd is to connect to the server for the unmount. (That's why we have addr= in the first place). -- Chuck Lever chuck[dot]lever[at]oracle[dot]com --

Looks, fine. Acked-by: Jan Kara <jack@suse.cz> Honza -- Jan Kara <jack@suse.cz> SuSE CR Labs --

Hi Miklos, Where did you check for the existence of a ->show_options method for unionfs? Unionfs does implement ->show_options and supports all of the mount/remount options. See: <http://git.kernel.org/?p=linux/kernel/git/ezk/unionfs.git;a=blob;f=fs/unionfs/super.c;h=986c980261a5b171147d66ac05bf08423e2fd6b6;hb=HEAD#l963> The unionfs ->remount code supports branch-management options which can add/del/change a branch, but we don't show those directly in ->show_options; it makes more sense ...

Added to ext4 patch queue. Thanks! http://repo.or.cz/w/ext4-patch-queue.git Mingming --

Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. --

Looks fine. Acked-by: Jan Kara <jack@suse.cz> Honza -- Jan Kara <jack@suse.cz> SuSE CR Labs --

Acked-by Ian Kent <raven@themaw.net> I haven't tested this yet but it is fairly straight forward. I will check it out as soon as I get back to some work that I'm doing on --

Have y'all been following the /dev/mem_notify patches? http://article.gmane.org/gmane.linux.kernel/628653 --=20 Zan Lynx <zlynx@acm.org>

Also, CC jgarizk since we will be touching netdev drivers. We've been pushing such updates via the powerpc tree's but its good that Jeff's aware. - k --

I'm a bit concerned this patch is touching too many files.. or ones that I'm assmuing this patch depends on the previous one. - k --

OK, that doesn't matter that much. At least the patch makes sense and your example shows why original code is wrong, so I will merge it. If anybody had a problem with it, the code would be easily bisectable (there are so few patches in 2.4) and it's easy to revert it. Thanks to you both, Eric and Dann ! Willy --

Yes, I'm saying it belongs as brg/clock-frequency. :-) CPM1/2 already do this. -Scott --

Answer to myself, the reason is that lockdep think this as a lock order problem. in rfcomm_device_add the lock order is : rfcomm_dev_lock --> dlc lock but in __rfcomm_dlc_close is : --

They aren't typically found on motherboards. With their long cable length they are more commonly used for personal weather stations. The guidelines list 750 meters as the longest distance signal wise, and one example listed example 100 meters and 100 iButton devices as possible. The same one wire sensors are part of the OpenBSD equivalent sysctl command to get hardware information and sensor data. I added support for the ds18b20 sensor to OpenBSD. Interestingly they also had a bug when ...

Often removing half the ram, running a kernel compile, see if it segfaults, then repeat with the other half of ram is much faster and more reliable than memtest. memtest just doesn't have the same random accesses while keeping the cpu underload as a kernel compile does. Personally I just don't bother with memtest anymore. The only thing it tells you is that you have errors or that you might have errors but it didn't find them. It never tells you that you do not have errors and it often ...

The usermode fault handler already effectively does this; this patch just does it for kernel mode as well. I don't know if mprotect takes Not valgrind (it doesn't rely on mmap protections), but electric fence perhaps. J --

How do you define dynamically-allocated data? -Andi --

NMI is blocked by the hardware until IRET and when a page fault happens inside the NMI handler the early IRET unblocks it and then NMIs can nest, which will lead to stack corruption. -Andi --

spurious faults happen all the time on SMP, in the native kernel. And what i mean is that Linux mprotect currently does not take advantage of x86's ability to just change the ptes, because there's no structured way to tell mm/mprotect.c that "it's safe to skip the TLB flush here". The flush happens in mm/mprotect.c's change_protection() function: flush_tlb_range(vma, start, end); and that is unnecessary when we increase the protection rights, such as in a RO->RW change. ...

Actually, another thought: permitting (and handling) spurious faults for kernel mappings conflicts with NMI handling, i.e. great care would be needed to ensure the NMI path cannot touch any such mapping. So even the present Xen/Linux Dom0 implementation may have some (perhaps unlikely) problems here, and it would get worse if we added e.g. a virtual watchdog NMI (something I am considering, which would then extend the problem to DomU-s). Jan --

In the same way as vmalloc faults do (which is why vmalloc_sync_all() got introduced): a page fault nested inside an NMI will, by virtue of executing IRET, prematurely tell the processor that NMI handling is done (and specifically unmask further NMIs). Jan --

My understanding is that it will fault immediately if there's a TLB entry, and rewalk the tables on return from the fault before restarting the instruction, so there's no need for an explicit TLB flush. The TLB doesn't have a notion of negative cache entries, so any entry represents a present page of some variety. J --

Unionfs resolved this by fully implementing the address_space ops, as well as ->mmap (i.e., one cannot "cheat" and inherit the lower address_space). Erez. --

OK, I'll believe you ;) I was never completely sure what all can happen Yes, that was actually the reason why I changed the checks from list_empty() to b_assoc_map testing. Well, so I'll add the barrier and maybe also change these list_empty() checks to b_assoc_map tests... Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR --

the current implementation of memory subsystem associates pages to cgroups directly, rather than via tasks. so it isn't straightforward to use the information for other classification mechanisms like yours which might not share the view of "hierarchy" with the memory subsystem. --

So this is an abandoned page with a refcount that only exists because of fs private data? Truncate race? --

Yeah, for memory hot remove that makes sense. A comment might be in order, at least a reference to the orphaned page code in vmscan.c. Otherwise, it is OK by me. Acked-by: Nick Piggin <npiggin@suse.de> --

truncate_complete_page could fail to remove fs private data, this is the comments say. Thanks, Shaohua --

yes, maybe, but the comments in truncate_complete_page called the page the page is still in lru list. Memory hot remove will try to migrate the page. Thanks, --

Ok, changed. Orphaned page might have fs-private metadata, the page is truncated. As the page hasn't mapping, page migration refuse to migrate the page. It appears the page is only freed in page reclaim and if zone watermark is low, the page is never freed, as a result migration always fail. I thought we could free the metadata so such page can be freed in migration and make migration more reliable. Signed-off-by: Shaohua Li <shaohua.li@intel.com> diff --git a/mm/migrate.c ...

Anonymous pages should not have fs-private metadata. Orphaned pages I guess you mean? They should not be accessable via the pagecache or the page tables, so how do they keep tangling up --

I can reproduce under qemu, which means you can attach gdb to it. I'll see if it happens to a Xen guest too. J --

Hm, on the other hand, maybe I'm not reproducing this - looks more like a problem with mtrr trimming... J --

The build error was fixed with the note I sent to you yesterday with a "fixup" patch for changes in -mm but not in x86.git (attached). I'll try out your config next. Thanks, Mike

--

All looks sane. Regards Oliver --

My attitude to this is simple: who cares about proprietary modules? The current test is wrong, it should be checking for forced module loads (which may not have marker information and may well crash the kernel). Of course, all forced module loads can crash the kernel, but this is pretty certain and it's simply to avoid. We should just flat-out refuse to load a module with a module section too small. That will cover the majority of this case anyway (*and* the non-kallsysms case), and ...

The person who solves the "even if in X" problem will probably be nominated for sainthood by the Linux community. "It just hung with flashing LED's" is just too common an event....

The former is actually trivially doable with the module->taints bits. We could have the equivalent of a neon flashing "blame this module" sign. I also agree, we should stop force loading. Incompatible struct module, etc. are really bad things to have mapped into a running kernel. Jon. --

--

The kernel from 17th Jan 2008 didn't have CONFIG_HIGHPTE enabled. Yesterday we checked a 2.6.23.14 kernel with CONFIG_HIGHPTE enabled. The 4GB test machine showed the same fast low memory reducing effect. LowFree stopped at 400MB like without CONFIG_HIGHPTE. A 2GB machine had a limit of 690MB LowFree. The difference of LowTotal and LowFree is shown as used memory. In case of the 4GB machine, this means I have 400MB used memory which is not related to any process. I hope this helps. I ...

ACK... and BTW ack for that deferred device removal series. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --

Yeah, I'm aware of this particular piece of Xen braindamage, and although I had some very unkind words to say about it, it mirrors what we have to do for the !PAE case anyway, so it can be sort of glossed over. -hpa --

No, if Xen wasn't an issue there wouldn't be anything to do for the PAE case at all (since the PGD is trivial.) Copying PMDs is more or less an analogous case of the !PAE case, once the allocation is already done. The allocation should be trivial As much as I'd rather see Xen fixing this than having it continue to impact the kernel, I presume it will take some time to flush the broken hypervisors out? -hpa --

Oh, that makes that option much more viable and probably preferrable. -hpa --

We already do this on the 64bit side. We reuse the kernel and the identity parts from the core kernel page tables but it is actually a distinct page table. x86_64 has not had the identity mappings mapped in any of the normal page tables since the relocatable kernel support was merged a while ago. Only on the 32bit side does this still remain an issue. I don't know if what we can do optimization wise there. Emulating the 64bit code and having a dedicated top level pgd (as part of the ...

I think we're in vehement agreement here. In either case, its just a matter of something like: memcpy(pgd, &pgd[USER_PTRS_PER_PGD], sizeof(pgd_t) * KERNEL_PTRS_PER_PGD); Sorry, I was unclear. I meant in the purely Xen-specific parts of the kernel (arch/x86/xen). It wouldn't require a hypervisor change. J --

That's pretty much what I figure. The one issue is that on non-PAE 32-bit (or if we actually have to deal with unsharable PMDs on PAE kernels) then the PGD (PMD) kernel mappings at least formally should really be put in sync. This could be done either by the same code which keeps the PGDs of various processes in sync already or on demand; I believe my personal preference would be to have all that in the same place, since we have to do it anyway, and this is nothing different except for ...

Indeed. The alias mapping can be set up in Quite so. J --

Pavel is trolling. He is using an emotional attack in an attempt to thwart discussion. I take his advice. I feed him not. --

thanks Andi, i have applied your cleanup patch to x86.git a couple of days ago and it (no surprise) caused no testing problems so far. (I dont think we need to backport this cleanup to v2.6.24.1, as iBCS2 support was never present in any upstream Linux kernel anyway) Ingo --

They are when in a tight loop, but are trivial in this case. I'll go further and say that unless the system is constantly execing, there will always be a cache miss, and that removing this code will not improve that at all. --

Haven't accurate number, but in one device, it declaims L0s latency is < 128ns, L1 latency is < 64us. Thanks, Shaohua --

The main linux-mips git tree is derived of Linus' kernel.org tree and I usually update it daily. Patch scheduled for the next kernel release or later go into a special tree from which akpm pulls. For significant patch submissions that means patches should be generated either against the linux-queue tree from linux-mips.org (which only contains the MIPS specific stuff) or possibly akpm's -mm tree. Ralf --

At Fri, 25 Jan 2008 01:04:34 +0100, This looks similar like a bug I fixed ago. Damn, it's still there. Could you build with CONFIG_SND_DEBUG=y ? It addas some sanity checks and might catch the fatal condition. thanks, Takashi --

Done. I don't think it changed much though :-/ If you have any other ideas please let me know. Unable to handle kernel paging request at virtual address 0000000100024000 tsk->{mm,active_mm}->context = 0000000000000dac tsk->{mm,active_mm}->pgd = fffff800bdb64000 \|/ ____ \|/ "@'/ .. \`@" /_| \__/ |_\ \__U_/ mp3blaster(3201): Oops [#1] TSTATE: 0000000080009600 TPC: 000000000056a294 TNPC: 000000000056a298 Y: 00000000 Not ...

Yes, please review the refreshed patches. From: Thomas Sujith <sujith.thomas@intel.com> Intel menlow platform specific driver for thermal management extension. Signed-off-by: Thomas Sujith <sujith.thomas@intel.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> --- drivers/misc/Kconfig | 9 drivers/misc/Makefile | 1 drivers/misc/intel_menlow.c | 526 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 536 insertions(+) Index: ...

This is now broken in mainline... drivers/net/ehea/ehea_main.c: In function 'ehea_driver_sysfs_add': drivers/net/ehea/ehea_main.c:2812: error: 'struct device_driver' has no member named 'kobj' drivers/net/ehea/ehea_main.c:2815: error: 'struct device_driver' has no member named 'kobj' drivers/net/ehea/ehea_main.c:2818: error: 'struct device_driver' has no member named 'kobj' drivers/net/ehea/ehea_main.c: In function 'ehea_driver_sysfs_remove': drivers/net/ehea/ehea_main.c:2830: error: ...

This satisfies me. --

On Tue, 22 Jan 2008 18:31:09 -0600 Is this one any better? From df475e2eea401f9dc18ca23dab538b99fb9e710c Mon Sep 17 00:00:00 2001 From: Jay Cliburn <jacliburn@bellsouth.net> Date: Wed, 23 Jan 2008 21:36:36 -0600 Subject: [PATCH] atl1: simplify tx packet descriptor The transmit packet descriptor consists of four 32-bit words, with word 3 upper bits overloaded depending upon the condition of its bits 3 and 4. The driver currently duplicates all word 2 and some word 3 register ...

Ah ok, when I was looking at this I was allowing holes to get filled without falling back to buffered. But, with the orphan inode entry protecting things I see how you're safe with this patch. -chris --

Actually, I suspect your issues should be fixed by this patch: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e2d435ea40... Could you download 2.6.24 and try it out to see if they are? Thanks, James --

Mark, sorry for missing this for long time... This is used for our graphics driver module to know if we have to do dma remapping in iommu case, both in kernel config and kernel boot time param config. The simplest case is that DMAR_GFX_WA is on, which no dma mapping will act in intel_agp. If no DMAR_GFX_WA, we still have boot param to turn off whole intel iommu (intel_iommu=off), just turn off graphics remap engine (intel_iommu=igfx_off). So this exported interface is used to ...

Works for me. Did anyone else have a look? --

Also forgot to #include <asm/system.h> in some of the files. Here is the final product, for the record. From: Stefan Richter <stefanr@s5r6.in-berlin.de> Subject: firewire: enforce access order between generation and node ID, fix "giving up on config rom" fw_device.node_id and fw_device.generation are accessed without mutexes. We have to ensure that all readers will get to see node_id updates before generation updates. Fixes an inability to recognize devices after "giving up on config ...

This is essentially what I've been beating on locally, and I've yet to hit another config rom read failure with it. Signed-off-by: Jarod Wilson <jwilson@redhat.com> -- Jarod Wilson jwilson@redhat.com --

OK, I'll have to submit another update patch later. Thanks Shane --

I recommend running the scripts/checkpatch.pl script on any proposed patches like this before you send them. It will find a lot of these problems for you :) thanks, greg k-h --

Can you please get a decent email client? Thunderbird + toggle word It would be nice if things stay under 80col limit although we don't -- tejun --