login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
January
»
25
Re: [patch 25/26] mount options: fix udf
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Miklos Szeredi <miklos@...>
To: <jack@...>
Cc: <miklos@...>, <gorcunov@...>, <akpm@...>, <linux-fsdevel@...>, <linux-kernel@...>
Subject:
Re: [patch 25/26] mount options: fix udf
Date: Friday, January 25, 2008 - 12:10 pm
> On Fri 25-01-08 16:50:15, Miklos Szeredi wrote:
quoted text
> > > > > | + /* is this correct? */ > > > > > | + if (sbi->s_anchor[2] != 0) > > > > > | + seq_printf(seq, ",anchor=%u", sbi->s_anchor[2]); > > > > > > > > > > you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2] > > > > > in sake of style unification but we should wait for Jan's > > > > > decision (i'm not the expert in this area ;) > > > > > > > > I think UDF_SB_ANCHOR macro was removed by some patch in -mm. > > > Yes, it's going to be removed so don't use it. Actually, basing this > > > patch on top of -mm is a good idea because there are quite some changes > > > in Andrew's queue. > > > > > > > I'm more interested if the second element of the s_anchor array really > > > > does always have the value of the 'anchor=N' mount option. I haven't > > > > been able to verify that fully. Do you have some insight into that? > > > As Cyrill wrote, it could be zeroed out in case there is no anchor in > > > the specified block. So I guess you have to store the passed value > > > somewhere else.. > > > > But in that case, would the value of the anchor= option matter? > No, it would not. > > > This is actually a somewhat philosophical question about what the > > mount options in /proc/mounts mean: > > > > 1) Options _given_ by the user for the mount > > 2) Options which are _effective_ for the mount > > > > If we take interpretation 2) and there was no anchor (whatever that > > means), then the anchor=N option wasn't effective, and not giving it > > would have had the same effect. > > > > This could be confusing to the user, though... > Hmm, given that options are modified by remount for some filesystems, > it's probably the best to display the effective state. So your code should > display the right thing as it is.
OK. Cyrill, Jan, thanks for the reviews. Miklos --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[patch 25/26] mount options: fix udf
, Miklos Szeredi
, (Thu Jan 24, 3:34 pm)
Re: [patch 25/26] mount options: fix udf
, Jan Kara
, (Fri Jan 25, 11:30 am)
Re: [patch 25/26] mount options: fix udf
, Miklos Szeredi
, (Fri Jan 25, 11:56 am)
Re: [patch 25/26] mount options: fix udf
, Jan Kara
, (Fri Jan 25, 12:04 pm)
Re: [patch 25/26] mount options: fix udf
, Cyrill Gorcunov
, (Thu Jan 24, 4:40 pm)
Re: [patch 25/26] mount options: fix udf
, Cyrill Gorcunov
, (Thu Jan 24, 4:20 pm)
Re: [patch 25/26] mount options: fix udf
, Miklos Szeredi
, (Fri Jan 25, 5:29 am)
Re: [patch 25/26] mount options: fix udf
, Jan Kara
, (Fri Jan 25, 11:27 am)
Re: [patch 25/26] mount options: fix udf
, Miklos Szeredi
, (Fri Jan 25, 11:50 am)
Re: [patch 25/26] mount options: fix udf
, Jan Kara
, (Fri Jan 25, 12:07 pm)
Re: [patch 25/26] mount options: fix udf
, Miklos Szeredi
, (Fri Jan 25, 12:10 pm)
Re: [patch 25/26] mount options: fix udf
, Cyrill Gorcunov
, (Fri Jan 25, 11:57 am)
Re: [patch 25/26] mount options: fix udf
, Cyrill Gorcunov
, (Fri Jan 25, 9:41 am)
Re: [patch 25/26] mount options: fix udf
, Cyrill Gorcunov
, (Fri Jan 25, 6:57 am)
Re: [patch 25/26] mount options: fix udf
, Cyrill Gorcunov
, (Thu Jan 24, 3:51 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH
[GIT PATCH] driver core patches against 2.6.24
holzheu
Re: [RFC/PATCH] Documentation of kernel messages
FUJITA Tomonori
Re: Integration of SCST in the mainstream Linux kernel
openbsd-misc
:
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 13/37] dccp: Deprecate Ack Ratio sysctl
Arjan van de Ven
Re: [GIT]: Networking
Evgeniy Polyakov
Re: [BUG] New Kernel Bugs
Colocation donated by:
Who's online
There are currently
1 user
and
863 guests
online.
Online users
zeekec
Syndicate