Home » Mailing list archives » linux-kernel » 2008 » January » 25

[PATCH] linux-2.6.24/drivers/hid/hid-input.c

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Philipp Matthias Hahn <pmhahn@...>
To: Jiri Kosina <jkosina@...>
Cc: Kernel Mailing List <linux-kernel@...>, <linux-input@...>
Subject: [PATCH] linux-2.6.24/drivers/hid/hid-input.c
Date: Friday, January 25, 2008 - 6:11 am

In hidinput_configure_usage(device), IS_CHICONY_TACTICAL_PAD(devic) gets
passed the 'device' parameter. But that macro still references its
parameter by 'device' instead of by its local name 'x'.

Signed-off-by: Philipp Matthias Hahn <pmhahn@titan.lahn.de>

--- linux/drivers/hid/hid-input.c	2008-01-25 09:57:17.000000000 +0100
+++ linux/drivers/hid/hid-input.c	2008-01-25 10:56:35.835871529 +0100
@@ -87,7 +87,7 @@
 #define map_key_clear(c)	do { map_key(c); clear_bit(c, bit); } while (0)
 
 /* hardware needing special handling due to colliding MSVENDOR page usages */
-#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && device->product == 0x0418)
+#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && x->product == 0x0418)
 #define IS_MS_KB(x) (x->vendor == 0x045e && (x->product == 0x00db || x->product == 0x00f9))
 
 #ifdef CONFIG_USB_HIDINPUT_POWERBOOK
-- 
  / /  (_)__  __ ____  __ Philipp Hahn
 / /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Linux 2.6.24, Linus Torvalds, (Thu Jan 24, 7:17 pm)
Re: Linux 2.6.24, Jan Engelhardt, (Sun Feb 3, 8:35 am)
Re: Linux 2.6.24, Linus Torvalds, (Thu Jan 24, 7:41 pm)
Re: Linux 2.6.24, Giacomo A. Catenazzi, (Fri Jan 25, 5:10 am)
Re: Linux 2.6.24, Ingo Molnar, (Fri Jan 25, 7:35 am)
Re: Linux 2.6.24, , (Fri Jan 25, 5:58 am)
Re: Linux 2.6.24, Rafael J. Wysocki, (Fri Jan 25, 7:58 am)
Re: Linux 2.6.24, Giacomo A. Catenazzi, (Fri Jan 25, 8:34 am)
Re: Linux 2.6.24, Stefan Richter, (Fri Jan 25, 7:50 pm)
Re: Linux 2.6.24, , (Fri Jan 25, 11:19 pm)
using LKML for subsystem development (was Re: Linux 2.6.24), Stefan Richter, (Fri Jan 25, 8:42 pm)
Re: using LKML for subsystem development (was Re: Linux 2.6...., Ingo Molnar, (Sat Jan 26, 7:28 am)
Re: using LKML for subsystem development, Stefan Richter, (Sat Jan 26, 10:25 am)
Re: using LKML for subsystem development, Ingo Molnar, (Fri Feb 1, 5:40 am)
Re: using LKML for subsystem development, Stefan Richter, (Fri Feb 1, 3:53 pm)
Re: using LKML for subsystem development, David Miller, (Sat Jan 26, 10:07 am)
Re: using LKML for subsystem development, Stefan Richter, (Sat Jan 26, 10:45 am)
Re: using LKML for subsystem development (was Re: Linux 2.6...., , (Fri Jan 25, 11:28 pm)
Re: using LKML for subsystem development, Stefan Richter, (Sat Jan 26, 9:31 am)
Re: using LKML for subsystem development, , (Sun Jan 27, 3:37 am)
[PATCH] linux-2.6.24/drivers/hid/hid-input.c, Philipp Matthias Hahn, (Fri Jan 25, 6:11 am)
Re: [PATCH] linux-2.6.24/drivers/hid/hid-input.c, Jiri Kosina, (Fri Jan 25, 6:30 am)