Re: [PATCH] x86: trim ram need to check if mtrr is there v2

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Jeremy Fitzhardinge <jeremy@...>

Cc: H. Peter Anvin <hpa@...>, Ingo Molnar <mingo@...>, Linux Kernel Mailing List <linux-kernel@...>

Subject: Re: [PATCH] x86: trim ram need to check if mtrr is there v2

Date: Friday, January 25, 2008 - 4:39 am

On Jan 25, 2008 12:13 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
quoted text>
> On Jan 24, 2008 11:43 PM, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> >
> > Yinghai Lu wrote:
> > > [PATCH] x86: trim ram need to check if mtrr is there v2
> > >
> > >
> > >>> Jeremy Fitzhardinge wrote:
> > >>> When booting a current x86.git kernel under kvm, I get this:
> > >>>
> > >>> (qemu) Linux version 2.6.24-rc8 (jeremy@ezr) (gcc version 4.1.2 20070925
> > >>> (Red Hat 4.1.2-33)) #1928 SMP PREEMPT Thu Jan 24 17:09:04 PST 2008
> > >>> early_ioremap_init()
> > >>> BIOS-provided physical RAM map:
> > >>> BIOS-e820: 0000000000000000 - 000000000009fc00 (usable)
> > >>> BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved)
> > >>> BIOS-e820: 00000000000e8000 - 0000000000100000 (reserved)
> > >>> BIOS-e820: 0000000000100000 - 000000001fff0000 (usable)
> > >>> BIOS-e820: 000000001fff0000 - 0000000020000000 (ACPI data)
> > >>> BIOS-e820: 00000000fffc0000 - 0000000100000000 (reserved)
> > >>> console [earlyser0] enabled
> > >>> 0MB HIGHMEM available.
> > >>> 511MB LOWMEM available.
> > >>> Scan SMP from c0000000 for 1024 bytes.
> > >>> Scan SMP from c009fc00 for 1024 bytes.
> > >>> Scan SMP from c00f0000 for 65536 bytes.
> > >>> Scan SMP from c009fc00 for 1024 bytes.
> > >>> ***************
> > >>> **** WARNING: likely BIOS bug
> > >>> **** MTRRs don't cover all of memory, trimmed 131056 pages
> > >>> ***************
> > >>>
> > >> H. Peter Anvin wrote:
> > >> Looks like the code doesn't check that the CPU *has* MTRRs...
> > >>
> > >
> > > so check it mtrr is there, also check if mem less 4G and is AMD as early
> > >
> >
> > Thanks, this gets me to usermode under kvm.
>
> i think the is 0xffffffff to 0xffffffffUL make the difference.
>
> the cpu mode in KVM/qemu may cpu_has_mtrr, but doesn't really have
> return mtrr msr with correct value.
>
> is_cpu(INTEL) already make sure we have mtrr_if got assigned and cpu_has_mtrr.
>
> may need to fix qemu instead...
>
> Can you try post /proc/mtrr for your guest in kvm/qemu?

jeremy,

can you try v3 patch?

Thanks

YH
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

x86.git: mtrr trimming removes all memory under kvm, Jeremy Fitzhardinge, (Thu Jan 24, 9:44 pm)

Re: x86.git: mtrr trimming removes all memory under kvm, H. Peter Anvin, (Thu Jan 24, 9:49 pm)

[PATCH] x86: trim ram need to check if mtrr is there v2, Yinghai Lu, (Thu Jan 24, 11:47 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v2, Jeremy Fitzhardinge, (Fri Jan 25, 3:43 am)

[PATCH] x86: trim ram need to check if mtrr is there v3, Yinghai Lu, (Fri Jan 25, 4:42 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Ingo Molnar, (Fri Jan 25, 10:21 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Andi Kleen, (Fri Jan 25, 10:57 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Ingo Molnar, (Fri Jan 25, 11:10 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, H. Peter Anvin, (Fri Jan 25, 11:57 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Ingo Molnar, (Fri Jan 25, 7:09 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Jeremy Fitzhardinge, (Fri Jan 25, 2:59 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Ingo Molnar, (Fri Jan 25, 3:02 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Jeremy Fitzhardinge, (Fri Jan 25, 2:55 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Yinghai Lu, (Fri Jan 25, 3:19 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Jeremy Fitzhardinge, (Fri Jan 25, 3:04 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Ingo Molnar, (Fri Jan 25, 2:59 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Jeremy Fitzhardinge, (Fri Jan 25, 3:01 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Ingo Molnar, (Fri Jan 25, 3:04 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Jeremy Fitzhardinge, (Fri Jan 25, 3:27 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Yinghai Lu, (Fri Jan 25, 3:32 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Jeremy Fitzhardinge, (Fri Jan 25, 3:39 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v3, Ingo Molnar, (Fri Jan 25, 3:30 pm)

Re: [PATCH] x86: trim ram need to check if mtrr is there v2, Yinghai Lu, (Fri Jan 25, 4:13 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v2, Ingo Molnar, (Fri Jan 25, 7:12 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v2, H. Peter Anvin, (Fri Jan 25, 11:47 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v2, Yinghai Lu, (Fri Jan 25, 4:39 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v2, H. Peter Anvin, (Fri Jan 25, 1:44 am)

Re: [PATCH] x86: trim ram need to check if mtrr is there v2, Yinghai Lu, (Fri Jan 25, 3:50 am)

Re: x86.git: mtrr trimming removes all memory under kvm, Yinghai Lu, (Thu Jan 24, 10:32 pm)

Re: x86.git: mtrr trimming removes all memory under kvm, Andi Kleen, (Fri Jan 25, 6:52 am)

Re: x86.git: mtrr trimming removes all memory under kvm, Yinghai Lu, (Thu Jan 24, 10:21 pm)


linux-kernel:
Rafael J. Wysocki	[Bug #10493] mips BCM47XX compile error
Ingo Molnar	[patch 02/13] syslets: add syslet.h include file, user API/ABI definitions
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Andrea Arcangeli	[PATCH 00 of 11] mmu notifier #v16
git:

linux-netdev:
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Linus Torvalds	Re: [GIT]: Networking
Mark Lord	Re: [BUG] New Kernel Bugs
openbsd-misc:

Re: [PATCH] x86: trim ram need to check if mtrr is there v2

Online users