On Fri, 25 Jan 2008, Dmitri Vorobiev wrote:

quoted text
> Heikki Orsila =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>> +extern void dump_imap(const char *, struct super_block *);
>>> +
>>
>> Functions should not be externed, remove extern keyword.
>>
>
> Care to explain why?

because dump_imap() is just a BFS' internal helper (for debugging purposes=
=20
only btw) to dump the inode map via printk. Why should it be moved into=20
the header, i.e. where one expects to see things potentially visible by=20
the rest of the kernel?

quoted text
> 3) The checkpatch.pl did not complain at this particular patch.

maybe this script should be simplified to not complain at things like=20
that, which are best left to the author of the code to decide which=20
declaration should be where?

Kind regards
Tigran