Home » Mailing list archives » linux-kernel » 2008 » January » 24

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dmitri Vorobiev <dmitri.vorobiev@...>
To: Heikki Orsila <shdl@...>
Cc: <trivial@...>, <linux-kernel@...>, <akpm@...>, <tigran@...>
Subject: Re: [PATCH 5/9] bfs: move function prototype to the proper header file
Date: Thursday, January 24, 2008 - 7:13 pm

Heikki Orsila пишет:

Care to explain why?

Following is an explanation why the contrary is probably true:

1) We have lots of precedents in existing code:

dmvo@cipher:~/Projects/misc/linux$ git-grep 'extern void' include | wc -l
5523
dmvo@cipher:~/Projects/misc/linux$

2) Linus' Coding style does not mandate what you requested.

3) The checkpatch.pl did not complain at this particular patch.

Thanks,

Dmitri

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/9] bfs: assorted cleanups, Dmitri Vorobiev, (Thu Jan 24, 6:31 pm)
Re: [PATCH 0/9] bfs: assorted cleanups, Dmitri Vorobiev, (Fri Jan 25, 6:25 am)
[PATCH 8/9] bfs: remove multiple assignments, Dmitri Vorobiev, (Thu Jan 24, 6:32 pm)
[PATCH 7/9] bfs: coding style cleanup in include/linux/bfs_f..., Dmitri Vorobiev, (Thu Jan 24, 6:32 pm)
[PATCH 6/9] bfs: coding style cleanup in fs/bfs/file.c, Dmitri Vorobiev, (Thu Jan 24, 6:32 pm)
[PATCH 5/9] bfs: move function prototype to the proper heade..., Dmitri Vorobiev, (Thu Jan 24, 6:32 pm)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Heikki Orsila, (Thu Jan 24, 6:50 pm)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Tigran Aivazian, (Thu Jan 24, 7:08 pm)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Tigran Aivazian, (Thu Jan 24, 7:17 pm)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Dmitri Vorobiev, (Thu Jan 24, 7:13 pm)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Kyle Moffett, (Thu Jan 24, 9:55 pm)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Heikki Orsila, (Thu Jan 24, 7:33 pm)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Dmitri Vorobiev, (Thu Jan 24, 7:47 pm)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Tigran Aivazian, (Thu Jan 24, 7:22 pm)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Adrian Bunk, (Fri Jan 25, 6:42 am)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Dmitri Vorobiev, (Fri Jan 25, 7:12 am)
Re: [PATCH 5/9] bfs: move function prototype to the proper h..., Dmitri Vorobiev, (Thu Jan 24, 7:30 pm)
[PATCH 4/9] bfs: coding style cleanup in fs/bfs/dir.c, Dmitri Vorobiev, (Thu Jan 24, 6:32 pm)
[PATCH 3/9] bfs: coding style cleanup in fs/bfs/bfs.h, Dmitri Vorobiev, (Thu Jan 24, 6:32 pm)
[PATCH 2/9] bfs: coding style cleanup in fs/bfs/inode.c, Dmitri Vorobiev, (Thu Jan 24, 6:32 pm)
[PATCH 1/9] bfs: remove a useless variable, Dmitri Vorobiev, (Thu Jan 24, 6:32 pm)
[PATCH 9/9] bfs: use the proper header file for inclusion, Dmitri Vorobiev, (Thu Jan 24, 6:32 pm)