[PATCH 1/9] bfs: remove a useless variable

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dmitri Vorobiev
Date: Thursday, January 24, 2008 - 3:32 pm

In the bfs_fill_super() routine, the "sblock" variable is declared
and assigned a value. However, this value is never used. This trivial
patch removes this useless variable.

This was compile-tested by building the bfs driver both as a module
and as a part of the kernel proper. Both build finished successfully.

Run time test was performed using a BFS image and verifying that the
filesystem remained functional after the change.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
 fs/bfs/inode.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c
index a64a71d..2284657 100644
--- a/fs/bfs/inode.c
+++ b/fs/bfs/inode.c
@@ -368,7 +368,7 @@ static int bfs_fill_super(struct super_block *s, void *data, int silent)
 		struct bfs_inode *di;
 		int block = (i - BFS_ROOT_INO) / BFS_INODES_PER_BLOCK + 1;
 		int off = (i - BFS_ROOT_INO) % BFS_INODES_PER_BLOCK;
-		unsigned long sblock, eblock;
+		unsigned long eblock;
 
 		if (!off) {
 			brelse(bh);
@@ -387,7 +387,6 @@ static int bfs_fill_super(struct super_block *s, void *data, int silent)
 		set_bit(i, info->si_imap);
 		info->si_freeb -= BFS_FILEBLOCKS(di);
 
-		sblock =  le32_to_cpu(di->i_sblock);
 		eblock =  le32_to_cpu(di->i_eblock);
 		if (eblock > info->si_lf_eblk)
 			info->si_lf_eblk = eblock;
-- 
1.5.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/9] bfs: assorted cleanups, Dmitri Vorobiev, (Thu Jan 24, 3:31 pm)
[PATCH 1/9] bfs: remove a useless variable, Dmitri Vorobiev, (Thu Jan 24, 3:32 pm)
[PATCH 2/9] bfs: coding style cleanup in fs/bfs/inode.c, Dmitri Vorobiev, (Thu Jan 24, 3:32 pm)
[PATCH 3/9] bfs: coding style cleanup in fs/bfs/bfs.h, Dmitri Vorobiev, (Thu Jan 24, 3:32 pm)
[PATCH 4/9] bfs: coding style cleanup in fs/bfs/dir.c, Dmitri Vorobiev, (Thu Jan 24, 3:32 pm)
[PATCH 6/9] bfs: coding style cleanup in fs/bfs/file.c, Dmitri Vorobiev, (Thu Jan 24, 3:32 pm)
[PATCH 8/9] bfs: remove multiple assignments, Dmitri Vorobiev, (Thu Jan 24, 3:32 pm)
[PATCH 9/9] bfs: use the proper header file for inclusion, Dmitri Vorobiev, (Thu Jan 24, 3:32 pm)
Re: [PATCH 0/9] bfs: assorted cleanups, Dmitri Vorobiev, (Fri Jan 25, 3:25 am)