Home » Mailing list archives » linux-kernel » 2008 » January » 24

Re: [patch 07/26] Add INIT_ARRAY() to kernel.h (update 2)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Mathieu Desnoyers <mathieu.desnoyers@...>
To: Stefan Richter <stefanr@...>
Cc: Randy Dunlap <randy.dunlap@...>, <akpm@...>, Ingo Molnar <mingo@...>, <linux-kernel@...>
Subject: Re: [patch 07/26] Add INIT_ARRAY() to kernel.h (update 2)
Date: Thursday, January 24, 2008 - 6:10 pm

Array initializers in the body of a function causes unbalanced brackets which
syntax highlighting editors such as vim have problems with. Fix this by creating
the INIT_ARRAY() macro.

It is used to declare arguments passed as function parameters such as:
text_poke(addr, INIT_ARRAY(unsigned char, 0xf0, len), len);

Changelog :
- [len] -> []
- Remove whitespaces.
- Fixed Jan's suggestion which was not checkpatch.pl-safe.
- More informative patch header.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
CC: Jan Engelhardt <jengelh@computergmbh.de>
CC: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 include/linux/kernel.h |    2 ++
 1 file changed, 2 insertions(+)

Index: linux-2.6-lttng.mm/include/linux/kernel.h
===================================================================
--- linux-2.6-lttng.mm.orig/include/linux/kernel.h	2008-01-24 15:53:04.000000000 -0500
+++ linux-2.6-lttng.mm/include/linux/kernel.h	2008-01-24 15:53:25.000000000 -0500
@@ -423,4 +423,6 @@ struct sysinfo {
 #define NUMA_BUILD 0
 #endif
 
+#define INIT_ARRAY(type, val, len) ((type[]) {[0 ... (len)-1] = (val)})
+
 #endif

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 07/26] Add INIT_ARRAY() to kernel.h, Mathieu Desnoyers, (Thu Jan 24, 4:27 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h, H. Peter Anvin, (Thu Jan 24, 7:03 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h, Randy Dunlap, (Thu Jan 24, 4:58 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h, Mathieu Desnoyers, (Thu Jan 24, 5:04 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h, Jan Engelhardt, (Fri Jan 25, 4:03 am)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h, H. Peter Anvin, (Thu Jan 24, 7:04 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h, Mathieu Desnoyers, (Fri Jan 25, 9:14 am)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h, Stefan Richter, (Thu Jan 24, 6:02 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h (update 2), Mathieu Desnoyers, (Thu Jan 24, 6:10 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h (update 2), Alexey Dobriyan, (Thu Jan 24, 6:50 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h, Jan Engelhardt, (Thu Jan 24, 4:39 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h (updated), Mathieu Desnoyers, (Thu Jan 24, 4:54 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h (updated), Jan Engelhardt, (Thu Jan 24, 5:08 pm)
Re: [patch 07/26] Add INIT_ARRAY() to kernel.h (updated), Mathieu Desnoyers, (Thu Jan 24, 5:18 pm)