Re: [PATCH 23/27] NFS: Fix memory leak [try #2] | KernelTrap

Re: [PATCH 23/27] NFS: Fix memory leak [try #2]

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Trond Myklebust <Trond.Myklebust@...>

To: David Howells <dhowells@...>

Cc: <nfsv4@...>, <linux-kernel@...>, <linux-fsdevel@...>, <selinux@...>, <linux-security-module@...>

Subject: Re: [PATCH 23/27] NFS: Fix memory leak [try #2]

Date: Thursday, January 24, 2008 - 5:15 pm

On Wed, 2008-01-23 at 17:22 +0000, David Howells wrote:
quoted text> Fix a memory leak whereby multiple clientaddr=xxx mount options just overwrite
> the duplicated client_address option pointer, without freeing the old memory.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
> 
>  fs/nfs/super.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index 0b0c72a..7f5e747 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -936,6 +936,7 @@ static int nfs_parse_mount_options(char *raw,
>  			string = match_strdup(args);
>  			if (string == NULL)
>  				goto out_nomem;
> +			kfree(mnt->client_address);
>  			mnt->client_address = string;
>  			break;
>  		case Opt_mountaddr:

Thanks. This fix has already been applied to the NFS git tree.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/27] Permit filesystem local caching [try #2], David Howells, (Wed Jan 23, 1:20 pm)

[PATCH 27/27] NFS: Separate caching by superblock, explicitl..., David Howells, (Wed Jan 23, 1:23 pm)

[PATCH 24/27] NFS: Use local caching [try #2], David Howells, (Wed Jan 23, 1:22 pm)

Re: [PATCH 24/27] NFS: Use local caching [try #2], Chuck Lever, (Thu Jan 24, 5:22 pm)

Re: [PATCH 24/27] NFS: Use local caching [try #2], David Howells, (Thu Feb 7, 6:57 am)

Re: [PATCH 24/27] NFS: Use local caching [try #2], David Howells, (Tue Jan 29, 11:25 pm)

Re: [PATCH 24/27] NFS: Use local caching [try #2], Chuck Lever, (Wed Jan 30, 6:36 pm)

Re: [PATCH 24/27] NFS: Use local caching [try #2], David Howells, (Thu Jan 31, 7:29 pm)

Re: [PATCH 24/27] NFS: Use local caching [try #2], Trond Myklebust, (Wed Jan 30, 2:46 am)

Re: [PATCH 24/27] NFS: Use local caching [try #2], Trond Myklebust, (Thu Jan 24, 5:08 pm)

[PATCH 26/27] NFS: Display local caching state [try #2], David Howells, (Wed Jan 23, 1:22 pm)

[PATCH 25/27] NFS: Configuration and mount option changes to..., David Howells, (Wed Jan 23, 1:22 pm)

Re: [PATCH 25/27] NFS: Configuration and mount option change..., Trond Myklebust, (Thu Jan 24, 5:14 pm)

[PATCH 22/27] CacheFiles: A cache that backs onto a mounted ..., David Howells, (Wed Jan 23, 1:22 pm)

[PATCH 21/27] CacheFiles: Export things for CacheFiles [try ..., David Howells, (Wed Jan 23, 1:22 pm)

[PATCH 23/27] NFS: Fix memory leak [try #2], David Howells, (Wed Jan 23, 1:22 pm)

Re: [PATCH 23/27] NFS: Fix memory leak [try #2], Trond Myklebust, (Thu Jan 24, 5:15 pm)

[PATCH 20/27] CacheFiles: Permit the page lock state to be m..., David Howells, (Wed Jan 23, 1:22 pm)

[PATCH 19/27] CacheFiles: Add a hook to write a single page ..., David Howells, (Wed Jan 23, 1:22 pm)

[PATCH 16/27] FS-Cache: Generic filesystem caching facility ..., David Howells, (Wed Jan 23, 1:22 pm)

[PATCH 18/27] CacheFiles: Be consistent about the use of map..., David Howells, (Wed Jan 23, 1:22 pm)

[PATCH 17/27] CacheFiles: Add missing copy_page export for i..., David Howells, (Wed Jan 23, 1:22 pm)

[PATCH 15/27] FS-Cache: Provide an add_wait_queue_tail() fun..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 14/27] FS-Cache: Recruit a couple of page flags for c..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 13/27] FS-Cache: Release page->private after faile..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 12/27] Security: Make NFSD work with detached securit..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 11/27] Security: Allow kernel services to override LS..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 10/27] Security: Add a kernel_service object class to..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 09/27] Security: Pre-add additional non-caching class..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 07/27] Security: De-embed task security record from t..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 08/27] Add a secctx_to_secid() LSM hook to go along w..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 06/27] Security: Separate task security context from ..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 05/27] Security: Change current->fs[ug]id to curre..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 04/27] KEYS: Add keyctl function to get a security la..., David Howells, (Wed Jan 23, 1:21 pm)

[PATCH 01/27] KEYS: Increase the payload size when instantia..., David Howells, (Wed Jan 23, 1:20 pm)

[PATCH 03/27] KEYS: Allow the callout data to be passed as a..., David Howells, (Wed Jan 23, 1:20 pm)

[PATCH 02/27] KEYS: Check starting keyring as part of search..., David Howells, (Wed Jan 23, 1:20 pm)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	[GIT PATCH] driver core patches against 2.6.24
holzheu	Re: [RFC/PATCH] Documentation of kernel messages
FUJITA Tomonori	Re: Integration of SCST in the mainstream Linux kernel
openbsd-misc:

git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 13/37] dccp: Deprecate Ack Ratio sysctl
Arjan van de Ven	Re: [GIT]: Networking
Evgeniy Polyakov	Re: [BUG] New Kernel Bugs

Colocation donated by:

Who's online

There are currently 2 users and 955 guests online.

Online users

Syndicate