Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Pavel Machek <pavel@...>

Cc: Miklos Szeredi <miklos@...>, <akpm@...>, <linux-fsdevel@...>, <linux-kernel@...>, <util-linux-ng@...>, <linuxram@...>, <viro@...>, <hch@...>, <a.p.zijlstra@...>

Subject: Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo

Date: Wednesday, January 23, 2008 - 3:02 pm

Pavel Machek wrote:
quoted text> On Sun 2008-01-20 09:23:00, Miklos Szeredi wrote:
>>> Miklos Szeredi wrote:
>>>> - for mount ID's use IDA (from the IDR library) instead of a 32bit
>>>>   counter, which could overflow
>>> IDAs tend to get reused quickly, which can cause race conditions.  Any 
>>> reason not to just use a 64-bit counter?
>> They tend to become hard to parse/compare for humans after a while.
>> And all this is basically only for humans, so race conditions don't
>> really matter.  Also a changed mount with a reused ID is easily
>> identified by comparing the other fields.
> 
> Hmm, smart humans only compare last few digits if they don't care
> about 100% reliability, and dumb software compares 64bits easily...
> 							Pavel

Indeed.

And this is most certainly NOT only for humans, and race conditions most 
certainly matter.

	-hpa
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Miklos Szeredi, (Sat Jan 19, 7:05 am)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Ram Pai, (Mon Jan 21, 3:48 pm)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Miklos Szeredi, (Mon Jan 21, 5:25 pm)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Ram Pai, (Mon Jan 21, 5:53 pm)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Miklos Szeredi, (Mon Jan 21, 6:09 pm)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Serge E. Hallyn, (Tue Jan 22, 4:56 pm)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Jan Engelhardt, (Sun Jan 20, 7:20 am)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Miklos Szeredi, (Sun Jan 20, 8:20 am)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, H. Peter Anvin, (Sun Jan 20, 1:41 am)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Miklos Szeredi, (Sun Jan 20, 4:23 am)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Pavel Machek, (Wed Jan 23, 9:49 am)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, H. Peter Anvin, (Wed Jan 23, 3:02 pm)

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo, Miklos Szeredi, (Wed Jan 23, 3:32 pm)


linux-kernel:
Thomas Gleixner	Re: Linux 2.6.21-rc1
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
James Bottomley	[Ksummit-2008-discuss] Fixing the Kernel Janitors project
James Morris	Re: LSM conversion to static interface
git:

linux-netdev:
Natalie Protasevich	[BUG] New Kernel Bugs
Christoph Hellwig	Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
Linus Torvalds	Re: [GIT]: Networking
Jarek Poplawski	[PATCH take 2] pkt_sched: Protect gen estimators under est_lock.
openbsd-misc:

Re: [RFC][PATCH] VFS: create /proc/<pid>/mountinfo

Online users