Home » Mailing list archives » linux-kernel » 2008 » January » 23

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Daniel Walker <dwalker@...>
To: Steven Rostedt <rostedt@...>
Cc: LKML <linux-kernel@...>, Ingo Molnar <mingo@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, Peter Zijlstra <a.p.zijlstra@...>, Christoph Hellwig <hch@...>, Mathieu Desnoyers <mathieu.desnoyers@...>, Gregory Haskins <ghaskins@...>, Arnaldo Carvalho de Melo <acme@...>, Thomas Gleixner <tglx@...>, Tim Bird <tim.bird@...>, Sam Ravnborg <sam@...>, Frank Ch. Eigler <fche@...>, Jan Kiszka <jan.kiszka@...>, John Stultz <johnstul@...>, Arjan van de Ven <arjan@...>, Steven Rostedt <srostedt@...>
Subject: Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled
Date: Wednesday, January 23, 2008 - 1:43 pm

> 	if (wake_klogd && !runqueue_is_locked())

Do you really need to call it with the runqueue lock held .. There are
other issue with the calls at that level.. For instance in -rt these
call can actually hang the system in the console laying from inside
printk (something I reported more than 6 months ago) .. It would be
better to move them around the scheduler rather than inside it..

Daniel

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts..., Steven Rostedt, (Wed Jan 23, 12:02 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Daniel Walker, (Wed Jan 23, 1:06 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Mathieu Desnoyers, (Wed Jan 23, 1:25 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Pavel Machek, (Thu Jan 24, 6:35 am)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Tim Bird, (Wed Jan 23, 1:49 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Steven Rostedt, (Wed Jan 23, 1:27 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Pavel Machek, (Thu Jan 24, 6:36 am)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Daniel Walker, (Wed Jan 23, 1:43 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Steven Rostedt, (Wed Jan 23, 2:18 pm)
[PATCH] defer printks in irqs, Tim Bird, (Thu Jan 24, 6:42 pm)
Re: [PATCH] defer printks in irqs, Peter Zijlstra, (Thu Jan 24, 6:48 pm)
Re: [PATCH] defer printks in irqs, Tim Bird, (Thu Jan 24, 7:23 pm)
Re: [PATCH] defer printks in irqs, Andrew Morton, (Sun Jan 27, 2:01 am)
Re: [PATCH] defer printks in irqs, Tim Bird, (Mon Jan 28, 5:14 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Daniel Walker, (Wed Jan 23, 2:28 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Steven Rostedt, (Wed Jan 23, 2:43 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Daniel Walker, (Wed Jan 23, 2:50 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Daniel Walker, (Wed Jan 23, 3:59 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Mathieu Desnoyers, (Wed Jan 23, 1:32 pm)