Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Steven Rostedt <rostedt@...>
Cc: Daniel Walker <dwalker@...>, LKML <linux-kernel@...>, Ingo Molnar <mingo@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, Peter Zijlstra <a.p.zijlstra@...>, Christoph Hellwig <hch@...>, Gregory Haskins <ghaskins@...>, Arnaldo Carvalho de Melo <acme@...>, Thomas Gleixner <tglx@...>, Tim Bird <tim.bird@...>, Sam Ravnborg <sam@...>, Frank Ch. Eigler <fche@...>, Jan Kiszka <jan.kiszka@...>, John Stultz <johnstul@...>, Arjan van de Ven <arjan@...>, Steven Rostedt <srostedt@...>
Date: Wednesday, January 23, 2008 - 1:32 pm

* Steven Rostedt (rostedt@goodmis.org) wrote:


FYI :

kernel/panic.c

NORET_TYPE void panic(const char * fmt, ...)
{
....
bust_spinlocks(1);
...
bust_spinlocks(0);
...

In bust_spinlocks :


void __attribute__((weak)) bust_spinlocks(int yes)
{
        if (yes) {
                ++oops_in_progress;
        } else {
#ifdef CONFIG_VT
                unblank_screen();
#endif
                if (--oops_in_progress == 0)
                        wake_up_klogd();
        }
}

Where the final wake_up happens while oops_in_progress is 0, but
interrupts are still disabled.

So about my previous email, proposing testing oops_in_progress, it just
won't work.

Mathieu


-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Mathieu Desnoyers, (Wed Jan 23, 1:25 pm)
[PATCH] defer printks in irqs, Tim Bird, (Thu Jan 24, 6:42 pm)
Re: [PATCH] defer printks in irqs, Peter Zijlstra, (Thu Jan 24, 6:48 pm)
Re: [PATCH] defer printks in irqs, Tim Bird, (Thu Jan 24, 7:23 pm)
Re: [PATCH] defer printks in irqs, Andrew Morton, (Sun Jan 27, 2:01 am)
Re: [PATCH] defer printks in irqs, Tim Bird, (Mon Jan 28, 5:14 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Mathieu Desnoyers, (Wed Jan 23, 1:32 pm)