Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Steven Rostedt <rostedt@...>
Cc: LKML <linux-kernel@...>, Ingo Molnar <mingo@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, Peter Zijlstra <a.p.zijlstra@...>, Christoph Hellwig <hch@...>, Mathieu Desnoyers <mathieu.desnoyers@...>, Gregory Haskins <ghaskins@...>, Arnaldo Carvalho de Melo <acme@...>, Thomas Gleixner <tglx@...>, Tim Bird <tim.bird@...>, Sam Ravnborg <sam@...>, Frank Ch. Eigler <fche@...>, Jan Kiszka <jan.kiszka@...>, John Stultz <johnstul@...>, Arjan van de Ven <arjan@...>, Steven Rostedt <srostedt@...>
Date: Wednesday, January 23, 2008 - 1:06 pm

On Wed, 2008-01-23 at 11:02 -0500, Steven Rostedt wrote:


This causes a regression .. When printk is called during an OOPS in
kernels without this change then the OOPS will get logged, since the
logging process (klogd) is woken to handle the messages.. If you apply
this change klogd doesn't wakeup, and hence doesn't log the oops.. So if
you remove the wakeup here you have to add it someplace else to maintain
the logging ..

(I'm not theorizing here, I have defects logged against this specific
piece of code..)

Daniel

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Daniel Walker, (Wed Jan 23, 1:06 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Mathieu Desnoyers, (Wed Jan 23, 1:25 pm)
[PATCH] defer printks in irqs, Tim Bird, (Thu Jan 24, 6:42 pm)
Re: [PATCH] defer printks in irqs, Peter Zijlstra, (Thu Jan 24, 6:48 pm)
Re: [PATCH] defer printks in irqs, Tim Bird, (Thu Jan 24, 7:23 pm)
Re: [PATCH] defer printks in irqs, Andrew Morton, (Sun Jan 27, 2:01 am)
Re: [PATCH] defer printks in irqs, Tim Bird, (Mon Jan 28, 5:14 pm)
Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interr..., Mathieu Desnoyers, (Wed Jan 23, 1:32 pm)