Home » Mailing list archives » linux-kernel » 2008 » January » 23

Re: [PATCH] x86_64: should use array directly for early_ptr

Previous thread: 24rc8: unregister_netdevice: waiting for ... to become free. Usage count = 1? by Soeren Sonnenburg on Wednesday, January 23, 2008 - 2:42 am. (4 messages)

Next thread: [RFC] [PATCH] cgroup: limit network bandwidth by Andrea Righi on Wednesday, January 23, 2008 - 5:09 am. (6 messages)
[view original message]
From: Yinghai Lu <Yinghai.Lu@...>
To: Ingo Molnar <mingo@...>
Cc: Mike Travis <travis@...>, Christoph Lameter <clameter@...>, LKML <linux-kernel@...>
Subject: [PATCH] x86_64: remove duplicated line about x86_bios_cpu_apicid_early_ptr
Date: Wednesday, January 23, 2008 - 4:56 am

[PATCH] x86_64: remove duplicated line about x86_bios_cpu_apicid_early_ptr


Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>


diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c

index 2643a8f..b587166 100644

--- a/arch/x86/kernel/setup_64.c

+++ b/arch/x86/kernel/setup_64.c

@@ -349,7 +349,6 @@ void __init setup_arch(char **cmdline_p)

 #ifdef CONFIG_NUMA

 	x86_cpu_to_node_map_early_ptr = (void *)&x86_cpu_to_node_map_init;

 #endif

-	x86_bios_cpu_apicid_early_ptr = (void *)&x86_bios_cpu_apicid_init;

 #endif


 #ifdef CONFIG_ACPI

--
[view original message]
From: Mike Travis <travis@...>
To: Yinghai Lu <Yinghai.Lu@...>
Cc: Ingo Molnar <mingo@...>, Christoph Lameter <clameter@...>, LKML <linux-kernel@...>
Subject: Re: [PATCH] x86_64: remove duplicated line about x86_bios_cpu_apicid_early_ptr
Date: Wednesday, January 23, 2008 - 10:16 am

Thanks Yinghai!


I wonder how this got past my testing (I do build and test !SMP and !NUMA

versions.)  I'll check into this.


Regards,

Mike

--
[view original message]
From: Mike Travis <travis@...>
To: Yinghai Lu <Yinghai.Lu@...>
Cc: Ingo Molnar <mingo@...>, Christoph Lameter <clameter@...>, LKML <linux-kernel@...>
Subject: Re: [PATCH] x86_64: remove duplicated line about x86_bios_cpu_apicid_early_ptr
Date: Wednesday, January 23, 2008 - 10:37 am

--
[view original message]
From: Yinghai Lu <Yinghai.Lu@...>
To: Ingo Molnar <mingo@...>
Cc: Mike Travis <travis@...>, Christoph Lameter <clameter@...>, LKML <linux-kernel@...>
Subject: [PATCH] x86_64: should use array directly for early_ptr
Date: Wednesday, January 23, 2008 - 5:27 am

[PATCH] x86_64: should use array directly for early_ptr


Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>


--- a/arch/x86/kernel/setup_64.c	2008-01-23 01:21:06.000000000 -0800

+++ b/arch/x86/kernel/setup_64.c	2008-01-23 01:21:24.000000000 -0800

@@ -344,10 +344,10 @@


 #ifdef CONFIG_SMP

 	/* setup to use the early static init tables during kernel startup */

-	x86_cpu_to_apicid_early_ptr = (void *)&x86_cpu_to_apicid_init;

-	x86_bios_cpu_apicid_early_ptr = (void *)&x86_bios_cpu_apicid_init;

+	x86_cpu_to_apicid_early_ptr = (void *)x86_cpu_to_apicid_init;

+	x86_bios_cpu_apicid_early_ptr = (void *)x86_bios_cpu_apicid_init;

 #ifdef CONFIG_NUMA

-	x86_cpu_to_node_map_early_ptr = (void *)&x86_cpu_to_node_map_init;

+	x86_cpu_to_node_map_early_ptr = (void *)x86_cpu_to_node_map_init;

 #endif

 #endif


--
[view original message]
From: Mike Travis <travis@...>
To: Yinghai Lu <Yinghai.Lu@...>
Cc: Ingo Molnar <mingo@...>, Christoph Lameter <clameter@...>, LKML <linux-kernel@...>
Subject: Re: [PATCH] x86_64: should use array directly for early_ptr
Date: Wednesday, January 23, 2008 - 10:18 am

Also Thanks!


-Mike

--
Previous thread: 24rc8: unregister_netdevice: waiting for ... to become free. Usage count = 1? by Soeren Sonnenburg on Wednesday, January 23, 2008 - 2:42 am. (4 messages)

Next thread: [RFC] [PATCH] cgroup: limit network bandwidth by Andrea Righi on Wednesday, January 23, 2008 - 5:09 am. (6 messages)