Hi, I'm not qualified to comment on the code, but here are some suggestions on config option and comments. Cheers, FJP Ryo Tsuruta wrote:s/band width/bandwidth/ (it seems to be used correctly elsewhere, but you may want to double-check) s/band-width/bandwidth/ The help should probably be a bit more verbose as this does not tell anybody much who has not already read the documentation. Maybe something like: <snip> This device-mapper target allows to define how the available bandwith of a storage device should be shared between processes or cgroups. Information on how to use dm-band is available in: Documentation/device-mapper/band.txt </snip> ^^^^^^^^^^^ s/a right/the right/ "The larger the return value, the higher the priority [...]" s/when there exist some BIOs blocked/if some BIOs exist that are blocked/ ? "none of them can't" : the double negative looks incorrect (and should be avoided anyway) s/have/has/ "has to do something" : that's rather vague... --
| Kok, Auke | Re: -mm merge plans for 2.6.23 - ioat/dma engine |
| Jeff Garzik | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Greg Kroah-Hartman | [PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO |
| Matthew Garrett | [PATCH] Remove process freezer from suspend to RAM pathway |
| Gerrit Renker | [PATCH 15/37] dccp: Set per-connection CCIDs via socket options |
| David Miller | [GIT]: Networking |
| Jarek Poplawski | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Jens Axboe | Re: [BUG] New Kernel Bugs |
git: | |
