Re: 24rc8: unregister_netdevice: waiting for ... to become free. Usage count = 1?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <kernel@...>
Cc: <linux-kernel@...>
Date: Wednesday, January 23, 2008 - 2:44 am

From: Soeren Sonnenburg <kernel@nn7.de>
Date: Wed, 23 Jan 2008 07:42:21 +0100


Current GIT already has a fix for this, attached below:

[NEIGH]: Revert 'Fix race between neigh_parms_release and neightbl_fill_parms'

Commit 9cd40029423701c376391da59d2c6469672b4bed (Fix race between
neigh_parms_release and neightbl_fill_parms) introduced device
reference counting regressions for several people, see:

	http://bugzilla.kernel.org/show_bug.cgi?id=9778

for example.

Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index cc8a2f1..29b8ee4 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1316,6 +1316,8 @@ void neigh_parms_release(struct neigh_table *tbl, struct neigh_parms *parms)
 			*p = parms->next;
 			parms->dead = 1;
 			write_unlock_bh(&tbl->lock);
+			if (parms->dev)
+				dev_put(parms->dev);
 			call_rcu(&parms->rcu_head, neigh_rcu_free_parms);
 			return;
 		}
@@ -1326,8 +1328,6 @@ void neigh_parms_release(struct neigh_table *tbl, struct neigh_parms *parms)
 
 void neigh_parms_destroy(struct neigh_parms *parms)
 {
-	if (parms->dev)
-		dev_put(parms->dev);
 	kfree(parms);
 }
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
24rc8: unregister_netdevice: waiting for ... to become free...., Soeren Sonnenburg, (Wed Jan 23, 2:42 am)
Re: 24rc8: unregister_netdevice: waiting for ... to become f..., David Miller, (Wed Jan 23, 2:44 am)
Re: 24rc8: unregister_netdevice: waiting for ... to become f..., Soeren Sonnenburg, (Tue Jan 29, 4:59 am)
Re: 24rc8: unregister_netdevice: waiting for ... to become f..., Soeren Sonnenburg, (Wed Jan 23, 3:49 am)