Home » Mailing list archives » linux-kernel » 2008 » January » 23

Re: [PATCH 06/26] atl1: update initialization parameters

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jeff Garzik
Subject: Re: [PATCH 06/26] atl1: update initialization parameters
Date: Tuesday, January 22, 2008 - 7:19 pm

Jay Cliburn wrote:

Since these changes are not simply moving code around, we really do need 
full explanations for them, and to understand their need.

Blindly copying code from an exterior driver is pointless, and no way at 
all to run an engineering process.

If the driver is not going to get the review and attention necessary, 
bug fixes and feedback attended-to, then there's not much point in 
having this driver in the kernel at all.

You will only lead yourself to frustration, if you set up a system where 
changes only flow one way.  That's not how Linux development is done at all.

	Jeff



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/26] atl1: divide and modernize, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 01/26] atl1: relocate atl1 driver to /drivers/net/atlx, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 02/26] atl1: move common functions to atlx files, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 03/26] atl1: fix broken TSO, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 04/26] atl1: add ethtool register dump, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 05/26] atl1: print debug info if rrd error, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 06/26] atl1: update initialization parameters, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 07/26] atl1: clarify max rx frame size, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 09/26] atl1: refactor tx processing, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 11/26] atl1: refactor initialization and startup, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 12/26] atl1: refactor atl1_probe, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 13/26] atl1: refactor interrupt handling, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 14/26] atl1: move stray defines to header file, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 15/26] atl1: tidy up ring management, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 16/26] atl1: modernize check link function, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 17/26] atl1: update phy config function, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 18/26] atl1: make function static, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 19/26] atl1: modernize down/up functions, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 20/26] atl1: update change mtu, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 21/26] atl1: update atl1_close, jacliburn, (Mon Dec 31, 6:59 pm)
[PATCH 22/26] atl1: update netpoll, jacliburn, (Mon Dec 31, 7:00 pm)
[PATCH 23/26] atl1: update shutdown and remove functions, jacliburn, (Mon Dec 31, 7:00 pm)
[PATCH 24/26] atl1: update wake-on-lan, jacliburn, (Mon Dec 31, 7:00 pm)
[PATCH 25/26] atl1: add NAPI support, jacliburn, (Mon Dec 31, 7:00 pm)
Re: [PATCH 25/26] atl1: add NAPI support, Joonwoo Park, (Mon Dec 31, 11:09 pm)
Re: [PATCH 25/26] [REVISED] atl1: add NAPI support, Jay Cliburn, (Tue Jan 1, 11:15 am)
RE: [PATCH 25/26] [REVISED] atl1: add NAPI support, Joonwoo Park, (Tue Jan 1, 7:56 pm)
Re: [PATCH 25/26] [REVISED] atl1: add NAPI support, David Miller, (Tue Jan 1, 8:07 pm)
Re: [PATCH 04/26] atl1: add ethtool register dump, Jeff Garzik, (Tue Jan 22, 2:54 am)
Re: [PATCH 05/26] atl1: print debug info if rrd error, Jeff Garzik, (Tue Jan 22, 2:55 am)
Re: [PATCH 06/26] atl1: update initialization parameters, Jeff Garzik, (Tue Jan 22, 2:56 am)
Re: [PATCH 09/26] atl1: refactor tx processing, Jeff Garzik, (Tue Jan 22, 2:58 am)
Re: [PATCH 13/26] atl1: refactor interrupt handling, Jeff Garzik, (Tue Jan 22, 2:59 am)
Re: [PATCH 19/26] atl1: modernize down/up functions, Jeff Garzik, (Tue Jan 22, 3:01 am)
Re: [PATCH 09/26] atl1: refactor tx processing, Jay Cliburn, (Tue Jan 22, 5:31 pm)
Re: [PATCH 06/26] atl1: update initialization parameters, Jay Cliburn, (Tue Jan 22, 7:13 pm)
Re: [PATCH 06/26] atl1: update initialization parameters, Jeff Garzik, (Tue Jan 22, 7:19 pm)
Re: [PATCH 06/26] atl1: update initialization parameters, Chris Snook, (Tue Jan 22, 7:30 pm)
Re: [PATCH 09/26] atl1: refactor tx processing, Jay Cliburn, (Thu Jan 24, 6:00 pm)
Re: [PATCH 09/26] atl1: refactor tx processing, Chris Snook, (Thu Jan 24, 6:08 pm)
Re: [PATCH 09/26] atl1: refactor tx processing, Jeff Garzik, (Thu Jan 24, 8:01 pm)