Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE | KernelTrap

Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Harvey Harrison <harvey.harrison@...>

To: Ingo Molnar <mingo@...>

Cc: H. Peter Anvin <hpa@...>, Ian Campbell <ijc@...>, Mika <mika.penttila@...>, <linux-kernel@...>, Thomas Gleixner <tglx@...>, Ingo Molnar <mingo@...>, Eric W. Biederman <ebiederm@...>

Subject: Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE

Date: Tuesday, January 22, 2008 - 5:35 pm

On Tue, 2008-01-22 at 22:04 +0100, Ingo Molnar wrote:
quoted text> * Harvey Harrison <harvey.harrison@gmail.com> wrote:
> 
> > nx_enabled can only be set to non-zero when CONFIG_X86_PAE is set.  
> > The only use not currently inside a CONFIG_X86_PAE block is the 
> > definition, the declaration and a conditional unlikely test in 
> > fault_32.c (is_prefetch).
> > 
> > When !CONFIG_X86_PAE, is_prefetch always returns 0 immediately as 
> > nx_enabled is always 0.
> > 
> > When CONFIG_X86_PAE, the test is preserved, but the test against the 
> > cpu model and stepping is deleted, this may not be correct.
> 
> thanks, applied.

Hmmm, the extern nx_enabled in page_32.h is already within an
ifndef __ASSEMBLY__ block, so I'm not sure how wakeup_32.S could
be using it.  Thoughts?

Harvey

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] x86/voyager: Switch voyager memory detection to earl..., Ian Campbell, (Sat Jan 19, 12:08 pm)

[PATCH] x86: Construct 32 bit boot time page tables in nativ..., Ian Campbell, (Sat Jan 19, 12:08 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Mika Penttilä, (Sun Jan 20, 2:30 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ian Campbell, (Mon Jan 21, 5:23 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Mon Jan 21, 5:38 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ian Campbell, (Mon Jan 21, 5:46 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Mon Jan 21, 10:16 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ian Campbell, (Tue Jan 22, 1:36 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Tue Jan 22, 2:23 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ian Campbell, (Tue Jan 22, 3:48 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Tue Jan 22, 4:00 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ingo Molnar, (Tue Jan 22, 4:36 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ian Campbell, (Wed Jan 23, 4:52 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Wed Jan 23, 9:06 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ian Campbell, (Thu Jan 24, 5:39 am)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 6:06 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Thu Jan 24, 6:35 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 6:39 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Thu Jan 24, 6:58 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 7:08 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Thu Jan 24, 7:40 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 7:51 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Pavel Machek, (Thu Jan 24, 8:20 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 8:27 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Pavel Machek, (Fri Jan 25, 3:49 am)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Fri Jan 25, 6:02 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ingo Molnar, (Mon Jan 28, 11:00 am)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ingo Molnar, (Mon Jan 28, 12:12 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Mon Jan 28, 1:02 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ingo Molnar, (Fri Feb 1, 9:51 am)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Fri Feb 1, 10:28 am)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ingo Molnar, (Fri Feb 1, 10:54 am)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Len Brown, (Fri Feb 1, 6:55 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Mon Jan 28, 11:25 am)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Pavel Machek, (Mon Jan 28, 3:40 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Mon Jan 28, 4:26 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Mon Jan 28, 4:44 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Mon Jan 28, 4:50 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Mon Jan 28, 5:28 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Mon Jan 28, 6:02 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Mon Jan 28, 4:31 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Mon Jan 28, 4:59 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Mon Jan 28, 3:51 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Mon Jan 28, 4:03 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Mon Jan 28, 4:06 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Mon Jan 28, 4:28 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Pavel Machek, (Fri Jan 25, 6:11 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Eric W. Biederman, (Thu Jan 24, 10:16 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 10:25 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Rafael J. Wysocki, (Thu Jan 24, 8:46 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 9:08 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 7:44 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Thu Jan 24, 7:51 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 8:02 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Thu Jan 24, 8:11 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 8:15 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Thu Jan 24, 8:31 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Thu Jan 24, 8:37 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Eric W. Biederman, (Thu Jan 24, 10:56 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Jeremy Fitzhardinge, (Fri Jan 25, 12:41 am)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Eric W. Biederman, (Fri Jan 25, 7:07 am)

[PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE, Harvey Harrison, (Tue Jan 22, 5:00 pm)

Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE, Harvey Harrison, (Tue Jan 22, 5:07 pm)

Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE, Ingo Molnar, (Tue Jan 22, 5:04 pm)

Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE, Harvey Harrison, (Tue Jan 22, 5:35 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ian Campbell, (Tue Jan 22, 4:52 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Tue Jan 22, 5:00 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ian Campbell, (Tue Jan 22, 6:21 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Tue Jan 22, 4:43 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ingo Molnar, (Tue Jan 22, 4:45 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Andi Kleen, (Sat Jan 19, 7:07 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ian Campbell, (Sun Jan 20, 12:44 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Andi Kleen, (Sun Jan 20, 1:39 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Sun Jan 20, 2:48 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Ingo Molnar, (Tue Jan 22, 6:05 am)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Tue Jan 22, 12:23 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., Andi Kleen, (Sun Jan 20, 2:55 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Sun Jan 20, 2:54 pm)

Re: [PATCH] x86: Construct 32 bit boot time page tables in n..., H. Peter Anvin, (Sat Jan 19, 7:50 pm)

Navigation

Popular discussions


linux-kernel:
Trent Piepho	[PATCH] [POWERPC] Improve (in\|out)_beXX() asm code
Andi Kleen	[PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu
Andi Kleen	[PATCH] [0/45] x86 2.6.24 patches review I
Stoyan Gaydarov	From 2.4 to 2.6 to 2.7?
git:

linux-netdev:
Jarek Poplawski	Re: HTB accuracy for high speed
David Miller	Re: [GIT]: Networking
Gerrit Renker	[PATCH 13/37] dccp: Deprecate Ack Ratio sysctl
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Who's online

There are currently 8 users and 855 guests online.

Online users

Syndicate