Re: [PATCH] sched: don't take a mutex from interrupt context

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Peter Zijlstra <a.p.zijlstra@...>

Cc: Dave Young <hidave.darkstar@...>, <linux-kernel@...>, <mingo@...>

Subject: Re: [PATCH] sched: don't take a mutex from interrupt context

Date: Tuesday, January 22, 2008 - 12:51 pm

On Tue, Jan 22, 2008 at 05:25:38PM +0100, Peter Zijlstra wrote:
quoted text> @@ -1428,9 +1428,9 @@ static void print_cfs_stats(struct seq_f
>  #ifdef CONFIG_FAIR_GROUP_SCHED
>  	print_cfs_rq(m, cpu, &cpu_rq(cpu)->cfs);
>  #endif
> -	lock_task_group_list();
> +	rcu_read_lock();
>  	for_each_leaf_cfs_rq(cpu_rq(cpu), cfs_rq)
>  		print_cfs_rq(m, cpu, cfs_rq);

Isn't there a possibility that print_cfs_rq() can block?

quoted text> -	unlock_task_group_list();
> +	rcu_read_unlock();
>  }
>  #endif
> 

-- 
Regards,
vatsa
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

WARNING: at kernel/mutex.c:134, Dave Young, (Mon Jan 21, 10:36 pm)

[PATCH] sched: don't take a mutex from interrupt context, Peter Zijlstra, (Tue Jan 22, 12:25 pm)

Re: [PATCH] sched: don't take a mutex from interrupt context, Ingo Molnar, (Tue Jan 22, 1:07 pm)

Re: [PATCH] sched: don't take a mutex from interrupt context, Srivatsa Vaddagiri, (Tue Jan 22, 12:51 pm)

Re: [PATCH] sched: don't take a mutex from interrupt context, Peter Zijlstra, (Tue Jan 22, 12:47 pm)

Re: [PATCH] sched: don't take a mutex from interrupt context, Srivatsa Vaddagiri, (Tue Jan 22, 1:23 pm)


linux-kernel:
Trent Piepho	[PATCH] [POWERPC] Improve (in\|out)_beXX() asm code
Stoyan Gaydarov	From 2.4 to 2.6 to 2.7?
Andi Kleen	[PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu
Greg Kroah-Hartman	[PATCH 013/196] Documentation: Replace obsolete "driverfs" with "sysfs".
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	Re: HTB accuracy for high speed
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	Re: [GIT]: Networking

Re: [PATCH] sched: don't take a mutex from interrupt context

Online users