[PATCH 14/16] ide: move drive->crc_count check out from check_dma_crc()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-ide@...>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@...>, <linux-kernel@...>
Date: Monday, January 21, 2008 - 7:32 pm

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-iops.c |   24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

Index: b/drivers/ide/ide-iops.c
===================================================================
--- a/drivers/ide/ide-iops.c
+++ b/drivers/ide/ide-iops.c
@@ -968,13 +968,10 @@ static ide_startstop_t reset_pollfunc (i
 static void check_dma_crc(ide_drive_t *drive)
 {
 #ifdef CONFIG_BLK_DEV_IDEDMA
-	if (drive->crc_count) {
-		ide_dma_off_quietly(drive);
-		ide_set_xfer_rate(drive, ide_auto_reduce_xfer(drive));
-		if (drive->current_speed >= XFER_SW_DMA_0)
-			ide_dma_on(drive);
-	} else
-		ide_dma_off(drive);
+	ide_dma_off_quietly(drive);
+	ide_set_xfer_rate(drive, ide_auto_reduce_xfer(drive));
+	if (drive->current_speed >= XFER_SW_DMA_0)
+		ide_dma_on(drive);
 #endif
 }
 
@@ -999,17 +996,20 @@ static void pre_reset(ide_drive_t *drive
 	else
 		drive->post_reset = 1;
 
-	if (!drive->keep_settings) {
-		if (drive->using_dma) {
+	if (drive->using_dma) {
+		if (drive->crc_count)
 			check_dma_crc(drive);
-		} else {
+		else
+			ide_dma_off(drive);
+	}
+
+	if (!drive->keep_settings) {
+		if (!drive->using_dma) {
 			drive->unmask = 0;
 			drive->io_32bit = 0;
 		}
 		return;
 	}
-	if (drive->using_dma)
-		check_dma_crc(drive);
 
 	if (HWIF(drive)->pre_reset != NULL)
 		HWIF(drive)->pre_reset(drive);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/16] ide: various fixes/cleanups, Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:30 pm)
[PATCH 16/16] ide: move check_dma_crc() to ide-dma.c, Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:32 pm)
[PATCH 15/16] ide: remove ide_auto_reduce_xfer(), Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:32 pm)
Re: [PATCH 15/16] ide: remove ide_auto_reduce_xfer(), Sergei Shtylyov, (Tue Jan 22, 12:39 pm)
[PATCH 14/16] ide: move drive->crc_count check out from c..., Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:32 pm)
[PATCH 13/16] ide: remove ide_ata66_check(), Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:32 pm)
Re: [PATCH 13/16] ide: remove ide_ata66_check(), Sergei Shtylyov, (Tue Jan 22, 12:31 pm)
[PATCH 12/16] ide: remove set_transfer(), Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:31 pm)
Re: [PATCH 12/16] ide: remove set_transfer(), Sergei Shtylyov, (Tue Jan 22, 10:24 am)
[PATCH 11/16] ide: unexport SELECT_DRIVE(), Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:31 pm)
Re: [PATCH 11/16] ide: unexport SELECT_DRIVE(), Sergei Shtylyov, (Tue Jan 22, 12:28 pm)
[PATCH 10/16] ide: use __ide_set_handler() in ide_execute_co..., Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:31 pm)
[PATCH 09/16] ide: remove SATA_*_REG macros, Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:31 pm)
[PATCH 08/16] ide: remove -&gt;nice0 and -&gt;nice2 fields f..., Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:31 pm)
[PATCH 07/16] ide: convert -&gt;straight8 field in ide_hwif_..., Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:31 pm)
[PATCH 06/16] ide: remove unused -&gt;auto_poll field from i..., Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:31 pm)
[PATCH 05/16] ide-probe: remove needless Status register reads, Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:31 pm)
[PATCH 04/16] ide-cris: use ide_execute_command(), Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:31 pm)
Re: [PATCH 04/16] ide-cris: use ide_execute_command(), Sergei Shtylyov, (Tue Jan 22, 10:34 am)
[PATCH 03/16] trm290: use ide_execute_command(), Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:30 pm)
Re: [PATCH 03/16] trm290: use ide_execute_command(), Sergei Shtylyov, (Tue Jan 22, 10:32 am)
[PATCH 02/16] ide-scsi: use ide_execute_command(), Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:30 pm)
Re: [PATCH 02/16] ide-scsi: use ide_execute_command(), Sergei Shtylyov, (Tue Jan 22, 10:32 am)
[PATCH 01/16] ide-tape: use ide_execute_command(), Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 7:30 pm)
Re: [PATCH 01/16] ide-tape: use ide_execute_command(), Sergei Shtylyov, (Tue Jan 22, 10:32 am)