[PATCH} 2.6.24-rc8-mm1 - x86_64 PAT issues with vesafb and NVidia cards

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, Gerd Knorr <kraxel@...>
Cc: <linux-kernel@...>
Date: Monday, January 21, 2008 - 2:53 pm

(Gerd Knorr cc'ed because 'git blame' says he last touched the line of code
I ended up touching - if this needs other cc:'s, will somebody who knows who
should review please add them?)

On Thu, 17 Jan 2008 02:35:14 PST, Andrew Morton said: 

This gave the NVidia binary driver indigestion:

X:2772 conflicting cache attribute d0000000-d0006000 uncached<->default

While researching this one and adding some debugging printk's and dump_stack()s,
I found that this was caused by:

[    0.444051] reserve_mattr swapper:1  setting d0000000-d0500000 to default
[    0.444055] Pid: 1, comm: swapper Not tainted 2.6.24-rc8-mm1 #4
[    0.444057]
[    0.444057] Call Trace:
[    0.444065]  [<ffffffff8034dfe7>] ? ioremap_page_range+0x17b/0x244
[    0.444069]  [<ffffffff802259ba>] reserve_mattr+0x91/0x27d
[    0.444072]  [<ffffffff80224c24>] __ioremap+0xe6/0x146
[    0.444077]  [<ffffffff806f7297>] vesafb_probe+0x196/0x6b2
...

So the vesafb driver had decided to tag an even *larger* space as 'default'..
I'm *guessing* that in fact, this area should have been non-caching (since
it's the video memory for the card), but nothing cared/flagged before.

Pigheaded-and-probably-wrong brute-force fix that works on my laptop, but
somebody who actually understands the vesafb code should check that in fact
the space *should* be non-caching.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

--- linux-2.6.24-rc8-mm1/drivers/video/vesafb.c.dist	2007-10-09 16:31:38.000000000 -0400
+++ linux-2.6.24-rc8-mm1/drivers/video/vesafb.c	2008-01-20 11:11:57.000000000 -0500
@@ -286,7 +286,7 @@ static int __init vesafb_probe(struct pl
 	info->pseudo_palette = info->par;
 	info->par = NULL;
 
-	info->screen_base = ioremap(vesafb_fix.smem_start, vesafb_fix.smem_len);
+	info->screen_base = ioremap_nocache(vesafb_fix.smem_start, vesafb_fix.smem_len);
 	if (!info->screen_base) {
 		printk(KERN_ERR
 		       "vesafb: abort, cannot ioremap video memory 0x%x @ 0x%lx\n",
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.24-rc8-mm1, Andrew Morton, (Thu Jan 17, 6:35 am)
Re: 2.6.24-rc8-mm1, Torsten Kaiser, (Fri Jan 25, 5:59 pm)
Re: 2.6.24-rc8-mm1: old sparc64 bug, Mariusz Kozlowski, (Thu Jan 24, 8:04 pm)
Re: 2.6.24-rc8-mm1: old sparc64 bug, Takashi Iwai, (Fri Jan 25, 1:11 pm)
Re: 2.6.24-rc8-mm1: old sparc64 bug, Mariusz Kozlowski, (Fri Jan 25, 2:34 pm)
Re: 2.6.24-rc8-mm1: old sparc64 bug, Takashi Iwai, (Mon Jan 28, 7:55 am)
Re: 2.6.24-rc8-mm1: old sparc64 bug, Mariusz Kozlowski, (Mon Jan 28, 6:13 pm)
Re: 2.6.24-rc8-mm1 Badness at net/ipv4/tcp_input.c:2506, Kamalesh Babulal, (Thu Jan 24, 2:44 am)
Re: 2.6.24-rc8-mm1 Kernel oops on CIFS while running fsstress, Kamalesh Babulal, (Thu Jan 24, 2:09 am)
Re: 2.6.24-rc8-mm1: sparc64 warning at fs/file_table.c:49 __..., Mariusz Kozlowski, (Tue Jan 22, 4:30 pm)
Re: 2.6.24-rc8-mm1: sparc64 warning at fs/file_table.c:49 __..., Christoph Hellwig, (Wed Jan 23, 1:47 am)
[PATCH} 2.6.24-rc8-mm1 - x86_64 PAT issues with vesafb and N..., , (Mon Jan 21, 2:53 pm)
Re: 2.6.24-rc8-mm1 - SELinux issues, , (Mon Jan 21, 2:31 pm)
Re: 2.6.24-rc8-mm1, Mel Gorman, (Sun Jan 20, 12:31 pm)
Re: 2.6.24-rc8-mm1, Balbir Singh, (Sun Jan 20, 12:35 pm)
Re: 2.6.24-rc8-mm1, Mel Gorman, (Sun Jan 20, 2:24 pm)
Re: 2.6.24-rc8-mm1: WARN_ON() in clockevents_register_device..., Rafael J. Wysocki, (Sat Jan 19, 9:10 pm)
Re: 2.6.24-rc8-mm1: WARN_ON() in clockevents_register_device..., Rafael J. Wysocki, (Sun Jan 20, 7:21 am)
Re: 2.6.24-rc8-mm1, Kyle McMartin, (Fri Jan 18, 2:06 pm)
Re: 2.6.24-rc8-mm1 (KVM build issues), Balbir Singh, (Fri Jan 18, 1:26 pm)
Re: 2.6.24-rc8-mm1 (KVM build issues), Andrew Morton, (Tue Jan 22, 4:40 am)
Re: 2.6.24-rc8-mm1: broken suspend (due to git-cpufreq.patch), Rafael J. Wysocki, (Fri Jan 18, 9:34 am)
Re: 2.6.24-rc8-mm1: broken suspend (due to git-cpufreq.patch), Rafael J. Wysocki, (Fri Jan 18, 4:50 pm)
Re: 2.6.24-rc8-mm1: broken suspend (due to git-cpufreq.patch), Rafael J. Wysocki, (Fri Jan 18, 5:55 pm)
Re: 2.6.24-rc8-mm1 Kernel oops will running kernbench, Kamalesh Babulal, (Fri Jan 18, 4:36 am)
Re: 2.6.24-rc8-mm1 Kernel oops will running kernbench, Andrew Morton, (Fri Jan 18, 4:44 am)
Re: 2.6.24-rc8-mm1 Kernel oops will running kernbench, Paul Mackerras, (Fri Jan 18, 5:01 am)
Re: 2.6.24-rc8-mm1 Kernel oops will running kernbench, Kamalesh Babulal, (Fri Jan 18, 5:34 am)
Re: 2.6.24-rc8-mm1 Kernel oops will running kernbench, Paul Mackerras, (Fri Jan 18, 6:26 am)
Re: 2.6.24-rc8-mm1 Kernel oops will running kernbench, Kamalesh Babulal, (Fri Jan 18, 6:44 am)
Re: 2.6.24-rc8-mm1 Kernel oops will running kernbench, Balbir Singh, (Fri Jan 18, 6:54 am)
Re: 2.6.24-rc8-mm1 Kernel oops will running kernbench, Paul Mackerras, (Fri Jan 18, 6:19 am)
Re: 2.6.24-rc8-mm1 build failure on headers_check, Kamalesh Babulal, (Fri Jan 18, 3:09 am)
Re: 2.6.24-rc8-mm1 build failure on headers_check, Andrew Morton, (Fri Jan 18, 3:38 am)
Re: 2.6.24-rc8-mm1 - mkubootimg wants &lt;zlib.h&gt;, Joseph Fannin, (Thu Jan 17, 5:29 pm)
Re: 2.6.24-rc8-mm1 - mkubootimg wants &lt;zlib.h&gt;, Josh Boyer, (Thu Jan 17, 6:21 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Mariusz Kozlowski, (Thu Jan 17, 6:15 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Andrew Morton, (Thu Jan 17, 6:51 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Matt Mackall, (Thu Jan 17, 7:39 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Andrew Morton, (Thu Jan 17, 8:05 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Matt Mackall, (Thu Jan 17, 8:12 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Andrew Morton, (Thu Jan 17, 8:29 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Matt Mackall, (Thu Jan 17, 8:47 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Mariusz Kozlowski, (Fri Jan 18, 1:23 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Matt Mackall, (Fri Jan 18, 1:33 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Andrew Morton, (Thu Jan 17, 9:07 pm)
Re: 2.6.24-rc8-mm1: powerpc oopses, Matt Mackall, (Thu Jan 17, 9:16 pm)
Re: 2.6.24-rc8-mm1, Matt Mackall, (Thu Jan 17, 5:10 pm)
Re: 2.6.24-rc8-mm1, Matt Mackall, (Thu Jan 17, 9:29 pm)
Re: 2.6.24-rc8-mm1, Andrew Morton, (Fri Jan 18, 1:08 am)
Re: 2.6.24-rc8-mm1, Matt Mackall, (Fri Jan 18, 9:55 am)
Re: 2.6.24-rc8-mm1 powerpc build errors, Olof Johansson, (Thu Jan 17, 3:06 pm)
Re: 2.6.24-rc8-mm1 powerpc build errors, Andrew Morton, (Thu Jan 17, 3:35 pm)
Re: 2.6.24-rc8-mm1 powerpc build errors, Greg KH, (Thu Jan 17, 6:00 pm)
Re: 2.6.24-rc8-mm1: powerpc: include/asm/nvram.h:62: error: ..., Mariusz Kozlowski, (Thu Jan 17, 2:18 pm)
Re: 2.6.24-rc8-mm1: broken suspend, Rafael J. Wysocki, (Thu Jan 17, 2:13 pm)
x86 refuses to build [Re: 2.6.24-rc8-mm1], Dhaval Giani, (Thu Jan 17, 1:28 pm)
Re: x86 refuses to build [Re: 2.6.24-rc8-mm1], Dhaval Giani, (Thu Jan 17, 2:44 pm)
Re: x86 refuses to build [Re: 2.6.24-rc8-mm1], Ingo Molnar, (Fri Jan 18, 4:59 am)
Re: x86 refuses to build [Re: 2.6.24-rc8-mm1], Mike Travis, (Fri Jan 18, 12:16 pm)
Re: 2.6.24-rc8-mm1 (BUG: sched_rt), Randy Dunlap, (Thu Jan 17, 12:48 pm)
Re: 2.6.24-rc8-mm1 (BUG: sched_rt), Peter Zijlstra, (Thu Jan 17, 1:15 pm)
Re: 2.6.24-rc8-mm1 (BUG: sched_rt), Peter Zijlstra, (Thu Jan 17, 1:11 pm)
Re: 2.6.24-rc8-mm1 (BUG: sched_rt), Randy Dunlap, (Thu Jan 17, 3:14 pm)
Re: 2.6.24-rc8-mm1 (BUG: sched_rt), Andrew Morton, (Thu Jan 17, 3:38 pm)
Re: 2.6.24-rc8-mm1 (BUG: sched_rt), Randy Dunlap, (Thu Jan 17, 2:05 pm)
Re: 2.6.24-rc8-mm1 Build Failure on scsi driver, Kamalesh Babulal, (Thu Jan 17, 12:15 pm)
Re: 2.6.24-rc8-mm1 Build Failure on scsi driver, Andrew Morton, (Thu Jan 17, 3:11 pm)
Re: 2.6.24-rc8-mm1 Build Failure on scsi driver, Kamalesh Babulal, (Fri Jan 18, 2:37 am)
Re: 2.6.24-rc8-mm1 Build Failure on scsi driver, Andrew Morton, (Fri Jan 18, 3:27 am)
[PATCH] SCSI: fix isa/pcmcia compile problem, Tejun Heo, (Fri Jan 18, 3:20 am)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, Christoph Hellwig, (Mon Jan 21, 5:56 am)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, James Bottomley, (Mon Jan 21, 10:59 am)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, James Bottomley, (Fri Jan 18, 10:58 am)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, Tejun Heo, (Fri Jan 18, 7:27 pm)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, James Bottomley, (Fri Jan 18, 7:32 pm)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, James Bottomley, (Fri Jan 18, 7:47 pm)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, Tejun Heo, (Fri Jan 18, 7:54 pm)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, Tejun Heo, (Fri Jan 18, 7:46 pm)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, Tejun Heo, (Fri Jan 18, 7:28 pm)
Re: [PATCH] SCSI: fix isa/pcmcia compile problem, Kamalesh Babulal, (Fri Jan 18, 3:30 am)
[PATCH] aha152x: fix isa/pcmcia compile problem, Tejun Heo, (Thu Jan 17, 8:53 pm)
Re: [PATCH] aha152x: fix isa/pcmcia compile problem, Kamalesh Babulal, (Fri Jan 18, 2:29 am)
do_md_run returned -22 [Was: 2.6.24-rc8-mm1], Jiri Slaby, (Thu Jan 17, 11:23 am)
Re: do_md_run returned -22 [Was: 2.6.24-rc8-mm1], Andrew Morton, (Thu Jan 17, 3:01 pm)
[-mm Patch] uml: fix a building error, WANG Cong, (Thu Jan 17, 9:56 am)
Re: [-mm Patch] uml: fix a building error, Mariusz Kozlowski, (Thu Jan 17, 2:11 pm)
Re: [-mm Patch] uml: fix a building error, Jeff Dike, (Thu Jan 17, 2:56 pm)
Re: [-mm Patch] uml: fix a building error, Andrew Morton, (Thu Jan 17, 2:56 pm)
RE: [-mm Patch] uml: fix a building error, Pallipadi, Venkatesh, (Thu Jan 17, 3:38 pm)
Re: [-mm Patch] uml: fix a building error, Jeff Dike, (Thu Jan 17, 5:14 pm)
Re: [-mm Patch] uml: fix a building error, Venki Pallipadi, (Thu Jan 17, 5:41 pm)
Re: [-mm Patch] uml: fix a building error, Jeff Dike, (Thu Jan 17, 7:08 pm)
RE: [-mm Patch] uml: fix a building error, Pallipadi, Venkatesh, (Thu Jan 17, 7:17 pm)
Re: [-mm Patch] uml: fix a building error, Jeff Dike, (Thu Jan 17, 10:19 pm)
Re: [-mm Patch] uml: fix a building error, Mariusz Kozlowski, (Thu Jan 17, 4:42 pm)
Re: [-mm Patch] uml: fix a building error, Andrew Morton, (Thu Jan 17, 3:44 pm)
Re: [-mm Patch] uml: fix a building error, Jeff Dike, (Thu Jan 17, 1:59 pm)
Re: 2.6.24-rc8-mm1 kernel panic while bootup, Kamalesh Babulal, (Thu Jan 17, 9:54 am)
Re: 2.6.24-rc8-mm1 kernel panic while bootup, Andrew Morton, (Thu Jan 17, 2:54 pm)
Re: 2.6.24-rc8-mm1 kernel panic while bootup, Kamalesh Babulal, (Sun Jan 20, 2:24 am)
Re: 2.6.24-rc8-mm1 kernel panic while bootup, Andrew Morton, (Sun Jan 20, 3:17 am)
Re: 2.6.24-rc8-mm1 kernel panic while bootup, Randy Dunlap, (Thu Jan 17, 3:00 pm)
Re: 2.6.24-rc8-mm1, Kamalesh Babulal, (Thu Jan 17, 9:34 am)
Re: 2.6.24-rc8-mm1, Ingo Molnar, (Thu Jan 17, 10:26 am)
[-mm Patch] UML: fix a building error, WANG Cong, (Thu Jan 17, 9:21 am)
Re: [-mm Patch] UML: fix a building error, Jeff Dike, (Thu Jan 17, 1:59 pm)
Re: 2.6.24-rc8-mm1, Balbir Singh, (Thu Jan 17, 8:46 am)
Re: 2.6.24-rc8-mm1, Andrew Morton, (Thu Jan 17, 2:40 pm)
Re: 2.6.24-rc8-mm1, Balbir Singh, (Thu Jan 17, 4:25 pm)
RE: 2.6.24-rc8-mm1, Pallipadi, Venkatesh, (Thu Jan 17, 3:22 pm)
Re: 2.6.24-rc8-mm1, Balbir Singh, (Thu Jan 17, 7:04 pm)
Re: 2.6.24-rc8-mm1, Siddha, Suresh B, (Thu Jan 17, 9:42 pm)
Re: 2.6.24-rc8-mm1, Balbir Singh, (Fri Jan 18, 1:06 am)
Re: 2.6.24-rc8-mm1, Andrew Morton, (Thu Jan 17, 3:40 pm)
Re: 2.6.24-rc8-mm1, Venki Pallipadi, (Thu Jan 17, 7:33 pm)
RE: [E1000-devel] 2.6.24-rc8-mm1, Brandeburg, Jesse, (Thu Jan 17, 3:47 pm)
Re: 2.6.24-rc8-mm1 Build Failure on S390x, Kamalesh Babulal, (Thu Jan 17, 8:41 am)
Re: 2.6.24-rc8-mm1 Build Failure on S390x, Martin Schwidefsky, (Thu Jan 17, 10:05 am)